From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2850130C608 for ; Wed, 21 Jan 2026 08:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768985909; cv=none; b=X+AnRA1Ffxc0cY8Vdoq68GJ1XbAasYGC2ciUMJu1XGem+YU5NQiFHhbBzebMN7NwBmkQWgTkOg6tbB2tcQU1/sLCTzadRtjI6YQFQhAMEnFI1JuIaGlR4+pugA9R4Ctr54VuFhyR3O/qF6b95T+RpCM4rTNaGX/Hvf2cnggE8ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768985909; c=relaxed/simple; bh=nRNveS2MaO6bMX9fxvOOdKwYjrNkmfpz0QY5vX0nE78=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=lE1z7hzh4PdBrklWE6iL1QMd4PBWmS2w2Q/PGhyocmroAzuf+L0ahLd5OpGL7hlaReFPARXfXFrcT+ECZGQ0WWyoSUyuyAVCUMF7bdn58dFlwf0PRf0D0kfVZTzNVw05AulfvFQrejmL0pQnBHo0a0vf2mtyQQ6g7L4oL635DhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=r4AQiqcD; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r4AQiqcD" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so59977685e9.2 for ; Wed, 21 Jan 2026 00:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768985905; x=1769590705; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=G4X8dMKetrdNmqKhKcHZ5SlhB98c1MkwzIAdKHbK4l8=; b=r4AQiqcDlVoYR3qBUG374vIibdlhjQwsePihzmqMi4zs4P0Wm7osLbfI4E7DbrLNPd tEx0SU4Or2hwkrt6G6HUGX9UBQ2LiSGudz2MNBgBk6PAsDPdiOi/NnQVzyRxUpTjv9Gg GG+H8vR/0sGJA1QXrzAx0RkkpXtDSbTMvBHleRNAx7Fjg3I/gyRPOy31LtcKr/6HrxUg bqyCo3kp/cWHs5QYechDkSMzZkSyGnjCUgkvxpE3Fb+5zAdlmhQG86seiJ1REOaKo6Cg poVPjuGW6R7pNJbNE2byaRA2HVI/0THcS3N30DmnRZlB87aDGkdI3ChjQvhHVr+yoxeO uaQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768985905; x=1769590705; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G4X8dMKetrdNmqKhKcHZ5SlhB98c1MkwzIAdKHbK4l8=; b=XZNE0rFCxuOS84C0XknrU8fgk8QHKJ00JbkiW9GV1g2HkIQIKVr+diNeMzGQeXBeyo UuJd92xP6ybs3F6/9A0SlJAGivuMMxy++lX2XA2xuvVXKZodDCQTBtVUpRVMKcCk4VHi i1xBGXXn13v2VbohnZnhbwpGV4wtViE0tCQ/kU0i98zVySqzZFrnXoHR6cB/vH/hsO4o fBMWr4GME5LU7+VVqglFp9xsjLxvWdSqlsy27SMqSlgvyX9RSXWIb7kurnrE1xulQ0fo ieSHQzPx+9uZNOacbYCT+/n8R6xDjEkoG/kskgEHebRPGDArXkf8nDk1ByYtxEuJbVLk h/dw== X-Forwarded-Encrypted: i=1; AJvYcCWw1/9Oy4/m2iJF8Ql2BY2W7FZuNPC2nASs5SRySBJUfVMD2sBFzV5AW/KIPR+Vha8FU4ed+HVgs0XzWVU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLHxWCho44a38XquTWwaKVPNOsAB+W/DrLcoPHT3FoBIxZUhhn RYmgrVT7bbJgSj1eq2H8KAVwNSTT4qfoVMP4s3N6hBzwMHomoDAJdcRNLoqKXiQA4Cg= X-Gm-Gg: AZuq6aLVv66dP4hKXbVcPh0m8LQhhYRseU6wJJh3HWYc3mOE/fKE6fS5WscXsW7ZAbp 5yZkRDGXctpk6+tvGGk5Xrm7tFRsG7zcgmTezRr5hfiaCIOvYqqUPF9Gpem/fyZash5sBY7kdiY VQPVK1XK2eLkKQlQFC9iExRiq1owztYxFXuzzlWMGty2KRRRwvp6d62uQ/QQy8iAZ4Y+5JQ/SM0 a1zm58gqWh4fSyBpZvwmvJj3QUL43NuBAXNgb7wPQP0H10aiShIN8bL6X+PSSo74hzedqeNEzSF hwCYhhVwk2Pc535h9grsmZ62tjWlQY21Bt5HL7GV5rusrSkcV7+FZ6lPB3+HpntXjS7Y81vaov0 K0KARVgiZAJmECQUK9DW2b4ItP00fcf6GJP8WSHv0Ya5j7ilxECMx7XGJp0czzEvFlcmHC88eQB xsrLOam/cTNsannhmhRQ348thVeQM= X-Received: by 2002:a05:600c:8011:b0:47e:dddc:3369 with SMTP id 5b1f17b1804b1-4803e801e7dmr62810625e9.35.1768985905121; Wed, 21 Jan 2026 00:58:25 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804252b02dsm17027785e9.5.2026.01.21.00.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 00:58:24 -0800 (PST) Date: Wed, 21 Jan 2026 11:58:20 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Pasha Tatashin Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List , Jason Gunthorpe , "Mike Rapoport (Microsoft)" Subject: kernel/liveupdate/kexec_handover.c:994 kho_preserve_vmalloc() warn: missing error code 'err' Message-ID: <202601211636.IRaejjdw-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Pasha, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 6c790212c588fddeb0d852f2790840753bb604b1 commit: 48a1b2321d763b5edeaf20bd4576d8c4b5df772b liveupdate: kho: move to kernel/liveupdate config: x86_64-randconfig-r071-20260121 (https://download.01.org/0day-ci/archive/20260121/202601211636.IRaejjdw-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) rustc: rustc 1.88.0 (6b00bc388 2025-06-23) smatch version: v0.5.0-8985-g2614ff1a If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202601211636.IRaejjdw-lkp@intel.com/ smatch warnings: kernel/liveupdate/kexec_handover.c:994 kho_preserve_vmalloc() warn: missing error code 'err' vim +/err +994 kernel/liveupdate/kexec_handover.c a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 960) int kho_preserve_vmalloc(void *ptr, struct kho_vmalloc *preservation) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 961) { a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 962) struct kho_vmalloc_chunk *chunk; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 963) struct vm_struct *vm = find_vm_area(ptr); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 964) unsigned int order, flags, nr_contig_pages; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 965) unsigned int idx = 0; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 966) int err; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 967) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 968) if (!vm) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 969) return -EINVAL; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 970) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 971) if (vm->flags & ~KHO_VMALLOC_SUPPORTED_FLAGS) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 972) return -EOPNOTSUPP; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 973) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 974) flags = vmalloc_flags_to_kho(vm->flags); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 975) order = get_vm_area_page_order(vm); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 976) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 977) chunk = new_vmalloc_chunk(NULL); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 978) if (!chunk) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 979) return -ENOMEM; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 980) KHOSER_STORE_PTR(preservation->first, chunk); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 981) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 982) nr_contig_pages = (1 << order); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 983) for (int i = 0; i < vm->nr_pages; i += nr_contig_pages) { a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 984) phys_addr_t phys = page_to_phys(vm->pages[i]); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 985) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 986) err = kho_preserve_pages(vm->pages[i], nr_contig_pages); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 987) if (err) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 988) goto err_free; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 989) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 990) chunk->phys[idx++] = phys; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 991) if (idx == ARRAY_SIZE(chunk->phys)) { a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 992) chunk = new_vmalloc_chunk(chunk); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 993) if (!chunk) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 @994) goto err_free; err = -ENOMEM; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 995) idx = 0; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 996) } a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 997) } a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 998) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 999) preservation->total_pages = vm->nr_pages; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1000) preservation->flags = flags; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1001) preservation->order = order; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1002) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1003) return 0; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1004) a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1005) err_free: a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1006) kho_vmalloc_free_chunks(preservation); a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1007) return err; a667300bd53f27 kernel/kexec_handover.c Mike Rapoport (Microsoft 2025-09-21 1008) } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki