From: Jakub Kicinski <kuba@kernel.org>
To: Fan Gong <gongfan1@huawei.com>
Cc: Zhu Yikai <zhuyikai1@h-partners.com>, <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
luosifu <luosifu@huawei.com>, Xin Guo <guoxin09@huawei.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Luo Yang <luoyang82@h-partners.com>
Subject: Re: [PATCH net-next v01 1/5] hinic3: Fix netif_queue_set_napi queue_index parameter passing error
Date: Wed, 21 Jan 2026 20:11:45 -0800 [thread overview]
Message-ID: <20260121201145.537a6726@kernel.org> (raw)
In-Reply-To: <fc0a7fdf08789a52653e8ad05281a0a849e79206.1768915707.git.zhuyikai1@h-partners.com>
On Tue, 20 Jan 2026 22:29:47 +0800 Fan Gong wrote:
> Incorrectly transmitted interrupt number instead of queue number
> when using netif_queue_set_napi. Besides, move this to appropriate
> code location.
> Remove redundant netif_stop_subqueue beacuase it is not part of the
> hinic3_send_one_skb process.
The NAPI <> queue mapping is exposed to user space via the netdev
Netlink family. I think this deserves to be treated as a fix and
submitted to net with a Fixes tag. The rest of the patches LGTM
for net-next.
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-22 4:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 14:29 [PATCH net-next v01 0/5] net: hinic3: Fix netif_queue_set_napi input parameters and code styles Fan Gong
2026-01-20 14:29 ` [PATCH net-next v01 1/5] hinic3: Fix netif_queue_set_napi queue_index parameter passing error Fan Gong
2026-01-22 4:11 ` Jakub Kicinski [this message]
2026-01-20 14:29 ` [PATCH net-next v01 2/5] hinic3: Fix code Style(remove empty lines between error handling) Fan Gong
2026-01-20 14:29 ` [PATCH net-next v01 3/5] hinic3: Remove redundant defensive code Fan Gong
2026-01-20 14:29 ` [PATCH net-next v01 4/5] hinic3: Use array_size instead of multiplying Fan Gong
2026-01-20 14:29 ` [PATCH net-next v01 5/5] hinic3: RQ use RQ_CTXT_PREF_CI_HI instead of SQ_CTXT_PREF_CI_HI Fan Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121201145.537a6726@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=luoyang82@h-partners.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox