From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F3D7429809; Thu, 22 Jan 2026 11:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769082108; cv=none; b=T7pUyXQ9ui0d4yMOy8sqZL8PVWM5T/g3/UgX0OlIR0f/YQKOmHWFSuGXqBeySlmJUc0zynluKcv+kQd5NTWSnv+tZRjeWwkyIF6NOLDUKvVJWzMneiWWArtVvxyvAHYt00ZaSmeusKUZq+qBVr7DFQUoG29uBYztZ/3/6TEmyV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769082108; c=relaxed/simple; bh=NqQtXUERc3v4NzNZ99SDCcNfgBv7D/bmH0cyLocfDQo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qsweMJqw5vGSTvAAem1FrZsEFu0UZ551e6YGpbxxY+PtBh3yAv6RTNhgctYu+pJI9BjrZdgT8rdDZGHJp/6JDvZwA74Ryir5P2SlDa0Q1Hi8gKb1cVg/VBYzb71Jr1Lb9KHfgfpw/v96JpOpvYTDILglHb814rm2EQCZLFCGHnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=UEFpYXOg; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="UEFpYXOg" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id B376EC21AA2; Thu, 22 Jan 2026 11:41:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D41D760740; Thu, 22 Jan 2026 11:41:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B0CD5119B0105; Thu, 22 Jan 2026 12:41:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769082094; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Fl2SnsCgDRhlccmCWpsQ4CBlDuamahnW5kxpsohCwvo=; b=UEFpYXOgJL+WIY89Mx/EpOyceBBILQiL0TxFQWpW01yiEySAJH2g1HcWGNeQm8jHeKv+xN O2csc+HhLdo2gWFITsAzh6mTWYo9h+2QnQHxO2GdqZlsPvpTAG/XFqvOefokUsJca73PWu 919NjC9kftG/xECA0iNKY+BT7G6XeddTLl+YrGq6EFQ7innqv2Qzt9u7ZQzupbkT37WFhV mgEsWUeGSzIj/19gb+Tq8BosxVfyi4TFbwa3Kmjo2kuM+uE7HxnX7idMvi9PAvs7Wiw+OR Jl3h0x9NzvUaJ7inKLTNk1kZu+isqj/tgMXHTzscOm2flBtD/RFBursuZs9FuQ== Date: Thu, 22 Jan 2026 12:41:14 +0100 From: Herve Codina To: Geert Uytterhoeven Cc: Matti Vaittinen , Rob Herring , "Rafael J. Wysocki" , Ulf Hansson , Kalle Niemi , linux-arm-kernel@lists.infradead.org, Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Mark Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni , Saravana Kannan Subject: Re: [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays" Message-ID: <20260122124114.44812cc7@bootlin.com> In-Reply-To: References: <20251015071420.1173068-1-herve.codina@bootlin.com> <5cf2a12a-7c66-4622-b4a9-14896c6df005@gmail.com> <072dde7c-a53c-4525-83ac-57ea38edc0b5@gmail.com> <55076f4b-d523-4f8c-8bd4-0645b790737e@gmail.com> <20251202102619.5cd971cc@bootlin.com> <088af3ff-bd04-4bc9-b304-85f6ed555f2a@gmail.com> <20251202175836.747593c0@bootlin.com> <20251204083839.4fb8a4b1@bootlin.com> <20251210132140.32dbc3d7@bootlin.com> <20251211132044.10f5b1ea@bootlin.com> <1b9fa77b-d74a-4fa7-b2e7-8b389d59a5a0@gmail.com> <20251211161902.11ef4248@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Geert, On Wed, 21 Jan 2026 13:59:26 +0100 Geert Uytterhoeven wrote: > Hi Hervé, > > Revisiting his old thread (sorry for the delay)... > > On Thu, 11 Dec 2025 at 16:19, Herve Codina wrote: > > On Thu, 11 Dec 2025 15:52:28 +0200 > > Matti Vaittinen wrote: > > > On 11/12/2025 14:20, Herve Codina wrote: > > > > On Thu, 11 Dec 2025 10:34:46 +0200 > > > > Matti Vaittinen wrote: > > > > Do you see the same trace with: > > > > - "pinctrl-0 = <&i2c1_pins>;" in your overlay > > > > - fragment0 removed from the overlay (i2c1_pins definition removed from > > > > the overlay. > > > > - i2c1_pins node defined in your base DT. > > > > > > Just tested. The i2c1 appears and the test-overlay probe gets called, > > > when the i2c1_pins is in the base-dt and not in the overlay. > > > > Geert, do you expirement same results? > > Yes, after moving the pin control subnode from the overlay[1] to the > base DTS, the SPI bus and FLASH work after loading the overlay for > the first time. Ok. What I said for Matti's use-case is also valid for your use-case. > > > > > In other word, is the issues related to adding a pinctrl sub-node (pinctrl > > > > pins definition) in the overlay or is it something else? > > > > > > Seems to be related to the pinctrl. > > > > I don't think that the issue is related to pinctrl itself. > > > > IMHO, I think the issue is related to overlays and fw_devlink. > > The distinction between "a new node is going to lead to a device" vs "a new > > node is just data and will never been attached to a new device" when an > > overlay is applied is broken. > > > > This is broken with the upstream "treewide: Fix probing of devices in DT > > overlays" commit I've tried to revert. Indeed, on the LAN966x PCI device > > use case devlinks created are not correct with this commit applied. > > > > I am not sure also that devlinks created with a more complex overlay will be > > correct. For instance, Matti, with your overlay not sure that a phandle from > > the oscillator node referencing the pmic node will lead to a correct > > provider/consumer devlink between the pmic device and the oscillator device. > > > > On the other hand, this is broken with "of: dynamic: Fix overlayed devices > > not probing because of fw_devlink" works for the LAN966x PCI device use case > > an lead to correct devlinks but breaks your use cases. > > Loading my overlay[1] causes the following changes under > /sys/class/devlink/: > > + genpd_provider:ca53-cpu0--platform:e6e90000.spi -> > ../../devices/virtual/devlink/genpd_provider:ca53-cpu0--platform:e6e90000.spi > + platform:e6055000.gpio--platform:e6e90000.spi -> > ../../devices/virtual/devlink/platform:e6055000.gpio--platform:e6e90000.spi > + platform:e6060000.pinctrl--platform:e6e90000.spi -> > ../../devices/virtual/devlink/platform:e6060000.pinctrl--platform:e6e90000.spi > - platform:e6060000.pinctrl--platform:keys -> > ../../devices/virtual/devlink/platform:e6060000.pinctrl--platform:keys > + platform:e6150000.clock-controller--platform:e6e90000.spi -> > ../../devices/virtual/devlink/platform:e6150000.clock-controller--platform:e6e90000.spi > + platform:soc--platform:e6e90000.spi -> > ../../devices/virtual/devlink/platform:soc--platform:e6e90000.spi > > Note that these changes are exactly the same in the working and the > non-working case. > > Removing the overlay again removes all added links, but does not > restore the keys link: I think you should have the exact same behavior with and without my modification. Can you confirm? Best regards, Hervé