From: Qiliang Yuan <realwujing@gmail.com>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org
Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
linux-kernel@vger.kernel.org, yuanql9@chinatelecom.cn,
Qiliang Yuan <realwujing@gmail.com>
Subject: [PATCH] sched/fair: Cache NUMA node statistics to avoid O(N) scanning
Date: Thu, 22 Jan 2026 11:16:46 -0500 [thread overview]
Message-ID: <20260122161647.142704-1-realwujing@gmail.com> (raw)
Optimize update_numa_stats() by leveraging pre-calculated group statistics from the load balancer hierarchy. This reduces the complexity of NUMA balancing overhead from O(CPUs_per_node) to O(1) in the hot path when stats are fresh.
Signed-off-by: Qiliang Yuan <realwujing@gmail.com>
Signed-off-by: Qiliang Yuan <yuanql9@chinatelecom.cn>
---
kernel/sched/fair.c | 35 +++++++++++++++++++++++++++++++++++
kernel/sched/sched.h | 7 +++++++
2 files changed, 42 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e71302282671..dc46262bd227 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2099,11 +2099,36 @@ static void update_numa_stats(struct task_numa_env *env,
bool find_idle)
{
int cpu, idle_core = -1;
+ struct sched_domain *sd;
+ struct sched_group *sg;
memset(ns, 0, sizeof(*ns));
ns->idle_cpu = -1;
rcu_read_lock();
+ /* Algorithmic Optimization: Avoid O(N) scan by using cached stats from load balancer */
+ sd = rcu_dereference(per_cpu(sd_numa, env->src_cpu));
+ if (sd && !find_idle) {
+ sg = sd->groups;
+ do {
+ /* Check if this group corresponds to the node we are interested in */
+ if (cpumask_test_cpu(cpumask_first(cpumask_of_node(nid)), sched_group_span(sg))) {
+ /* Use cached stats if they are recent enough (e.g. within 10ms) */
+ if (time_before(jiffies, sg->sgc->stats_update + msecs_to_jiffies(10))) {
+ ns->load = sg->sgc->load;
+ ns->runnable = sg->sgc->runnable;
+ ns->util = sg->sgc->util;
+ ns->nr_running = sg->sgc->nr_running;
+ ns->compute_capacity = sg->sgc->capacity;
+ rcu_read_unlock();
+ goto skip_scan;
+ }
+ break;
+ }
+ sg = sg->next;
+ } while (sg != sd->groups);
+ }
+
for_each_cpu(cpu, cpumask_of_node(nid)) {
struct rq *rq = cpu_rq(cpu);
@@ -2126,6 +2151,7 @@ static void update_numa_stats(struct task_numa_env *env,
}
rcu_read_unlock();
+skip_scan:
ns->weight = cpumask_weight(cpumask_of_node(nid));
ns->node_type = numa_classify(env->imbalance_pct, ns);
@@ -10488,6 +10514,15 @@ static inline void update_sg_lb_stats(struct lb_env *env,
if (sgs->group_type == group_overloaded)
sgs->avg_load = (sgs->group_load * SCHED_CAPACITY_SCALE) /
sgs->group_capacity;
+
+ /* Algorithmic Optimization: Cache group stats for O(1) NUMA lookups */
+ if (env->sd->flags & SD_NUMA) {
+ group->sgc->nr_running = sgs->sum_h_nr_running;
+ group->sgc->load = sgs->group_load;
+ group->sgc->util = sgs->group_util;
+ group->sgc->runnable = sgs->group_runnable;
+ WRITE_ONCE(group->sgc->stats_update, jiffies);
+ }
}
/**
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index d30cca6870f5..81160790993e 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -2105,6 +2105,13 @@ struct sched_group_capacity {
int id;
+ /* O(1) NUMA stats cache */
+ unsigned long nr_running;
+ unsigned long load;
+ unsigned long util;
+ unsigned long runnable;
+ unsigned long stats_update;
+
unsigned long cpumask[]; /* Balance mask */
};
--
2.51.0
next reply other threads:[~2026-01-22 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 16:16 Qiliang Yuan [this message]
2026-01-22 16:16 ` [PATCH] sched/numa: Optimize NUMA placement algorithm complexity from O(Nodes) to O(Active_Nodes) Qiliang Yuan
2026-01-23 1:39 ` [PATCH v2] sched/fair: Cache NUMA node statistics to avoid O(N) scanning Qiliang Yuan
2026-01-23 3:10 ` K Prateek Nayak
2026-01-26 11:02 ` [PATCH v3] " Qiliang Yuan
2026-01-26 15:30 ` kernel test robot
2026-01-26 16:23 ` kernel test robot
2026-01-27 3:25 ` K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122161647.142704-1-realwujing@gmail.com \
--to=realwujing@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yuanql9@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox