From: Jason Gunthorpe <jgg@nvidia.com>
To: Zhi Wang <zhiw@nvidia.com>
Cc: rust-for-linux@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, dakr@kernel.org,
aliceryhl@google.com, bhelgaas@google.com,
kwilczynski@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
lossin@kernel.org, a.hindborg@kernel.org, tmgross@umich.edu,
markus.probst@posteo.de, helgaas@kernel.org, cjia@nvidia.com,
smitra@nvidia.com, ankita@nvidia.com, aniketa@nvidia.com,
kwankhede@nvidia.com, targupta@nvidia.com, acourbot@nvidia.com,
joelagnelf@nvidia.com, jhubbard@nvidia.com, zhiwang@kernel.org,
daniel.almeida@collabora.com
Subject: Re: [PATCH v2 2/2] samples: rust: fwctl: add sample code for fwctl
Date: Thu, 22 Jan 2026 16:58:06 -0400 [thread overview]
Message-ID: <20260122205806.GU1134360@nvidia.com> (raw)
In-Reply-To: <20260122204232.15988-3-zhiw@nvidia.com>
On Thu, Jan 22, 2026 at 10:42:31PM +0200, Zhi Wang wrote:
> This patch adds a sample Rust driver demonstrating the usage of the fwctl
> Rust abstractions. Add sample code for creating a FwCtl device, getting
> device info and issuing an RPC.
>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Zhi Wang <zhiw@nvidia.com>
> ---
> samples/rust/Kconfig | 11 +++
> samples/rust/Makefile | 1 +
> samples/rust/rust_driver_fwctl.rs | 136 ++++++++++++++++++++++++++++++
> 3 files changed, 148 insertions(+)
> create mode 100644 samples/rust/rust_driver_fwctl.rs
Is this normal for Rust? Can we delete it when a real driver is
merged?
I'm not so keen on sample drivers, I've spent far too much time lately
touching sample drivers that nobody ever uses :(
Jason
next prev parent reply other threads:[~2026-01-22 20:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 20:42 [PATCH v2 0/2] rust: introduce abstractions for fwctl Zhi Wang
2026-01-22 20:42 ` [PATCH v2 1/2] " Zhi Wang
2026-01-22 21:17 ` Joel Fernandes
2026-01-23 10:25 ` Zhi Wang
2026-01-26 17:48 ` Gary Guo
2026-01-27 19:59 ` Zhi Wang
2026-01-26 18:19 ` Jason Gunthorpe
2026-01-27 19:57 ` Zhi Wang
2026-01-27 20:07 ` Danilo Krummrich
2026-01-28 0:04 ` Jason Gunthorpe
2026-01-28 1:21 ` Danilo Krummrich
2026-01-28 13:20 ` [PATCH v2 1/2] rust: introduce abstractions for fwctlg Jason Gunthorpe
2026-01-28 14:01 ` Danilo Krummrich
2026-01-28 14:59 ` Jason Gunthorpe
2026-01-28 15:49 ` Danilo Krummrich
2026-01-28 15:56 ` Jason Gunthorpe
2026-01-28 16:35 ` Danilo Krummrich
2026-01-28 16:39 ` Jason Gunthorpe
2026-01-28 17:26 ` Zhi Wang
2026-01-28 17:30 ` Zhi Wang
2026-01-28 17:39 ` Jason Gunthorpe
2026-01-28 17:40 ` Danilo Krummrich
2026-01-28 11:36 ` [PATCH v2 1/2] rust: introduce abstractions for fwctl Zhi Wang
2026-01-28 11:41 ` Danilo Krummrich
2026-01-27 20:09 ` Danilo Krummrich
2026-01-22 20:42 ` [PATCH v2 2/2] samples: rust: fwctl: add sample code " Zhi Wang
2026-01-22 20:58 ` Jason Gunthorpe [this message]
2026-01-22 21:06 ` Danilo Krummrich
2026-01-22 21:16 ` John Hubbard
2026-01-23 10:23 ` Zhi Wang
2026-01-26 17:59 ` Gary Guo
2026-01-22 21:32 ` [PATCH v2 0/2] rust: introduce abstractions " Danilo Krummrich
2026-01-23 10:14 ` Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122205806.GU1134360@nvidia.com \
--to=jgg@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cjia@nvidia.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=helgaas@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox