From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AD0C42A80 for ; Thu, 22 Jan 2026 23:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769125074; cv=none; b=t1UTM9qOdrj/2NN82fs/8pjBEc8VPGoRjkx0bBjJojO4NBu6/1YG84y0UXgG/w5YzkSmE2SErjXO8QkvqLsvzrmJhH5v+/q230mV6TaZmMTGYQAxFM7xLNwI4i/SG2T50UmFUrIdXodPaelnCN9E4CxE1HJZbcep2A7DvhPin34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769125074; c=relaxed/simple; bh=6XGtJQywpqmosyYrCosqc3I9CRVHTZWO+/CMBFEch+g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cp7Y+X9ffoGSCwF8J5yuiy/wuvzluav77fWuSwKuIDWsA3QZioO5OvxEzUuqO3BI5se3Z+f62HyLxYB1ZHB1Ewmg2AAhYWgzyPipgxqCXQuDarQtvIF50Nu8CrD0cEwzIICXsR7BqZhcnLHhRBFLFRG/wCNqLaNy+NJjxoPA3Ho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=QOkIXgHM; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="QOkIXgHM" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-89476eaaf16so16844146d6.1 for ; Thu, 22 Jan 2026 15:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1769125061; x=1769729861; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FfXBu7LAWDQnsgm7Hb+Sdya9B9wy+rjzXCa0xANmbwc=; b=QOkIXgHM+MGFH0cXQPoHuRYHJTnEiWqECbw9DRNv4p6zNKKUG+bp2+A4W1zykQeCLW gZUw52hmg3EU5++3gS52HYOLaWnxS567AKWDPwYdjH0Rl3XFPoGkT9Ahriczsn67EMW+ vgSgY4zuVaCxq4W4H2+w7AV2nlnXzYrn/yYkqm027YgnONWKEHA3wdZ6Wy0aoejl3FZE lr8jBDY/LmBpYIZo0vbxpjPLicE7aXKL8t+w8BnU6QgwUcz9qOLXd6BLtjz/5EEAL3LC FHLmQWjsIRY82a8hJxRF9K60IlaZuSSzZW2+DyuB8jSE+GPcSjDJ+8x7PqeM99o9OvQi fwdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769125061; x=1769729861; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FfXBu7LAWDQnsgm7Hb+Sdya9B9wy+rjzXCa0xANmbwc=; b=HdeZJdGz+RUtFc84pKc6UCeAAjhIbtMeblhIQnIuzOQ90W9LV6tnbZ9R0KQh7v4nom +36C5Te9rQQQyeFVFS+drUrO93sODklHfdmqMfUGHV4/hMSoC41lrVSrEVVy2uZd3ht2 PUZF/0Fje98JtWn/3J85ZlQKhE9TwQqObOSarkR58n2OUqd1YALrVKFmYK897Yd80cho 2iI6j63SJbMMQdASzr+SM4G6cYko28Xgr2h1lClzc0hcrpq2zGgDb1oa54OsM16uBZje wefR6e6blB8yRBrQYCdUNkjRNlsTfGrDG3ZYYHEwC/CHJDf+hY1wGY9ckk0k40YpTwWX oW6w== X-Forwarded-Encrypted: i=1; AJvYcCVk2TshSFes+k5Z83qsqcoeONxze1tdXOo0MBV/BqVy4fPzekzTZfcHqxeHxDs4Bo29Q9ncV9n96a/Fpsk=@vger.kernel.org X-Gm-Message-State: AOJu0YyaHnsy02Dk4VFtcmccHuRafezgr3SFuonOa8MDVZ+zdyFPpHVh YhoFj/p4A5aW3yLMgIR45+L2Qxd1QK823MeNOkenbYPKJ+9CQiFQQLe9yKmgc6AXDaA= X-Gm-Gg: AZuq6aKMgr10a7tNJ3k1CsqDmEFr+GmzruUt8PnshSK7k+sTAbUfrCjZUwR/dKAJ0zH gU9rhWPlt7RwpL4/Ygdl23ARb0O6AkuYAmbZhaZyx4xF7BCq/Hw3CLWtvfpru+ntgS/Nb1wWeYu ir10nH8ctHb+3x9VTflVHvBfIZmttAeXjLqWUZKWUXe5gAN9gj01Zmv8LLcqUwQtlyPu2/v8Tq+ RdC99TUFI6QqM8TXeXYRiajobCHfMxyWfcCdkFM+/uHjr3GZwIzWW1igoiZc6tnvety2nhvpQiN oi+tk9omEvoSWOf4H31WsFmmwqQ52vFaEyaqu+g3Yr6R6fDVWV0PQHNeM4Kc6AQP/YDTa0Ex0vk Kq5K/oY9WzgBuFuNVf8TQQGCBjRh0HnxUgV4z27VK6wKagVWioXJtbbEauzWPUMUEDaVjroIC8n Z6wmXPPoM1mC8XC8RU2Br8jt56mHYeRjo+a5YG/Yfx2q3xXfxlJYIbdkJ+EdSuoRh3RA8= X-Received: by 2002:a05:6214:c2f:b0:88a:2fd1:b582 with SMTP id 6a1803df08f44-8949022bd07mr17695716d6.47.1769125061444; Thu, 22 Jan 2026 15:37:41 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89491821e98sm4770066d6.9.2026.01.22.15.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 15:37:40 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vj4FA-00000006gPw-1bNk; Thu, 22 Jan 2026 19:37:40 -0400 Date: Thu, 22 Jan 2026 19:37:40 -0400 From: Jason Gunthorpe To: Nathan Chancellor Cc: Joerg Roedel , Suravee Suthikulpanit , Will Deacon , Robin Murphy , Vasant Hegde , Nicolin Chen , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Fix type of type parameter to amd_iommufd_hw_info() Message-ID: <20260122233740.GA1589888@ziepe.ca> References: <20260122-amd-iommufd-fix-wifpts-v1-1-8ee604527875@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260122-amd-iommufd-fix-wifpts-v1-1-8ee604527875@kernel.org> On Thu, Jan 22, 2026 at 02:42:38PM -0700, Nathan Chancellor wrote: > When building with -Wincompatible-function-pointer-types-strict, a > warning designed to catch kernel control flow integrity (kCFI) issues at > build time, there is an instance around amd_iommufd_hw_info(): > > drivers/iommu/amd/iommu.c:3141:13: error: incompatible function pointer types initializing 'void *(*)(struct device *, u32 *, enum iommu_hw_info_type *)' (aka 'void *(*)(struct device *, unsigned int *, enum iommu_hw_info_type *)') with an expression of type 'void *(struct device *, u32 *, u32 *)' (aka 'void *(struct device *, unsigned int *, unsigned int *)') [-Werror,-Wincompatible-function-pointer-types-strict] > 3141 | .hw_info = amd_iommufd_hw_info, > | ^~~~~~~~~~~~~~~~~~~ > > While 'u32 *' and 'enum iommu_hw_info_type *' are ABI compatible, hence > no regular warning from -Wincompatible-function-pointer-types, the > mismatch will trigger a kCFI violation when amd_iommufd_hw_info() is > called indirectly. > > Update the type parameter of amd_iommufd_hw_info() to be > 'enum iommu_hw_info_type *' to match the prototype in > 'struct iommu_ops', clearing up the warning and kCFI violation. > > Fixes: 7d8b06ecc45b ("iommu/amd: Add support for hw_info for iommu capability query") > Signed-off-by: Nathan Chancellor > --- > drivers/iommu/amd/iommufd.c | 2 +- > drivers/iommu/amd/iommufd.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe