From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 043322DC338 for ; Fri, 23 Jan 2026 12:57:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769173076; cv=none; b=Fskku9jKjbi8IxUrR5fBw7Nak+jL01A+LWt02TOAMvEjKNTaajh61g54H9xZAjws8kbwfmIosVUvDpn82oke1oEP75flrOCvmU2ZjmEiMI3/QEu7e3ODFkCydcH5gY3uMOU+yiPEqPd/eFLXF9hotUIni39JCmcqA+VgVtiTD/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769173076; c=relaxed/simple; bh=rWBVAuGP12n99DDYOBAxK5U9/YbnI5jCL2Vby+G7PXI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=orFvSFk760U8RmQIotgAtZazP1BsDH6ydgaG86kNE+OlfiE7O6VmUraPk4gc87ERfGxvd46Pp6dJsrgrQ2RveE9pu9tDoYPI7GT4HXWxlbQp48iQtf9I/WNzfaGcBQoB3NDAHYsbdFA53PEXgT8zrDTOJIsXCaikBn5W1WHWJeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N5ZkSIHD; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N5ZkSIHD" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so1984243f8f.2 for ; Fri, 23 Jan 2026 04:57:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769173073; x=1769777873; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=23k0nL5or/g/Ncq6j1GNEPEPQgp73ML8YdFMHnjI+yo=; b=N5ZkSIHDhZPBddUJfdU9EfuCEnHl8TiV2V8NQFHhiuygKucbvSurg0S2oSgUfnwTfQ qLm+ltiHKcOC85AQ925Ih31PDx7HMMcFba3KCxCyKNQwgGQV9PmiEaPqqQ9a6kiwoi4L y9wkSfF4KjJvjY9cdr5EtzKdbIMIiIn/P8XDnPQmqglODAplxRxaE7blJlIGFrkWt7rb 3wD5Z5VCpM2oUrUKVeAdOPx1EJFcGgGb8y7X4Yox4avMEFcWztUyUQZ6s51krOD9II0y QxENnM+GDtR+bKUmMwKZoMprfbQg/wZsYH//n9Iwms3OC2ov6VpXBK+vFdNw0I4IuALF VOUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769173073; x=1769777873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=23k0nL5or/g/Ncq6j1GNEPEPQgp73ML8YdFMHnjI+yo=; b=lPIV34FHdSEJo8umiiJAOYWXxgxoLFaqeatzUGm6rpLMhnVijyiEev55KjmHQ+xUDU TZvdqg/nqhHd8KSbVCxuZZLOzuCF7/8jopLFa7a7bFXXpSnODaykKWp2i1qnTjFvev/R tZc9t9jErHKbnLHmwTAFUXqlCS3+Q3bFrmNJMpfjUnp0UJ1KMiHCNbrucIlyXP4X6FA3 3+aUb46/YMkqTOy7Z4zQaAL/4nElIPuWZS/t39u3w24E/3dGPe4Ti2dWpQxTJxlmAiYx nhEUG2wqyUORNXQJXtj7Zc66o5zWuJ7YIPkL88kcT0i7Wor1e767lovrj8r54FUf956r 8rEg== X-Forwarded-Encrypted: i=1; AJvYcCW3gxMxPsyiJ6LT1FI7lM7c0LWmaMX6DsQKtd2baA6jb8SO61liHeTE3D3sjyxPGktXLPEs6HMCh4Ddvh8=@vger.kernel.org X-Gm-Message-State: AOJu0YyRi/Uqdxg1EkXFYQpb/OLVudOlyVSC8fFUqdKiTQZ2hHPhdPxd 2lbZFXZgNA0vhFSmJdT3auSnxuH21uNu8450akaxq78jWbMp2Y+Ss7HR X-Gm-Gg: AZuq6aJg7Z1jXAwknvdqmnWqmIBtYr5Qm6GPv7dzma/1W9KzKVg07C+zWd4XtLBfEkz anTri153qgeWZRA37qr5UbveO4RZfIWhNYPaCKELNzK9jw+ciuo8IiQWYIFVD/60zOfbOH3n6jM pafW/Akmf2qKhKQTC9hL9rgt9e/kpehyTsizXJJrqNkxIL8FNX0gS0A5oc2Ei5izJWe+aWyx7B1 kB/RBSVhJ5vx6BUkc9kPf4jtX8riZ9DGY79oEbSHyUQXA3uoJFPLUOHmnYY33fnn8WE2el2kPEx fyNpPFhkmnADpwsjNvgpKCux2yrhlNVVokpZAW86iivnMbdt5T43B5lzLm68sQLGZtF8UHnZkY6 4eTdGLAgwexYmkM7XdcqHABVjhoBUMJqUGyfIYCtEeNv4h/i85YXQN9gAlOdnyQGBo1lO90uVY4 xBU5asnvomCZs5IuTkxNP/9LU4p8c9YeR6bM7WZ58kopKrtIaJinX/kPy08uY= X-Received: by 2002:a05:6000:22c1:b0:42b:38b1:e32e with SMTP id ffacd0b85a97d-435b160587amr5594957f8f.46.1769173073087; Fri, 23 Jan 2026 04:57:53 -0800 (PST) Received: from flaviu-Aspire-E5-572G.. ([5.15.64.173]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1e717cbsm6573336f8f.24.2026.01.23.04.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 04:57:52 -0800 (PST) From: Flaviu Nistor To: Guenter Roeck , Rob Herring , Conor Dooley Cc: Jean Delvare , Krzysztof Kozlowski , Flaviu Nistor , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: hwmon: tmp102: Add TMP110 and TMP113 devices Date: Fri, 23 Jan 2026 14:57:47 +0200 Message-ID: <20260123125747.4270-1-flaviu.nistor@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250929170730.8285-1-flaviu.nistor@gmail.com> References: <20250929170730.8285-1-flaviu.nistor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Sep 29, 2025 at 08:07:43PM +0300, Flaviu Nistor wrote:=0D >On Mon, Sep 24, 2025 at 19:12:26 +0100, Conor Dooley wrote:=0D >>On Wed, Sep 24, 2025 at 08:55:39AM -0700, Guenter Roeck wrote:=0D >>> On 9/15/25 10:18, Conor Dooley wrote:=0D >>> > On Mon, Sep 15, 2025 at 08:08:18PM +0300, Flaviu Nistor wrote:=0D >>> > > Add a compatible string for TMP110 and TMP113 devices.=0D >>> > > =0D >>> > > Signed-off-by: Flaviu Nistor =0D >>> > > ---=0D >>> > > Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 2 ++=0D >>> > > 1 file changed, 2 insertions(+)=0D >>> > > =0D >>> > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml= b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml=0D >>> > > index 96b2e4969f78..840b5306a8cf 100644=0D >>> > > --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml=0D >>> > > +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml=0D >>> > > @@ -13,6 +13,8 @@ properties:=0D >>> > > compatible:=0D >>> > > enum:=0D >>> > > - ti,tmp102=0D >>> > > + - ti,tmp110=0D >>> > > + - ti,tmp113=0D >>> > =0D >>> > The driver has no match data and no compatible based decisions added = in=0D >>> > your patch. Why is a fallback to tmp102 not suitable?=0D >>> > =0D >>> =0D >>> That should work for tmp110. However, tmp113 does have additional regis= ters, and it=0D >>> might be desirable to report the content of those using debugfs. Fallba= ck for that chip=0D >>> would work for now, but that might have to change later if support for = the additional=0D >>> registers is added to the driver.=0D >>=0D >> In that case, only the driver would need to change not the binding.=0D >> That's fine though, of course.=0D >>=0D >=0D > I am a little confused and I would appreciate some advice if I should lea= ve=0D > the series as it is or send a v2 only for documentation and Kconfig updat= es,=0D > droping the binding update?=0D >=0D >>> =0D >>> Guenter=0D >>> =0D >>> > > interrupts:=0D >>> > > maxItems: 1=0D >>> > > -- =0D >>> > > 2.43.0=0D >>> > > =0D >>>=0D =0D After some time (probably to much) I went through the patch again and=0D based on Rob Herring response:=0D https://lore.kernel.org/all/20250922162004.GA199858-robh@kernel.org/=0D and a similar example for sensirion sh20, sh21 and sh25 sensors, =0D where individual compatible string were added in the binding and the=0D driver even if there is no match data:=0D https://lore.kernel.org/all/20250908-sht2x-v4-3-bc15f68af7de@gmail.com/=0D https://lore.kernel.org/all/20250908-sht2x-v4-4-bc15f68af7de@gmail.com/=0D I think that the patch can stay as it is for the binding, so different=0D compatible string can be use in the device tree in order for the real=0D hardware to be describe.=0D =0D Flaviu=0D