From: Thomas Gleixner <tglx@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
John Stultz <jstultz@google.com>,
Waiman Long <longman@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
x86@kernel.org, "Gautham R. Shenoy" <gautham.shenoy@amd.com>,
Jiri Wiesner <jwiesner@suse.de>,
Daniel J Blueman <daniel@quora.org>,
Scott Hamilton <scott.hamilton@eviden.com>,
Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org
Subject: [patch 3/5] x86/tsc: Handle CLOCK_SOURCE_VALID_FOR_HRES correctly
Date: Sat, 24 Jan 2026 00:17:55 +0100 [thread overview]
Message-ID: <20260123231521.790598171@kernel.org> (raw)
In-Reply-To: 20260123230651.688818373@kernel.org
Unconditionally setting the CLOCK_SOURCE_VALID_FOR_HRES for the real TSC
clocksource is wrong as there is no guarantee that the early TSC was
validated for high resolution mode.
Set the flag only when the early TSC was validated as otherwise the
clocksource selection might enable high resolution mode with a TSC of
unknown quality and possibly no way to back out once it is discovered to be
unsuitable.
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Cc: x86@kernel.org
---
arch/x86/kernel/tsc.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -1193,7 +1193,6 @@ static struct clocksource clocksource_ts
.read = read_tsc,
.mask = CLOCKSOURCE_MASK(64),
.flags = CLOCK_SOURCE_IS_CONTINUOUS |
- CLOCK_SOURCE_VALID_FOR_HRES |
CLOCK_SOURCE_MUST_VERIFY |
CLOCK_SOURCE_VERIFY_PERCPU,
.id = CSID_X86_TSC,
@@ -1403,6 +1402,15 @@ static void tsc_refine_calibration_work(
have_art = true;
clocksource_tsc.base = &art_base_clk;
}
+
+ /*
+ * Transfer the valid for high resolution flag if it was set on the
+ * early TSC already. That guarantees that there is no intermediate
+ * clocksource selected once the early TSC is unregistered.
+ */
+ if (clocksource_tsc_early.flags & CLOCK_SOURCE_VALID_FOR_HRES)
+ clocksource_tsc.flags |= CLOCK_SOURCE_VALID_FOR_HRES;
+
clocksource_register_khz(&clocksource_tsc, tsc_khz);
unreg:
clocksource_unregister(&clocksource_tsc_early);
next prev parent reply other threads:[~2026-01-23 23:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 23:17 [patch 0/5] clocksource: Rewrite clocksource watchdog and related cleanups Thomas Gleixner
2026-01-23 23:17 ` [patch 1/5] parisc: Remove unused clocksource flags Thomas Gleixner
2026-01-24 8:40 ` Helge Deller
2026-03-12 11:25 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-01-23 23:17 ` [patch 2/5] MIPS: Dont select CLOCKSOURCE_WATCHDOG Thomas Gleixner
2026-01-24 22:28 ` Maciej W. Rozycki
2026-01-26 9:10 ` Thomas Gleixner
2026-03-12 11:25 ` [tip: timers/core] MIPS: Don't " tip-bot2 for Thomas Gleixner
2026-01-23 23:17 ` Thomas Gleixner [this message]
2026-03-12 11:25 ` [tip: timers/core] x86/tsc: Handle CLOCK_SOURCE_VALID_FOR_HRES correctly tip-bot2 for Thomas Gleixner
2026-01-23 23:17 ` [patch 4/5] clocksource: Dont use non-continuous clocksources as watchdog Thomas Gleixner
2026-03-12 11:25 ` [tip: timers/core] clocksource: Don't " tip-bot2 for Thomas Gleixner
2026-01-23 23:18 ` [patch 5/5] clocksource: Rewrite watchdog code completely Thomas Gleixner
2026-02-02 6:45 ` Daniel J Blueman
2026-02-02 11:27 ` Thomas Gleixner
2026-02-15 12:18 ` Daniel J Blueman
2026-02-23 13:53 ` Thomas Gleixner
2026-03-08 9:53 ` Thomas Gleixner
2026-03-15 14:59 ` Daniel J Blueman
2026-03-17 9:01 ` Thomas Gleixner
2026-03-18 14:10 ` Daniel J Blueman
2026-03-19 20:31 ` Thomas Gleixner
2026-03-20 2:21 ` Daniel J Blueman
2026-03-20 8:26 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-03-20 12:42 ` tip-bot2 for Thomas Gleixner
2026-02-25 18:13 ` [patch 5/5] " Jiri Wiesner
2026-03-08 10:05 ` Thomas Gleixner
2026-03-11 13:12 ` Jiri Wiesner
2026-03-09 15:43 ` Borislav Petkov
2026-03-11 7:58 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123231521.790598171@kernel.org \
--to=tglx@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@quora.org \
--cc=deller@gmx.de \
--cc=gautham.shenoy@amd.com \
--cc=jstultz@google.com \
--cc=jwiesner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=longman@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sboyd@kernel.org \
--cc=scott.hamilton@eviden.com \
--cc=tsbogend@alpha.franken.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox