From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46775184; Fri, 23 Jan 2026 16:07:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769184479; cv=none; b=GahP4O6Q2mA106+3bXVpxxKsonxP9IOvk1CZ/Lxg6stfl9MQ++kk10UCxCg8aV0SlQabTgJrLwhl7UAT+TqB9QDXrGuukCkW2un+P03g85AC43BfHi/iludK6OGiYz0uB40/7xHEG4PSPP5VJkQ7hvYvfXq1BWcOSOwHTpz5+UY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769184479; c=relaxed/simple; bh=jANtvkvIzP+xKH1SCaNcy8oujz1Ah1SVWDfbHf388q4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LvPL2VGvWStUmbF4/I39rpqLEV+8YbEQRXFLrjp2JIzyCaqlQ8ja07LoA1hwRJa0/3FOUBR3b0Nz3HTQGi3Vm9Ju8N94oDEqm9vcxBBSELPLVB+LoAwGt1FDDobE6KpChfrar58ByTXlrzUJmNH8TEiH8LKjdt80dr7Tl3obr7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=c20TNpBW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="c20TNpBW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34441C4CEF1; Fri, 23 Jan 2026 16:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769184478; bh=jANtvkvIzP+xKH1SCaNcy8oujz1Ah1SVWDfbHf388q4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c20TNpBW+zLeuHG1B7CftROChisTnbGR/CVGoJYymp6Hr4q4bzynoJdxu+HqeWyhL aR1YJaT8f/LkJhik/j8lWvfv7pfIE34ARqSTaKTtlSlrUT2lXiI6ZzwzRfUfTvLq+m R+rVBm+YZg+JRtTqbKR0n09J2AmPK+djjP49VuJE= Date: Fri, 23 Jan 2026 17:07:55 +0100 From: Greg Kroah-Hartman To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Thomas Gleixner , Heikki Krogerus , linux-usb@vger.kernel.org Subject: Re: [PATCH 13/21] usb: typec: fusb302: Remove IRQF_ONESHOT Message-ID: <2026012349-energetic-simplify-7a77@gregkh> References: <20260123113708.416727-1-bigeasy@linutronix.de> <20260123113708.416727-14-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123113708.416727-14-bigeasy@linutronix.de> On Fri, Jan 23, 2026 at 12:36:59PM +0100, Sebastian Andrzej Siewior wrote: > Passing IRQF_ONESHOT ensures that the interrupt source is masked until > the secondary (threaded) handler is done. If only a primary handler is > used then the flag makes no sense because the interrupt can not fire > (again) while its handler is running. > The flag also disallows force-threading of the primary handler and the > irq-core will warn about this. > > Remove IRQF_ONESHOT from irqflags. > > Cc: Heikki Krogerus > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Fixes: 309b6341d5570 ("usb: typec: fusb302: Revert incorrect threaded irq fix") > Signed-off-by: Sebastian Andrzej Siewior > --- > drivers/usb/typec/tcpm/fusb302.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c > index 870a71f953f6c..19ff8217818e7 100644 > --- a/drivers/usb/typec/tcpm/fusb302.c > +++ b/drivers/usb/typec/tcpm/fusb302.c > @@ -1756,8 +1756,7 @@ static int fusb302_probe(struct i2c_client *client) > } > > ret = request_irq(chip->gpio_int_n_irq, fusb302_irq_intn, > - IRQF_ONESHOT | IRQF_TRIGGER_LOW, > - "fsc_interrupt_int_n", chip); > + IRQF_TRIGGER_LOW, "fsc_interrupt_int_n", chip); > if (ret < 0) { > dev_err(dev, "cannot request IRQ for GPIO Int_N, ret=%d", ret); > goto tcpm_unregister_port; > -- > 2.51.0 > Acked-by: Greg Kroah-Hartman