From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F4C12773C1 for ; Mon, 26 Jan 2026 06:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769409244; cv=none; b=MhSp5dDYvGcsVXAeK2/8l/RyU65pG88LPkrOX3+0MBwkUheiBImQH7EEN3MbLvehMOEC3X7clPdaE4c6Lk3QuTkmKyVk8yykmU8mKEEYu4Gp0eOrT9dyzTMqGekD4u720oIGgKgttopTYDNtFN6GHAWnz92H3LnqH8AnPNbcaN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769409244; c=relaxed/simple; bh=EgSzs1OlDMh3Q8s54ZdjDobeqnp0CHOi/M2J0zDVHrI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Nxbii+Gv4dM073+nDPQTT6WaW3r9RPpIHm80yI4+Lv9hWPN3wu/se7qG9qPyiB1r45ZmPaNAgv2OcK/+UCQCJq0xsM6YEXshNuAx5kM4Hpm8+XYRpJ53qRgZthITL8qcgEweF+SU68KtDag7vRAaO5if2qhZEzuLOZT7XT/jEmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cE1Purqo; arc=none smtp.client-ip=209.85.214.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cE1Purqo" Received: by mail-pl1-f193.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so45395365ad.2 for ; Sun, 25 Jan 2026 22:34:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769409242; x=1770014042; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gv0Zz9f3QcNoHEU92zzDKUJ9eJrwLyE/kmgjH7ImIcM=; b=cE1Purqo6//LQWryxgefMfcUC0UOwWL7p9h7QWgjFbtGOpo5kH02WYfPHhrlTvQIJ4 HiiXdnx+Vene8gZzh5qaent8BXz3RP/6Yt1X4hbgujo8/JsNCAAnzCOQod/6bTFOK8DU OydY8mpi8PdVSELHDW3c+GfBtW4tG3fzOJh7rJGUHklPIjYN2I+zUSQxOC1TUHQymPGA 5g8UuRQzq9kYT9sgTWv85NtLm2k0hBkcTw51iPpRz3UvPQVpaE/FsfAN6jdNgeSAFhTU y7S9KYfnRQODlKGYEsyEpcr6kzjPwrgJf6qv/jM5eBp4i4vAKsBsbBAMn9Q2j73/rW0G Ur4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769409242; x=1770014042; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gv0Zz9f3QcNoHEU92zzDKUJ9eJrwLyE/kmgjH7ImIcM=; b=nkmCjBJnNJbcwca/ZRcgB2wPceHtGwQ3MAsQW4Q8ih9F0D7CjiR5/rccWQYw9FqnOk vCIeumCTKqOJYALADSxSnrprdOiDki5H5WasBpTI9RSUl5iUbeI+PIOihB77XbEPsWTd bWgluhUvjAO9wD1wJa3wQ1sVYimoTN2x0mC8j4wj7L3NSQr5J5fBTKPyMBb9d12CMSg/ dWrr9rkWkArEeHjh7V4+TzIhtD1mtpfye4RuZXtn4K2hKbq+lo5hywoBqo0fzweTb1aT STzA1eiShRuyVIE/xDV3y6PkOUrrtf52I1DykqTjJY2iCGgTn/ueyZjPJjMcMnaEcj6Z 1rrg== X-Forwarded-Encrypted: i=1; AJvYcCXxPwwQIP6BoMj10dnCyp7Ra77ThMYNSxX8S6a76Ga04hrESh6o4j5isDkFleyXZDvNYeBRNnSKOVMDj3I=@vger.kernel.org X-Gm-Message-State: AOJu0Yze3NNHm3kU9bKpina7YjF2Cp5VqI2htiG8oHJsnhPRxmzjqN3X ityZQtcSRpwgqQ+eI4UJ1zZ/+OfhVFB/Zl3aw8Ev9p+NjR1TaolqbIU9 X-Gm-Gg: AZuq6aJpz+xBxJOlrGcAjqCVLm0Ubm/nWq+qZ8S+MVrP0ui6sq0rOCNLrPdpqMUuJE4 Hn0y81Qa4BdIEGhANXp/Xn1/US4vwjKmzg5/u+CJaa/RQROAX4mqGeN+MRWLQH6hjDxZilBwWPH fcYzF8m96UUSD0IhSy6Xmby2p8/z8X2j6d0P3nDc/IZQ2II0s8GR9ezvCyvQ6JL/ezbxtK3Dxpr KkO48cOh3JP+DCHbxYTbsZ2Mu/krg4ixQw0ccvXTJTZQ0o85+dGDFEI+6/iaP92oryoWimWkBgy gozZabHJtWBtvWOlwRm6nJbSOXGOL87bxqYJL3s9CHqHegKn4HlvmqYtrUCwhoG7rP4j091jz3p pAsmR0+C9EhIjAlVJQBmqmKyUcWKcBCTTQFOc8t5AlJx0TCx6MKAo5HCt4q931nBgl38En6bo5g dXPJt6HQLYjFDRtu2GW4MdIeyQM1GHvTg2S6x1EQ== X-Received: by 2002:a17:902:d511:b0:297:e59c:63cc with SMTP id d9443c01a7336-2a8452b16c5mr41391845ad.35.1769409242273; Sun, 25 Jan 2026 22:34:02 -0800 (PST) Received: from lima-ubuntu.hz.ali.com ([47.246.98.220]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802dcd8cdsm79352455ad.27.2026.01.25.22.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 22:34:01 -0800 (PST) From: Qing Wang To: ebiggers@kernel.org Cc: jaegeuk@kernel.org, linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+d130f98b2c265fae5297@syzkaller.appspotmail.com, tytso@mit.edu, wangqing7171@gmail.com Subject: Re: [PATCH] fscrypt: Fix uninit-value in ovl_fill_real Date: Mon, 26 Jan 2026 14:33:55 +0800 Message-Id: <20260126063355.504157-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260124182547.GA2762@quark> References: <20260124182547.GA2762@quark> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 25 Jan 2026 at 02:25, Eric Biggers wrote: > For KMSAN issues, it's important to root-cause them. > Zero-initialization isn't necessarily the right fix. > > In this case, it looks like ovl_fill_real() is incorrectly assuming that > the name is NUL-terminated. > > Yet, the name passed to dir_context::actor isn't normally > NUL-terminated. Even for a regular directory, ext4 just passes a > pointer to the filename in the ext4_dir_entry_2 in the buffer cache. > > The encrypted directory case doesn't seem to be fundamentally different. > Just KMSAN is able to report the issue because the memory is in a slab > buffer rather than the buffer cache. > > Can you consider fixing ovl_fill_real()? Instead of strcmp(".."), it > should check whether namelen is 2 and the first two chars are '.'. Hi Eric, Thanks for your reply. I agreed with your idea and resend a new patch. https://lore.kernel.org/all/20260126062216.496560-1-wangqing7171@gmail.com/ Looking forward to your next review. -- Best Regards, Qing