From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7ED18EAB
	for <linux-kernel@vger.kernel.org>; Tue, 27 Jan 2026 01:05:15 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1769475915; cv=none; b=q5gTvi9R+Fau8OaMFeNg2IFPhvJI2m1ieJVGjeCGeCtOlwTHkjzOrn1S07J0HnT9p08esBwt4sGHqwWIZs8yah19lk6v47cAK75xhPanXFWRBI9N6GQg2JKW7Rynbu/Eh5KjmVepmpWvNIcP2CEaSGCz1/YN3qollxoOFKpb2yo=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1769475915; c=relaxed/simple;
	bh=rO29DjrE0q+YajQotp2xI4GjU48ZmhPq+LJotmDhnhs=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version; b=jwxEK66r8Rrt84V4KLKVogsoMMEgUJ8lfUlPR2Xyf8isD8EUdP/AMIs6ySjvTKOAjHI49wa1WKBwb0TwNjH/wVHXfHmgXFfDkP7Lf0S5JZYI3s8w3VKU2f+cRykNz/xyhvTUBGKdy68HTjjVInaSL0bZuQne62H82X26XxruzbQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CRClnG9C; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CRClnG9C"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03FBAC116C6;
	Tue, 27 Jan 2026 01:05:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1769475915;
	bh=rO29DjrE0q+YajQotp2xI4GjU48ZmhPq+LJotmDhnhs=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=CRClnG9C2iGMauKAVmz+bwqCBlK0YFWPCW0O6LSl1hw7uE/YcZLy83W9jHGfoABne
	 tVt2RbgXgo7ZosUg00ExSgdp53C3QLQQ8Yn0vhvMazvAJzmXwN1M4+Wfl0h+kV/obn
	 o3Wub6w72ZKVT2jsVA22/5y9VuPFx4EFGZYALX3erSYx3ipB9XPWuU9zsG154OC00A
	 P9V69PGBT2EARBShjQog2PdqPo1lRV7sobyZiEga4MyiAU57T7CM6Clhp2eObpRdaQ
	 /HPjGZc4PlzI0fdhnh/WTz8B/SlErNnwp3WKAte8hbKYO9oet0g9Bb1m7fD0XqELrz
	 GB+RJRKd4nOTw==
From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
	Thorsten Blum <thorsten.blum@linux.dev>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/cma: Replace snprintf with strscpy in cma_new_area
Date: Mon, 26 Jan 2026 17:05:10 -0800
Message-ID: <20260127010511.74604-1-sj@kernel.org>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260126165450.f83b1895deeda8e4332a57d3@linux-foundation.org>
References: 
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Mon, 26 Jan 2026 16:54:50 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 26 Jan 2026 16:47:22 -0800 SeongJae Park <sj@kernel.org> wrote:
> 
> > > @@ -233,7 +234,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size,
> > >  	cma_area_count++;
> > >  
> > >  	if (name)
> > > -		snprintf(cma->name, CMA_MAX_NAME, "%s", name);
> > > +		strscpy(cma->name, name);
> > 
> > Any reason to drop CMA_MAX_NAME protection?  You can pass the size of
> > destination buffer as the third argument of strscpy().
> 
> strscpy() will now use sizeof(cma->name):
> 
> 	char name[CMA_MAX_NAME];

Ah, you're right.

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ