From: Ethan Tidmore <ethantidmore06@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@linaro.org, straube.linux@gmail.com,
hansg@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Ethan Tidmore <ethantidmore06@gmail.com>
Subject: [PATCH v2 2/8] staging: rtl8723bs: rename RegEnableTxPowerByRate to reg_enable_tx_power_by_rate
Date: Mon, 26 Jan 2026 19:21:12 -0600 [thread overview]
Message-ID: <20260127012118.43037-3-ethantidmore06@gmail.com> (raw)
In-Reply-To: <20260127012118.43037-1-ethantidmore06@gmail.com>
Rename RegEnableTxPowerByRate to reg_enable_tx_power_by_rate to
avoid CamelCase.
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 5 +++--
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 11 +++++------
drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index 403fb485b6b4..e7e355b41747 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -573,8 +573,9 @@ s8 PHY_GetTxPowerByRate(struct adapter *padapter, u8 RFPath, u8 Rate)
s8 value = 0;
u8 rateIndex = PHY_GetRateIndexOfTxPowerByRate(Rate);
- if ((padapter->registrypriv.RegEnableTxPowerByRate == 2 && pHalData->EEPROMRegulatory == 2) ||
- padapter->registrypriv.RegEnableTxPowerByRate == 0)
+ if ((padapter->registrypriv.reg_enable_tx_power_by_rate == 2 &&
+ pHalData->EEPROMRegulatory == 2) ||
+ padapter->registrypriv.reg_enable_tx_power_by_rate == 0)
return 0;
if (RFPath >= RF_PATH_MAX)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
index e89e34a6ad8c..95ddb34850bc 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
@@ -350,12 +350,11 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
/* If EEPROM or EFUSE autoload OK, We must config by PHY_REG_PG.txt */
PHY_InitTxPowerByRate(Adapter);
- if (
- Adapter->registrypriv.RegEnableTxPowerByRate == 1 ||
- (Adapter->registrypriv.RegEnableTxPowerByRate == 2 && pHalData->EEPROMRegulatory != 2)
- ) {
- ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv,
- CONFIG_BB_PHY_REG_PG);
+
+ if (Adapter->registrypriv.reg_enable_tx_power_by_rate == 1 ||
+ (Adapter->registrypriv.reg_enable_tx_power_by_rate == 2 &&
+ pHalData->EEPROMRegulatory != 2)) {
+ ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG_PG);
if (pHalData->odmpriv.PhyRegPgValueType == PHY_REG_PG_EXACT_VALUE)
PHY_TxPowerByRateConfiguration(Adapter);
diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
index 4e164bec6f4d..847f29c7f3be 100644
--- a/drivers/staging/rtl8723bs/include/drv_types.h
+++ b/drivers/staging/rtl8723bs/include/drv_types.h
@@ -157,7 +157,7 @@ struct registry_priv {
/* define for tx power adjust */
u8 reg_enable_tx_power_limit;
- u8 RegEnableTxPowerByRate;
+ u8 reg_enable_tx_power_by_rate;
u8 RegPowerBase;
u8 RegPwrTblSel;
s8 TxBBSwing_2G;
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 725f1da80d32..1558045f9366 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -260,7 +260,7 @@ static void loadparam(struct adapter *padapter, struct net_device *pnetdev)
registry_par->notch_filter = (u8)rtw_notch_filter;
registry_par->reg_enable_tx_power_limit = (u8)rtw_tx_pwr_lmt_enable;
- registry_par->RegEnableTxPowerByRate = (u8)rtw_tx_pwr_by_rate;
+ registry_par->reg_enable_tx_power_by_rate = (u8)rtw_tx_pwr_by_rate;
registry_par->RegPowerBase = 14;
registry_par->TxBBSwing_2G = 0xFF;
--
2.52.0
next prev parent reply other threads:[~2026-01-27 1:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 1:21 [PATCH v2 0/8] staging: rtl8723bs: rename members of struct registry_priv and remove dead code Ethan Tidmore
2026-01-27 1:21 ` [PATCH v2 1/8] staging: rtl8723bs: rename RegEnableTxPowerLimit to reg_enable_tx_power_limit Ethan Tidmore
2026-01-27 1:21 ` Ethan Tidmore [this message]
2026-01-27 1:21 ` [PATCH v2 3/8] staging: rtl8723bs: rename RegPowerBase to reg_power_base Ethan Tidmore
2026-01-27 1:21 ` [PATCH v2 4/8] staging: rtl8723bs: rename RegPwrTblSel to reg_pwr_tbl_sel Ethan Tidmore
2026-01-27 1:21 ` [PATCH v2 5/8] staging: rtl8723bs: remove unused variable TxBBSwing_2G Ethan Tidmore
2026-01-27 1:21 ` [PATCH v2 6/8] staging: rtl8723bs: remove unused variable AmplifierType_2G Ethan Tidmore
2026-01-27 1:21 ` [PATCH v2 7/8] staging: rtl8723bs: remove unused variable bEn_RFE Ethan Tidmore
2026-01-27 1:21 ` [PATCH v2 8/8] staging: rtl8723bs: remove unused variable RFE_Type Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127012118.43037-3-ethantidmore06@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox