From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sinmsgout01.his.huawei.com (sinmsgout01.his.huawei.com [119.8.177.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AD0E346FB3 for ; Tue, 27 Jan 2026 12:06:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=119.8.177.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769515575; cv=none; b=Pjs8xlqE07glGbi2KqK1IrwDArTHrrVkLSWSlGZ+lk3EnBu7aX2A/J/T/Xc8HpCwZAKTZieGX+86dGfUL5McmzpeajUnL+0lfpOX9J9Ym7DIw6uEBaqurlPmUsyMxkmVCW7s8z9V0NQrgKJoL0cCIYrfIU6v1XGIcUYHXjWvVXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769515575; c=relaxed/simple; bh=+ngAf2ODCHVSA0ebDD5xwco8wEQ9J9iR/YNNpwVGboY=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b96aWdnwMRYqwAjffI5yQoZXP2I/RCy9siLZVJy4NYrx+dxnw1spAQz6tX9AeguFxHitOP0ic9XdqRw1sE3TiMl1cV2Yz9oMxUz+78H3FVa62GB/52E0osz007BVAdwX6xJJQT0eaQ48jJdccpbSJbktf8YkyMftOBnxsk6hEmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=OxN3MsDG; arc=none smtp.client-ip=119.8.177.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="OxN3MsDG" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=s8DAQ61OS3c7iglhTfU3Mablouz2+HPpWAYSwOSGdrk=; b=OxN3MsDGOABCGn8wiFeH2PuIz5IxpUFsa3nKjfW2vpHxJCzf5sYOSie1sZzyuOZSsK4yg+akg gg2NkraQ18mUDMBW/MxBfXYZh4B1rzChKPusChTGOBlpx70pZGI07TbV4sRYQR3e+ni4pUiyKux 0ySwit5hDhz0Z2Xmfu5MAdU= Received: from frasgout.his.huawei.com (unknown [172.18.146.33]) by sinmsgout01.his.huawei.com (SkyGuard) with ESMTPS id 4f0kZf3g1Wz1P6nS; Tue, 27 Jan 2026 20:03:38 +0800 (CST) Received: from mail.maildlp.com (unknown [172.18.224.150]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4f0kcn1wR1zJ46CD; Tue, 27 Jan 2026 20:05:29 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id 252E040539; Tue, 27 Jan 2026 20:06:05 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 27 Jan 2026 12:06:04 +0000 Date: Tue, 27 Jan 2026 12:06:02 +0000 From: Jonathan Cameron To: Ryan Roberts CC: Will Deacon , Ard Biesheuvel , Catalin Marinas , Mark Rutland , Linus Torvalds , Oliver Upton , Marc Zyngier , "Dev Jain" , Linu Cherian , , Subject: Re: [PATCH v2 06/13] arm64: mm: Re-implement the __flush_tlb_range_op macro in C Message-ID: <20260127120602.00007d65@huawei.com> In-Reply-To: <20260119172202.1681510-7-ryan.roberts@arm.com> References: <20260119172202.1681510-1-ryan.roberts@arm.com> <20260119172202.1681510-7-ryan.roberts@arm.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100010.china.huawei.com (7.191.174.197) To dubpeml500005.china.huawei.com (7.214.145.207) On Mon, 19 Jan 2026 17:21:53 +0000 Ryan Roberts wrote: > The __flush_tlb_range_op() macro is horrible and has been a previous > source of bugs thanks to multiple expansions of its arguments (see > commit f7edb07ad7c6 ("Fix mmu notifiers for range-based invalidates")). > > Rewrite the thing in C. > > Suggested-by: Linus Torvalds > Co-developed-by: Will Deacon > Signed-off-by: Will Deacon > Signed-off-by: Ryan Roberts Reviewed-by: Jonathan Cameron