From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sinmsgout02.his.huawei.com (sinmsgout02.his.huawei.com [119.8.177.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B7934EF09 for ; Tue, 27 Jan 2026 12:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=119.8.177.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769516733; cv=none; b=ae6nDbafm4evZlaA2BCyYJPJwKunH06xJCNa+gie6Kc8mbsIzYLtn9W8QJE8Qke8PwgDpIPGe06gz3MEl9m9V6HAelAM64wtV2Zqet8/VFCXpMbnwMtsLa+VqPmApFWBtI/tk/7Uc/s1S/TD9yrU1iEot9GgblGFkFUaLPcMvp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769516733; c=relaxed/simple; bh=4n19RZvziHpbd6klHEgRW8hoiLLHG+z/RiWTRddCYVY=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I7kWCaMBUvBa90EEvGaTN+QDdpIshomKgPgs1HtIRJUba3LGOiLWfsYV/6RrX4quUutcfd1wP1yUqxXsoli8v087VH/30bkhXjGJ6gGe3S5dRsu3e/NvQ9zWBi+BBy1pkVvFSQpbcuhbI4LhRWYL069he2KWa5vgLgCXMi9arYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=5HC16Lz7; arc=none smtp.client-ip=119.8.177.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="5HC16Lz7" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=TtsUWmZLyDa9NSZyV4H1BdwW49lZiFWsjQOUMoBop/U=; b=5HC16Lz7nu5OdyLhukVyR7Pr7aAJ7E92f2CZ5Hru3ZD92/y0OZVa4CObfg19ssKXoMSFsV5Qj eI2F3Pl6B6DLZrj3mJbn95YdCippkEzeMnnQrc1Zcz7jpgjBHBD9+NtfM2V/DIN7iIvfPQKia4R Q3tsa6jhFZTcP9i/63zTl8M= Received: from frasgout.his.huawei.com (unknown [172.18.146.33]) by sinmsgout02.his.huawei.com (SkyGuard) with ESMTPS id 4f0l0v4L2cz1vnNb; Tue, 27 Jan 2026 20:22:55 +0800 (CST) Received: from mail.maildlp.com (unknown [172.18.224.107]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4f0l341BdFzJ46bM; Tue, 27 Jan 2026 20:24:48 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id 110DF40584; Tue, 27 Jan 2026 20:25:24 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 27 Jan 2026 12:25:23 +0000 Date: Tue, 27 Jan 2026 12:25:21 +0000 From: Jonathan Cameron To: Ryan Roberts CC: Will Deacon , Ard Biesheuvel , Catalin Marinas , Mark Rutland , Linus Torvalds , Oliver Upton , Marc Zyngier , "Dev Jain" , Linu Cherian , , Subject: Re: [PATCH v2 09/13] arm64: mm: Refactor flush_tlb_page() to use __tlbi_level_asid() Message-ID: <20260127122521.00007d48@huawei.com> In-Reply-To: <20260119172202.1681510-10-ryan.roberts@arm.com> References: <20260119172202.1681510-1-ryan.roberts@arm.com> <20260119172202.1681510-10-ryan.roberts@arm.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500010.china.huawei.com (7.191.174.240) To dubpeml500005.china.huawei.com (7.214.145.207) On Mon, 19 Jan 2026 17:21:56 +0000 Ryan Roberts wrote: > Now that we have __tlbi_level_asid(), let's refactor the > *flush_tlb_page*() variants to use it rather than open coding. > > The emitted tlbi(s) is/are intended to be exactly the same as before; no > TTL hint is provided. Although the spec for flush_tlb_page() allows for > setting the TTL hint to 3, it turns out that > flush_tlb_fix_spurious_fault_pmd() depends on > local_flush_tlb_page_nonotify() to invalidate the level 2 entry. This > will be fixed separately. > > Reviewed-by: Linu Cherian > Signed-off-by: Ryan Roberts Reviewed-by: Jonathan Cameron