Re: [PATCH net-next 00/13] net: phy_port: SFP modules representation and phy_port listing

Maxime Chevallier
2026-01-28T08:07:14Z

Hi again,

On 27/01/2026 22:07, Jakub Kicinski wrote:

> Some config-related build unhappines here (kunit hits this):
>
> ../include/linux/phy_link_topology.h:110:1: error: return type defaults to ‘int’ [-Wimplicit-int]
> 110 | phy_link_topo_get_port(struct net_device *dev, u32 port_id)
> | ^~~~~~~~~~~~~~~~~~~~~~
> ../include/linux/phy_link_topology.h:110:1: warning: no previous prototype for ‘phy_link_topo_get_port’ [-Wmissing-prototypes]
> In file included from ../include/uapi/linux/posix_types.h:5,
> from ../include/uapi/linux/types.h:14,
> from ../include/linux/types.h:6,
> from ../include/linux/kasan-checks.h:5,
> from ../include/asm-generic/rwonce.h:26,
> from ./arch/x86/include/generated/asm/rwonce.h:1,
> from ../include/linux/compiler.h:380,
> from ../include/linux/build_bug.h:5,
> from ../include/linux/bits.h:30,
> from ../include/linux/bitops.h:6,
> from ../include/linux/bitmap.h:8,
> from ../include/linux/ethtool.h:16,
> from ../include/uapi/linux/ethtool_netlink.h:12,
> from ../include/linux/ethtool_netlink.h:6,
> from ../net/ethtool/common.c:3:
> ../include/linux/phy_link_topology.h: In function ‘phy_link_topo_get_port’:
> ../include/linux/stddef.h:8:14: error: returning ‘void *’ from a function with return type ‘int’ makes integer from pointer without a cast [-Wint-conversion]
> 8 | #define NULL ((void *)0)
> | ^
> ../include/linux/phy_link_topology.h:112:16: note: in expansion of macro ‘NULL’
> 112 | return NULL;
> | ^~~~

The kernel test bot also found it, and AI found stuff to fix I'll
address that + AI review then :)

Maxime