Re: [PATCH net-next 06/13] net: sfp: Add a sfp-bus ops when connecting a module without PHY

Maxime Chevallier
2026-01-30T17:08:57Z

Hi Russell,

On 30/01/2026 17:19, Russell King (Oracle) wrote:
> On Tue, Jan 27, 2026 at 02:41:54PM +0100, Maxime Chevallier wrote:
>> The SFP bus infrastructure notifies its upstream when a PHY device was
>> discovered on the module. However, we don't have any indication when a
>> module with no PHY was inserted, except for the .insert() and .start()
>> notifications.
>
> That's the way you tell - if you get the .start() callback but you
> haven't had a PHY connected, that means there's no PHY.
>
> There should be no need to add this callback, since you shouldn't be
> thinking that the module is fully initialised until you have received
> the .start() callback.
>

Ok fair point, thanks for the feedback ! I was about to send V3, but
I'll implement something that doesn't require this new callback then.

Thanks for taking a look :)

Maxime