From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2269A35D5E9 for ; Tue, 27 Jan 2026 15:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769526367; cv=none; b=iyILnbdTbqEKPBc+s1E1AOVzwCeXdb/hPtFMspDEL5U544BuQiMtiht7UYzLACJzwPlaq0cq06RTc1FuTSbgX8pn7XARecNYO7wKldDI0/b5P52tUrDRZimfQBBEWC39uqi9M5gVXckaA4qpJNMJufXRlTJZnI3w3xClauDtgv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769526367; c=relaxed/simple; bh=6J2EqFQjEjfkzaTJ9AVzw+wpoKpJxoJkfmb4zJVrgTc=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=HtpQMowgy7OftoXL+iSHHhbkjjmhoNnJA2R3vESu6Hoc7tQds7yAhX64iBbhNa26bgRMESHPwDG7GaSKquQj/D68/W5JXB6XOaK4rTrkObCc8CWJ4DKyt5rO2bpbOHnSyH5aUh4lhgyRyv+LzCwa2PYoSqjql3PmhAzRem2sSK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FIZ/Z7HF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FIZ/Z7HF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03BE4C116D0; Tue, 27 Jan 2026 15:06:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769526367; bh=6J2EqFQjEjfkzaTJ9AVzw+wpoKpJxoJkfmb4zJVrgTc=; h=Date:From:To:Cc:Subject:References:From; b=FIZ/Z7HFb1pB7JoI8YTV8DgXbFH2trg4g2sbKfqFXWqYZRqqz1Ym0EWzfEdvMdTJN D1ZiCcriMWrmDRSRyjA6PwlIjHtkIjELTwhRzvrMg0QnmczqHr6yupO42ofBwU/Vsr zalpAmyOvC+sYjrglHQ+EZEmYDUElc3kdF8k+h3/QiNEOgc5VUYzao5yHWz1Sg64Ft XMw2eTx8epAJ8565cWdzsFiyYTxph1QED6sUcvBvVNeDkuh19Klmz4gR9zHq+sWriZ 1tJP5vdU0obtiVeeLWFN1kxJchupxr57PHWToZ2zdwNbwrp9wF64ncSG7Rvv2PPgMr YBl7JpEpwwfmg== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1vkkdw-00000000LeV-3vRS; Tue, 27 Jan 2026 10:06:12 -0500 Message-ID: <20260127150612.790179493@kernel.org> User-Agent: quilt/0.68 Date: Tue, 27 Jan 2026 10:06:04 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Aaron Tomlin Subject: [for-next][PATCH 09/15] tracing: Have show_event_trigger/filter format a bit more in columns References: <20260127150555.840066272@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Steven Rostedt By doing: # trace-cmd sqlhist -e -n futex_wait select TIMESTAMP_DELTA_USECS as lat from sys_enter_futex as start join sys_exit_futex as end on start.common_pid = end.common_pid and # trace-cmd start -e futex_wait -f 'lat > 100' -e page_pool_state_release -f 'pfn == 1' The output of the show_event_trigger and show_event_filter files are well aligned because of the inconsistent 'tab' spacing: ~# cat /sys/kernel/tracing/show_event_triggers syscalls:sys_exit_futex hist:keys=common_pid:vals=hitcount:__lat_12046_2=common_timestamp.usecs-$__arg_12046_1:sort=hitcount:size=2048:clock=global:onmatch(syscalls.sys_enter_futex).trace(futex_wait,$__lat_12046_2) [active] syscalls:sys_enter_futex hist:keys=common_pid:vals=hitcount:__arg_12046_1=common_timestamp.usecs:sort=hitcount:size=2048:clock=global [active] ~# cat /sys/kernel/tracing/show_event_filters synthetic:futex_wait (lat > 100) page_pool:page_pool_state_release (pfn == 1) This makes it not so easy to read. Instead, force the spacing to be at least 32 bytes from the beginning (one space if the system:event is longer than 30 bytes): ~# cat /sys/kernel/tracing/show_event_triggers syscalls:sys_exit_futex hist:keys=common_pid:vals=hitcount:__lat_8125_2=common_timestamp.usecs-$__arg_8125_1:sort=hitcount:size=2048:clock=global:onmatch(syscalls.sys_enter_futex).trace(futex_wait,$__lat_8125_2) [active] syscalls:sys_enter_futex hist:keys=common_pid:vals=hitcount:__arg_8125_1=common_timestamp.usecs:sort=hitcount:size=2048:clock=global [active] ~# cat /sys/kernel/tracing/show_event_filters synthetic:futex_wait (lat > 100) page_pool:page_pool_state_release (pfn == 1) Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20260112153408.18373e73@gandalf.local.home Reviewed-by: Aaron Tomlin Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 36936697fa2a..f372a6374164 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1662,6 +1662,18 @@ static void t_stop(struct seq_file *m, void *p) mutex_unlock(&event_mutex); } +static int get_call_len(struct trace_event_call *call) +{ + int len; + + /* Get the length of ":" */ + len = strlen(call->class->system) + 1; + len += strlen(trace_event_name(call)); + + /* Set the index to 32 bytes to separate event from data */ + return len >= 32 ? 1 : 32 - len; +} + /** * t_show_filters - seq_file callback to display active event filters * @m: The seq_file interface for formatted output @@ -1676,14 +1688,17 @@ static int t_show_filters(struct seq_file *m, void *v) struct trace_event_file *file = v; struct trace_event_call *call = file->event_call; struct event_filter *filter; + int len; guard(rcu)(); filter = rcu_dereference(file->filter); if (!filter || !filter->filter_string) return 0; - seq_printf(m, "%s:%s\t%s\n", call->class->system, - trace_event_name(call), filter->filter_string); + len = get_call_len(call); + + seq_printf(m, "%s:%s%*.s%s\n", call->class->system, + trace_event_name(call), len, "", filter->filter_string); return 0; } @@ -1702,6 +1717,7 @@ static int t_show_triggers(struct seq_file *m, void *v) struct trace_event_file *file = v; struct trace_event_call *call = file->event_call; struct event_trigger_data *data; + int len; /* * The event_mutex is held by t_start(), protecting the @@ -1710,9 +1726,11 @@ static int t_show_triggers(struct seq_file *m, void *v) if (list_empty(&file->triggers)) return 0; + len = get_call_len(call); + list_for_each_entry_rcu(data, &file->triggers, list) { - seq_printf(m, "%s:%s\t", call->class->system, - trace_event_name(call)); + seq_printf(m, "%s:%s%*.s", call->class->system, + trace_event_name(call), len, ""); data->cmd_ops->print(m, data); } -- 2.51.0