Re: [PATCH 2/2] misc: ti_fpc202: Support special-purpose GPIO lines with LED features

Arnd Bergmann
2026-01-27T14:04:21Z

On Tue, Jan 27, 2026, at 14:51, Romain Gantois wrote:
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -118,6 +118,7 @@ config TI_FPC202
> depends on I2C
> select GPIOLIB
> select I2C_ATR
> + select LEDS_CLASS
> help
> If you say yes here you get support for the Texas Instruments FPC202
> Dual Port Controller.

Selecting a foreign subsystem is usually a bad idea, as it
leads to dependency loops.

For LEDS_CLASS, I think this needs to be 'depends on LEDS_CLASS',
or possibly 'depends on LEDS_CLASS || !LEDS_CLASS' if you want
to keep that optional.

I would also change the GPIOLIB dependency the same way, but that
should be a separate patch of course.

Arnd