回复: [PATCH v4 1/3] dt-bindings: reset: add sky1 reset controller

Gary Yang
2026-01-29T01:39:30Z

Hi Rob:

Thanks for your comments

> -----邮件原件-----
> 发件人: Rob Herring (Arm) <robh@kernel.org>
> 发送时间: 2026年1月28日 19:23
> 收件人: Gary Yang <gary.yang@cixtech.com>
> 抄送: cix-kernel-upstream <cix-kernel-upstream@cixtech.com>;
> devicetree@vger.kernel.org; krzk+dt@kernel.org; p.zabel@pengutronix.de;
> Peter Chen <peter.chen@cixtech.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; lee@kernel.org; conor+dt@kernel.org
> 主题: Re: [PATCH v4 1/3] dt-bindings: reset: add sky1 reset controller
>
> EXTERNAL EMAIL
>
> On Wed, 28 Jan 2026 17:36:09 +0800, Gary Yang wrote:
> > There are two reset controllers on Cix sky1 Soc.
> > One is located in S0 domain, and the other is located in S0 and S5
> > domain.
> >
> > Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> > Link:
> > https://lore.kernel.org/r/20251124063235.952136-2-gary.yang@cixtech.co
> > m
> > Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> > ---
> > .../devicetree/bindings/mfd/syscon.yaml | 7 +
> > .../bindings/reset/cix,sky1-rst.yaml | 46 +++++
> > .../soc/cix/cix,sky1-system-controller.yaml | 48 +++++
> > include/dt-bindings/reset/cix,sky1-rst-fch.h | 42 +++++
> > include/dt-bindings/reset/cix,sky1-rst.h | 164
> ++++++++++++++++++
> > 5 files changed, 307 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> > create mode 100644
> > Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.y
> > aml create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h
> > create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc
> /cix/cix,sky1-system-controller.yaml: ignoring, error in schema: properties:
> compatible: oneOf: 0: contains
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc
> /cix/cix,sky1-system-controller.yaml: properties:compatible:oneOf:0:contains:
> [{'enum': ['cix,sky1-system-controller', 'cix,sky1-s5-system-controller']}, {'const':
> 'syscon'}, {'const': 'simple-mfd'}] is not of type 'object', 'boolean'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc
> /cix/cix,sky1-system-controller.yaml: properties:compatible:oneOf:0:contains:
> [{'enum': ['cix,sky1-system-controller', 'cix,sky1-s5-system-controller']}, {'const':
> 'syscon'}, {'const': 'simple-mfd'}] is not of type 'object', 'boolean'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc
> /cix/cix,sky1-system-controller.yaml: properties:compatible:oneOf:0:contains:
> [{'enum': ['cix,sky1-system-controller', 'cix,sky1-s5-system-controller']}, {'const':
> 'syscon'}, {'const': 'simple-mfd'}] is not of type 'object', 'boolean'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc
> /cix/cix,sky1-system-controller.yaml: properties:compatible:oneOf:0:contains:
> [{'enum': ['cix,sky1-system-controller', 'cix,sky1-s5-system-controller']}, {'const':
> 'syscon'}, {'const': 'simple-mfd'}] is not of type 'object', 'boolean'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc
> /cix/cix,sky1-system-controller.yaml: properties:compatible:oneOf:0:contains:
> [{'enum': ['cix,sky1-system-controller', 'cix,sky1-s5-system-controller']}, {'const':
> 'syscon'}, {'const': 'simple-mfd'}] is not of type 'object', 'boolean'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc
> /cix/cix,sky1-system-controller.yaml: properties:compatible:oneOf:0:contains:
> [{'enum': ['cix,sky1-system-controller', 'cix,sky1-s5-system-controller']}, {'const':
> 'syscon'}, {'const': 'simple-mfd'}] is not of type 'object', 'boolean'
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc
> /cix/cix,sky1-system-controller.yaml: properties:compatible:oneOf:0:contains:
> [{'enum': ['cix,sky1-system-controller', 'cix,sky1-s5-system-controller']}, {'const':
> 'syscon'}, {'const': 'simple-mfd'}] is not of type 'object', 'boolean'
> Traceback (most recent call last):
> File "/usr/local/bin/dt-doc-validate", line 8, in <module>
> sys.exit(main())
> ~~~~^^
> File "/usr/local/lib/python3.13/dist-packages/dtschema/doc_validate.py",
> line 66, in main
> ret |= check_doc(f)
> ~~~~~~~~~^^^
> File "/usr/local/lib/python3.13/dist-packages/dtschema/doc_validate.py",
> line 37, in check_doc
> dtsch.check_schema_refs()
> ~~~~~~~~~~~~~~~~~~~~~~~^^
> File "/usr/local/lib/python3.13/dist-packages/dtschema/schema.py", line
> 241, in check_schema_refs
> self._check_schema_refs(resolver, self)
> ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
> File "/usr/local/lib/python3.13/dist-packages/dtschema/schema.py", line
> 212, in _check_schema_refs
> self._check_schema_refs(resolver, v, parent=k, is_common=is_common,
>
> ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> has_constraint=has_constraint)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/local/lib/python3.13/dist-packages/dtschema/schema.py", line
> 216, in _check_schema_refs
> self._check_schema_refs(resolver, schema[i], parent=parent,
> is_common=is_common,
>
> ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> ^^^^^^^^^^^^^
> has_constraint=has_constraint)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/local/lib/python3.13/dist-packages/dtschema/schema.py", line
> 203, in _check_schema_refs
> ref_sch = resolver.lookup(schema['$ref']).contents
> ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
> File "/usr/local/lib/python3.13/dist-packages/referencing/_core.py", line
> 682, in lookup
> retrieved = self._registry.get_or_retrieve(uri)
> File "/usr/local/lib/python3.13/dist-packages/referencing/_core.py", line
> 422, in get_or_retrieve
> registry = self.crawl()
> File "/usr/local/lib/python3.13/dist-packages/referencing/_core.py", line
> 500, in crawl
> id = resource.id()
> File "/usr/local/lib/python3.13/dist-packages/referencing/_core.py", line
> 231, in id
> id = self._specification.id_of(self.contents)
> File "/usr/local/lib/python3.13/dist-packages/referencing/jsonschema.py",
> line 50, in _dollar_id
> return contents.get("$id")
> ^^^^^^^^^^^^
> AttributeError: 'list' object has no attribute 'get'
>
> doc reference errors (make refcheckdocs):
>
> See
> https://patchwork.kernel.org/project/devicetree/patch/20260128093611.193
> 2770-2-gary.yang@cixtech.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

OK, we run " make dt_binding_check " command before submit patch. But not found these errors.
We will double check it. if found, we will fix them.

Best Regards
Gary