From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83E4D238D54 for ; Wed, 28 Jan 2026 12:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769601813; cv=none; b=WXHlQKiNbucCmD4XDfAV3iLwOVNpvVNuxwJiCTyos0dnMClSwistMmeQCIAR0S7GD42JusZnhcnuIYRXvqCQvW9juTj3uYxUnNn+Ldh4aHRUaxYb3fZMfkQUAINPsmabHU/9IlKN/AdEmmGpmWeXFt4wl3X617eI1ErIys5RQrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769601813; c=relaxed/simple; bh=/GfavJ8zWUnbFDEBfOg9iYDhcUsNy+bGd1TdqvP1x/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ciRH8d0aMDF1ffkPJjaLVB+9mMeQyL6vo6WNS07HOlNTtHyd2yhPHPUQs9BF+czAxEL/vlgU2E0jY6ByLnZUoRJGlqUdInNjpFCiMCC7aDCB77UjmFzfF+0sa2rOcpk6IBpMcVgenJ/U0iUbZmEXKHPgk5pXzaThY7UuEefDz1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=lAvNefmN; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lAvNefmN" Received: from pendragon.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2F68C581; Wed, 28 Jan 2026 13:02:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1769601774; bh=/GfavJ8zWUnbFDEBfOg9iYDhcUsNy+bGd1TdqvP1x/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lAvNefmNlB46gPMR/YZL9wyF73LFutIaPvHfsr4g+hXaUuRY01vHaI/+4LKNZ0gO+ 5oXnDLbd4JRkidnuyThhPsbZ9HNxQKTd4juOkBJIwwSj8XkBTsnWnxyC5Dwq8nFM7M agdbjdgQ77uaxhtsJyS3wuhuPX6qXZiYRGa+dqXw= Date: Wed, 28 Jan 2026 14:03:29 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Vishal Sagar , Anatoliy Klymenko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michal Simek , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dmitry Baryshkov , Pekka Paalanen Subject: Re: [PATCH v7 05/11] drm/fourcc: Add DRM_FORMAT_X403 Message-ID: <20260128120329.GH2558360@killaraus> References: <20251201-xilinx-formats-v7-0-1e1558adfefc@ideasonboard.com> <20251201-xilinx-formats-v7-5-1e1558adfefc@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251201-xilinx-formats-v7-5-1e1558adfefc@ideasonboard.com> Hi Tomi, Thank you for the patch. On Mon, Dec 01, 2025 at 02:18:47PM +0200, Tomi Valkeinen wrote: > Add X403, a 3 plane 10 bits per component non-subsampled YCbCr format. This makes me wish for a X509 format, for maximum confusion :-) > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Vishal Sagar > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_fourcc.c | 3 +++ > include/uapi/drm/drm_fourcc.h | 9 +++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 0d222f6c1a30..ab643dedd6d4 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -391,6 +391,9 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_Y10_P32, .depth = 0, .num_planes = 1, > .char_per_block = { 4, 0, 0 }, .block_w = { 3, 0, 0 }, .block_h = { 1, 0, 0 }, > .hsub = 1, .vsub = 1, .is_yuv = true }, > + { .format = DRM_FORMAT_X403, .depth = 0, .num_planes = 3, > + .char_per_block = { 4, 4, 4 }, .block_w = { 3, 3, 3 }, .block_h = { 1, 1, 1 }, > + .hsub = 1, .vsub = 1, .is_yuv = true }, > }; > > unsigned int i; > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 0fd99ae32a06..abe6af8b5ac4 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -403,6 +403,15 @@ extern "C" { > */ > #define DRM_FORMAT_Q401 fourcc_code('Q', '4', '0', '1') > > +/* > + * 3 plane non-subsampled (444) YCbCr > + * 10 bpc, 30 bits per sample image data in a single contiguous buffer. > + * index 0: Y plane, [31:0] x:Y2:Y1:Y0 [2:10:10:10] little endian > + * index 1: Cb plane, [31:0] x:Cb2:Cb1:Cb0 [2:10:10:10] little endian > + * index 2: Cr plane, [31:0] x:Cr2:Cr1:Cr0 [2:10:10:10] little endian > + */ > +#define DRM_FORMAT_X403 fourcc_code('X', '4', '0', '3') > + > /* > * 3 plane YCbCr LSB aligned > * In order to use these formats in a similar fashion to MSB aligned ones > -- Regards, Laurent Pinchart