From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3036017BCA for ; Wed, 28 Jan 2026 12:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769602251; cv=none; b=AZ3J1FeybFc/LzOMBF5eltEhEn9pPdX0FQEJRw3+8KA3Ua1P6A9tfu9yXujDGHo5WO1clnPCczPxQ011eOE+47780ssPFqx+TAgUdI4aIy+clXUpQrCYr9NCSUYt5L/vlqaHH6K70SL7PPc27buoLouHUgphoC+jGeHmL9it/lI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769602251; c=relaxed/simple; bh=3CU8o5SIomZEvlBUia0x7fjnYkUS20BvcUu2a3r5XVA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b+MIkTWQJHMmJ9xBTRItYyZCvFZvVz35rAXOkpVUB46Dz9LmYfrtoaWjQ3qhGGpQOmc+ppoL8i6k2w5agvkeoA1Pzp4Cb05jojHOU1+QDvhBPxEzSKxZEP/S4azwCmUwFhKYSdsk5e2bzZPnWhBOruHM17DeEO7k3gbziLFDd2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Gq4edDsB; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Gq4edDsB" Received: from pendragon.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id AB57B581; Wed, 28 Jan 2026 13:10:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1769602210; bh=3CU8o5SIomZEvlBUia0x7fjnYkUS20BvcUu2a3r5XVA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gq4edDsBwqCShK2m+Gwl/7VrCb4Uzw1pYzmXkPqpzbbIGGL6urx3E6utCYgxyGh4d SaxVyueiY9D+N7rCTGrL0JV3Wo+oez86MTR18lLRb8e9zQYASkZ1lx+C+YqR3F5mAP V6SH0zIlzo3acHhF6ruMNU7Ivrsjsx9QuMAVmeWo= Date: Wed, 28 Jan 2026 14:10:46 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Vishal Sagar , Anatoliy Klymenko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michal Simek , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , Dmitry Baryshkov , Pekka Paalanen Subject: Re: [PATCH v7 09/11] drm: xlnx: zynqmp: Add support for Y8 and Y10_P32 Message-ID: <20260128121046.GI2558360@killaraus> References: <20251201-xilinx-formats-v7-0-1e1558adfefc@ideasonboard.com> <20251201-xilinx-formats-v7-9-1e1558adfefc@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251201-xilinx-formats-v7-9-1e1558adfefc@ideasonboard.com> Hi Tomi, Thank you for the patch. On Mon, Dec 01, 2025 at 02:18:51PM +0200, Tomi Valkeinen wrote: > Add support for Y8 and Y10_P32 formats. We also need to add new csc > matrices for the y-only formats. > > Reviewed-by: Vishal Sagar > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/xlnx/zynqmp_disp.c | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > index 1dc77f2e4262..fe111fa8cc13 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > @@ -307,6 +307,16 @@ static const struct zynqmp_disp_format avbuf_vid_fmts[] = { > .buf_fmt = ZYNQMP_DISP_AV_BUF_FMT_NL_VID_YV16CI_10, > .swap = false, > .sf = scaling_factors_101010, > + }, { > + .drm_fmt = DRM_FORMAT_Y8, > + .buf_fmt = ZYNQMP_DISP_AV_BUF_FMT_NL_VID_MONO, > + .swap = false, > + .sf = scaling_factors_888, > + }, { > + .drm_fmt = DRM_FORMAT_Y10_P32, > + .buf_fmt = ZYNQMP_DISP_AV_BUF_FMT_NL_VID_YONLY_10, > + .swap = false, > + .sf = scaling_factors_101010, > }, > }; > > @@ -697,6 +707,16 @@ static const u32 csc_sdtv_to_rgb_offsets[] = { > 0x0, 0x1800, 0x1800 > }; > A comment here to explain why the 1.0 value is in the third column instead of the expected first column would be good. > +static const u16 csc_sdtv_to_rgb_yonly_matrix[] = { > + 0x0, 0x0, 0x1000, > + 0x0, 0x0, 0x1000, > + 0x0, 0x0, 0x1000, > +}; > + > +static const u32 csc_sdtv_to_rgb_yonly_offsets[] = { > + 0x0, 0x0, 0x0 > +}; > + > /** > * zynqmp_disp_blend_set_output_format - Set the output format of the blender > * @disp: Display controller > @@ -846,7 +866,11 @@ static void zynqmp_disp_blend_layer_enable(struct zynqmp_disp *disp, > ZYNQMP_DISP_V_BLEND_LAYER_CONTROL(layer->id), > val); > > - if (layer->drm_fmt->is_yuv) { > + if (layer->drm_fmt->format == DRM_FORMAT_Y8 || > + layer->drm_fmt->format == DRM_FORMAT_Y10_P32) { We could replace is_yuv with a type enum to avoid checking the format here, and use a switch statement. Up to you. With those issues addressed, Reviewed-by: Laurent Pinchart > + coeffs = csc_sdtv_to_rgb_yonly_matrix; > + offsets = csc_sdtv_to_rgb_yonly_offsets; > + } else if (layer->drm_fmt->is_yuv) { > coeffs = csc_sdtv_to_rgb_matrix; > offsets = csc_sdtv_to_rgb_offsets; > } else { -- Regards, Laurent Pinchart