Re: [PATCH v2 2/2] drm/i915/display: Disable display for iMac's

Lukas Wunner
2026-01-28T15:49:06Z

On Wed, Jan 28, 2026 at 02:58:38PM +0000, Atharva Tiwari wrote:
> Disable display on iMacs, as they can't do link training
> on the internal display.
>
> (tested on iMac20,1)

So with your patch the screen is black on those iMacs?
I don't quite understand why that would be desirable.

What happens without this patch? Something worse than a black screen?
This needs to be explained in the commit message so that reviewers
understand why the patch is needed.

I also don't understand why this patch follows the EFI set_os one.
What's the connection between those two patches? If there is none,
they shouldn't be submitted as a series but as two individual patches.

Thanks,

Lukas