From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3746326ED2A for ; Thu, 29 Jan 2026 04:38:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769661490; cv=none; b=CMaaNf8wqhRaqEJWtfWGyBPHKRoD927OogzvEcM7DoAWzojnwd+xAAnFTG3jZXcLkqXW8C1A8RlDn1GidCXGD59JqhM1rfs/hmcaAig/I5tarqtWLksBn8v8tO/GK/qdrP+n3P6X72wyfgLtgM4T+XUQF7v0pTIxNVy5RV9B754= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769661490; c=relaxed/simple; bh=yf+FiMdc1rY88Q0DWo4VQAVVZ2cQ1LjAULfhSCdGuRA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a8Wippw8Mz6wOeknCInBC9UIg7R1gJUcbp6KvSeE6jTutfuWAOYyQj3UP847LdR7FQ/BGXSkPg8+yI0o4ekKQD6VzimFrqwwx8IrYMCmFkt2YQ16ZjfK9TqeSAwjXoc9PkFT41CGaaCEMup/Y1yfmZtrNPFhcCpjfQR5vFgX5gQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L4/5Pu0f; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L4/5Pu0f" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-81ed3e6b8e3so259929b3a.2 for ; Wed, 28 Jan 2026 20:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769661488; x=1770266288; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NtQGOuC29uzt/6xaJHUti83+eOwCdLjkcvzsqNsGu6w=; b=L4/5Pu0fBa1blODFippLsExzXqWaExD+mzE9xXnpwrc1OeeZ7wAuZS/Ha6j/JssOga nGpiZBQZKX1/NAvSnwr3eLkz4XK23gEqbRdA4ehJjVoqcoDAmt6TPPZyMGkyPwMx/02b 3LoQMjzQupY5JoSGh/m5msNJHkVhMmRh7Qi4a7sYjx2tThNL067NDdAvF9AMaAz+Y8XB kd+WDHZHbXO39PnRSpHiFCMYuFSimmqDuGo2C5Z4j+/QBzWLVvIV2TEc8JoElVOdFW+w uhvNMXkpCNnomL+t60Wgzb0hhXKoeTb1OxFXzIvbJk6GZOU490PiafkPyiJzGH5hKkcE IAFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769661488; x=1770266288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NtQGOuC29uzt/6xaJHUti83+eOwCdLjkcvzsqNsGu6w=; b=LVyo0vMgjHMKtrrMGvuTAgpFquR+V7qaEka6Ix+o7aBWeQlweZEJ1V5uFSTWA9M5hr 3j7ZbDzjeUkkWvvMncRy+p7nzJlhP9QK1/hPYLi/cM+Cg2dxJhcflllTWGG2RkY9rDre zhmMAaq4ToeYK15fP8AeHrIsJHIDLS2xsVCV/POkuktrbU+UJ3wsKDxRlfSrkKBKLRc5 B9Lh3g9bPNzGBtCdSUeJVR6oCW/PWqaHiyOkWmATtLgq6S4/glpgt4hv0HUeqXXSPNx8 BO7ui/BRVrLdEdXhP59GQeTUnshzTeD/iAv33e0Brzw4MC0z3N9UaATivDxM1rU2P4kn eJ3Q== X-Forwarded-Encrypted: i=1; AJvYcCW7sxhxNrIfegb+oyZ4+UUvaB3UTqyj5H+u1wiPuVFYQgvKxsboVSEQ5KUzdp8foLpQ3JIDDEaa+1VZiMM=@vger.kernel.org X-Gm-Message-State: AOJu0YwEqs+G3s9xyXV0zconACjtKdT4NYwB+YwJkbXzsJlli5Fon8wd YNCJAbgwfTqvFL8idykKNFXS6m5Giz4NQcVMGv1RvFGHT3FXG9dO9/Q= X-Gm-Gg: AZuq6aJEMctoeOfK2qYHR14yCGE06SirvEht0C1ndXOgRtYAdB8n8ZZWPgSh0unLcbg pAn8fW7flM+8pTUb1Ku8hRPhtZ2Y0RfkVzomXu7Dp+zfWXB/CUHTnx/XMLUdygI/CnzO58hfg+d UFF888xKSRkhM+CNjaofRKEYuSyScz0zitvJ2aU03HPgfLCs5/ka0MRYJrYtXkGP4ymm7Ysk05A CmH5CxTpYR/kIju9DPnVUdNlzyFaDSreR0Wn8wW6hC7feXa0F3/fyt62dlpSOy/B0E53Y3EU7gx Dq+gA+h50uawbY3t5cQuL124MyuSUWIC/F0zTTtG+rmwzboetehLZ85aMY7kJU6cKcBYVdeSBrc 51s6iteJVrsAMSmE2H4ZR4YK2YSJ2IbJogpm5aL7KF7Rwbx+YF2pfydqXI9Rx+nfh8COZICU9Ck gFrRyPjhtjxSNv X-Received: by 2002:a05:6a20:2d26:b0:38b:e430:156f with SMTP id adf61e73a8af0-38ec62c6411mr6930473637.20.1769661488418; Wed, 28 Jan 2026 20:38:08 -0800 (PST) Received: from at.. ([171.61.161.8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6427e9ce21sm3595710a12.10.2026.01.28.20.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 20:38:08 -0800 (PST) From: Atharva Tiwari To: lukas@wunner.de Cc: airlied@gmail.com, ardb@kernel.org, atharvatiwarilinuxdev@gmail.com, bp@alien8.de, dri-devel@lists.freedesktop.org, francescopompo2@gmail.com, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, jani.nikula@linux.intel.com, javierm@redhat.com, joonas.lahtinen@linux.intel.com, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, lszubowi@redhat.com, rodrigo.vivi@intel.com, simona@ffwll.ch, tursulin@ursulin.net, tzimmermann@suse.de Subject: Re: [PATCH v2 1/2] efi/libstub: enable apple-set-os for all apple devices Date: Thu, 29 Jan 2026 04:37:59 +0000 Message-ID: <20260129043759.1220-1-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > As discussed previously, your patch will regress older MacBook Airs > which use SPI to access keyboard + trackpad if the set_os protocol > is invoked: > > https://lore.kernel.org/all/ZoJPgSlZJ3ZlU2zL@wunner.de/ > > The last time this topic came up, I suggested counting the number of > GPUs instead of using the DMI quirk. I even provided a patch but > nobody with an eGPU bothered to test it, so the thread fizzled out: > > https://lore.kernel.org/all/Z6paeFrjdv7L3mtv@wunner.de/ > > Maybe you could give it a spin and verify if it fixes the issue for you? I tested your patch, and well it works (you still need the 2nd patch to avoid a blank screen), but i can see how this will fail like for example, with the iMacPro (only has dGPU) you would need 2 eGPUs to turn on apple-set-os. My opinion is, we disable apple-set-os using a dmi check on the 2013/2014 MacbookAir models.