From: Rob Herring <robh@kernel.org>
To: Gary Yang <gary.yang@cixtech.com>
Cc: lee@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
p.zabel@pengutronix.de, peter.chen@cixtech.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH v5 1/3] dt-bindings: reset: add sky1 reset controller
Date: Thu, 29 Jan 2026 10:23:04 -0600 [thread overview]
Message-ID: <20260129162304.GA1209761-robh@kernel.org> (raw)
In-Reply-To: <20260129070046.2601503-2-gary.yang@cixtech.com>
On Thu, Jan 29, 2026 at 03:00:44PM +0800, Gary Yang wrote:
> There are two reset controllers on Cix sky1 Soc. One is located in S0
> domain, and the other is located in S0 and S5 domain.
The comments on v4 still apply... Repeated below...
>
> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> ---
> .../bindings/reset/cix,sky1-rst.yaml | 41 +++++
> .../soc/cix/cix,sky1-system-controller.yaml | 48 +++++
> include/dt-bindings/reset/cix,sky1-rst-fch.h | 42 +++++
> include/dt-bindings/reset/cix,sky1-rst.h | 164 ++++++++++++++++++
> 4 files changed, 295 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.yaml
> create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h
> create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h
>
> diff --git a/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> new file mode 100644
> index 000000000000..b52791e2b18e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/cix,sky1-rst.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CIX Sky1 Reset Controller
> +
> +maintainers:
> + - Gary Yang <gary.yang@cixtech.com>
> +
> +description: |
> + CIX Sky1 reset controller can be used to reset various set of peripherals.
> + There are two reset controllers, one is located in S0 domain, the other
> + is located in S0 and S5 domain.
> +
> + See also:
> + - include/dt-bindings/reset/cix,sky1-rst.h
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - cix,sky1-rst
> + - cix,sky1-rst-fch
> +
> + '#reset-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - '#reset-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + reset-controller {
> + compatible = "cix,sky1-rst";
> + #reset-cells = <1>;
> + };
> diff --git a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.yaml b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.yaml
> new file mode 100644
> index 000000000000..913e77fc522a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/cix/cix,sky1-system-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cix Sky1 SoC system controller register region
> +
> +maintainers:
> + - Gary Yang <gary.yang@cixtech.com>
> +
> +description:
> + An wide assortment of registers of the system controller on Sky1 SoC,
> + including resets and usb.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - cix,sky1-system-controller
> + - cix,sky1-s5-system-controller
> + - const: syscon
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + "^reset(-controller)?$":
> + type: object
> + $ref: /schemas/reset/cix,sky1-rst.yaml#
This is not a separate device.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + syscon@16000000 {
> + compatible = "cix,sky1-s5-system-controller", "syscon", "simple-mfd";
> + reg = <0x16000000 0x1000>;
> + reset-controller {
> + compatible = "cix,sky1-rst";
> + #reset-cells = <1>;
Move #reset-cells to the parent node and drop this node. And then drop
"simple-mfd". Or perhaps the definition for what's in the
"cix,sky1-s5-system-controller" is incomplete? If so, please define all
the binding.
Rob
next prev parent reply other threads:[~2026-01-29 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 7:00 [PATCH v5 0/3] Add support for Cix Sky1 resets Gary Yang
2026-01-29 7:00 ` [PATCH v5 1/3] dt-bindings: reset: add sky1 reset controller Gary Yang
2026-01-29 16:23 ` Rob Herring [this message]
2026-01-30 12:02 ` 回复: " Gary Yang
2026-01-29 7:00 ` [PATCH v5 2/3] reset: cix: add support for cix sky1 resets Gary Yang
2026-01-29 7:00 ` [PATCH v5 3/3] arm64: dts: " Gary Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129162304.GA1209761-robh@kernel.org \
--to=robh@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gary.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peter.chen@cixtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox