From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D38A01E1024; Fri, 30 Jan 2026 02:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769740999; cv=none; b=NSs2RjFAn2GRYlvivUSTqV55mnW6RZrZTf6jJ7KCZsCEBVrS5jr2npc+Uow52g/1uEXh00PYtioz4qsDyDZaeoCTeYXLKeOYwC/lVpmXcEAPLd1VKPUlJzIYz4KtRFSXevGQrcE8glghqQx5uU5E85iGrzuc7eG1AvmaFYAQ9+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769740999; c=relaxed/simple; bh=ERbeiUIYUnhqnTkv+lkant+gYUBDq4x7E8WNc0zXjps=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ATynHm/bAtvcQLcLKuNCIXfauCFvOjnzxl9XLIkdh0Jsn+IfqEr97NeCae/xjQBAWPGW1JsP0c6+A2P7qlJVDPjI7ohAXgjidJpGMmTjt3l63IMOjZE/tE5mYWOHzKuDj/qDoy1nKxhuAo5TRx8ogyhAgBJfyrXSlEXpuBjKEbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EBOowMJb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EBOowMJb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2194C4CEF7; Fri, 30 Jan 2026 02:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769740999; bh=ERbeiUIYUnhqnTkv+lkant+gYUBDq4x7E8WNc0zXjps=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EBOowMJbJENHprsyT0HESWLxhOifou73xl2JEcACaO/dcqAHmp0rrMdRzH4I5QtRc TGvA/NEOImttes36vwW9c42qPBf1OdYGqx+eGkvhjpyaq57N8ZvkevqE6PQmn1tEKh 9IH+EYt5sx0OlYKEktjeRL6MyRTZMMODE9hOWTcZ81ccYMYloPjYxT9jtpKdx/aVX4 7KdaYa334L8C6Xdm4qjLGfnMKf7k96NTpAKpniI1PcO7hsglFUtzVr3jAchujXVjHL NTOnZU92rUWnE+Nwye7laSgazHs9wFsafLqauLpV4YDUThCiTDab/grWAl16Mdc9AY leNT2ip3icChA== Date: Thu, 29 Jan 2026 18:43:18 -0800 From: Jakub Kicinski To: Antony Antony Cc: Steffen Klassert , , "David S . Miller" , David Ahern , Eric Dumazet , Paolo Abeni , Herbert Xu , Shuah Khan , , , Tobias Brunner , Simon Horman , Subject: Re: [PATCH net-next v4 2/2] selftests: net: add ICMP error source address test over xfrm tunnel Message-ID: <20260129184318.53b1dabf@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 28 Jan 2026 11:20:45 +0100 Antony Antony wrote: > Test that ICMP error messages generated by an IPsec gateway use > the correct source address (the gateway's address, not the > unreachable destination). could you check / fix shellcheck warnings? +In xfrm_state.sh line 115: + $ksft_skip) + ^--------^ SC2254 (warning): Quote expansions in case patterns to match literally rather than as a glob. +In xfrm_state.sh line 157: + [ -n "${NS_R1}" ] && ns_r1="ip netns exec ${NS_R1}" && ns_active="${ns_active} $NS_R1" + ^---^ SC2034 (warning): ns_r1 appears unused. Verify use (or export if used externally). + + +In xfrm_state.sh line 162: + [ -n "${NS_B}" ] && ns_b="ip netns exec ${NS_B}" && ns_active="${ns_active} $NS_B" + ^--^ SC2034 (warning): ns_b appears unused. Verify use (or export if used externally). +In xfrm_state.sh line 166: + local ns_cmd=$(nscmd $1) + ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. -- pw-bot: cr