* Re: [PATCH v2] drm/msm/dpu: Fix smatch warnings about variable dereferenced before check
2026-01-30 5:36 [PATCH v2] drm/msm/dpu: Fix smatch warnings about variable dereferenced before check sunliming
@ 2026-01-31 8:36 ` Dmitry Baryshkov
2026-02-23 23:27 ` Dmitry Baryshkov
2026-02-24 4:05 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-01-31 8:36 UTC (permalink / raw)
To: sunliming
Cc: robin.clark, lumag, airlied, simona, abhinav.kumar, jesszhan0024,
sean, marijn.suijten, linux-arm-msm, dri-devel, freedreno,
linux-kernel, sunliming, kernel test robot, Dan Carpenter
On Fri, Jan 30, 2026 at 01:36:15PM +0800, sunliming@linux.dev wrote:
> From: sunliming <sunliming@kylinos.cn>
>
> Fix below smatch warnings:
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c:161 dpu_hw_sspp_setup_pe_config_v13()
> warn: variable dereferenced before check 'ctx' (see line 159)
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202601252214.oEaY3UZM-lkp@intel.com/
> Signed-off-by: sunliming <sunliming@kylinos.cn>
> ---
> v2: Fix error code
Which error code?
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c
> index e65f1fc026fd..312ee6597ab1 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c
> @@ -156,11 +156,13 @@ static void dpu_hw_sspp_setup_pe_config_v13(struct dpu_hw_sspp *ctx,
> u8 color;
> u32 lr_pe[4], tb_pe[4];
> const u32 bytemask = 0xff;
> - u32 offset = ctx->cap->sblk->sspp_rec0_blk.base;
> + u32 offset;
>
> if (!ctx || !pe_ext)
> return;
>
> + offset = ctx->cap->sblk->sspp_rec0_blk.base;
> +
> c = &ctx->hw;
> /* program SW pixel extension override for all pipes*/
> for (color = 0; color < DPU_MAX_PLANES; color++) {
> --
> 2.25.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] drm/msm/dpu: Fix smatch warnings about variable dereferenced before check
2026-01-30 5:36 [PATCH v2] drm/msm/dpu: Fix smatch warnings about variable dereferenced before check sunliming
2026-01-31 8:36 ` Dmitry Baryshkov
@ 2026-02-23 23:27 ` Dmitry Baryshkov
2026-02-24 4:05 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-02-23 23:27 UTC (permalink / raw)
To: sunliming
Cc: robin.clark, lumag, airlied, simona, abhinav.kumar, jesszhan0024,
sean, marijn.suijten, linux-arm-msm, dri-devel, freedreno,
linux-kernel, sunliming, kernel test robot, Dan Carpenter
On Fri, Jan 30, 2026 at 01:36:15PM +0800, sunliming@linux.dev wrote:
> From: sunliming <sunliming@kylinos.cn>
>
> Fix below smatch warnings:
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c:161 dpu_hw_sspp_setup_pe_config_v13()
> warn: variable dereferenced before check 'ctx' (see line 159)
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202601252214.oEaY3UZM-lkp@intel.com/
> Signed-off-by: sunliming <sunliming@kylinos.cn>
> ---
> v2: Fix error code
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/msm/dpu: Fix smatch warnings about variable dereferenced before check
2026-01-30 5:36 [PATCH v2] drm/msm/dpu: Fix smatch warnings about variable dereferenced before check sunliming
2026-01-31 8:36 ` Dmitry Baryshkov
2026-02-23 23:27 ` Dmitry Baryshkov
@ 2026-02-24 4:05 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-02-24 4:05 UTC (permalink / raw)
To: robin.clark, lumag, airlied, simona, abhinav.kumar, jesszhan0024,
sean, marijn.suijten, linux-arm-msm, dri-devel, freedreno,
linux-kernel, sunliming
Cc: sunliming, kernel test robot, Dan Carpenter
On Fri, 30 Jan 2026 13:36:15 +0800, sunliming@linux.dev wrote:
> Fix below smatch warnings:
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp_v13.c:161 dpu_hw_sspp_setup_pe_config_v13()
> warn: variable dereferenced before check 'ctx' (see line 159)
>
>
Applied to msm-fixes, thanks!
[1/1] drm/msm/dpu: Fix smatch warnings about variable dereferenced before check
https://gitlab.freedesktop.org/lumag/msm/-/commit/b1dcc804f466
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread