From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD248274FD0 for ; Fri, 30 Jan 2026 08:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769760093; cv=none; b=KxlFB+dfY3VEBdP8shK54P2CUQ2uWL6WBV+PwI5CvMvn38edOPGMHnLScAOTXHEJ5EblpRKwgn7MjyOgqv1z9ex4AJ29dihD6RvADBNt98KLhMUsvnOzS01yF0zgoU5dz4GwYW0DxWrnCRWl06ojCGFlo1HefjE7q8ASlKXO4w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769760093; c=relaxed/simple; bh=jDD7nWq4gJtag2srW+Y4CGt3XmjewU26Hatebh/4rWs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VvCETIO5BvVbN0cJwJ3dd0gMO69ZF/HexZD3Zxy5Ybq8+VthTOQVPhMhOoTyGtSfFj4tXcK+5cZlQcRFK5kdQPR1r9/ufSsbTsiLyD/sqBcimxqbTMlm7thNWhrVlEZcutxyTLdIkEE1j6baLL+foRNp6v+CvNvTIPmPhin7LMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=itYlIj8y; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="itYlIj8y" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42fbc544b09so1757164f8f.1 for ; Fri, 30 Jan 2026 00:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769760090; x=1770364890; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Tq182RTHc9nFqgDZCsUQmbFZbPCVG9t5+ol0judqgCY=; b=itYlIj8yc1LBqdMwlm9yfAYIBiCOyWoowhZuznZ+DX8aucQ6yreQvwWI4a+pY0PWsv LDW5RoY1oUh9DBwMjfMcs7E6fbqV8M7mnoAU2JjREKF6ScVqw9SvVS6izXuQs2bTAwll MbS/FDJbb4kXkInvJYT4ISn+O4hC3GjVBrgjslBV4VarEbj43d7eEbq9KetZ5I7SN3aN MT2jkBii7211uMFBJjeABmnVqEtlK0GI+86pOyrWUGy+cn1KkaciQC6URhmL1G16fs0w siAZ4D4o+Phopc7rERB41P/YEehbz2HvprkR1SY6kuu6MoMqBUqbvpwjnmwyo3BIaS+G DM1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769760090; x=1770364890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Tq182RTHc9nFqgDZCsUQmbFZbPCVG9t5+ol0judqgCY=; b=CRogUctzlM984E/eW76Ns0muQ8Hji5cZQPfhPiLLhlqfTgDwBIQYoTp3pxed+nCCJP MIdkRg783Beww01DgouM4gRSc48JtEyMStkkmdjBNGwKa8D1+Crrsw/uEE8vahFgsaON 4zT1UcU9rDehpMWhOVajVi+Xz6Vhlc/cUzs+Qp+Rf/vTrsqh0YRmaS2r6dpCUgn7y/4C zjrXY/3uVodbOf1bnTHh52SazqOk2KPXobTFzn3x2qt+G8PHvVWoHmnlWZCOVmnOi6ZB jxIw1jsLTBrUpcMCUcGkB4tcbVwc3v1Cdy0o9R4fJubhUEZBWfccR2re6JyE0KuLvasJ gpcA== X-Forwarded-Encrypted: i=1; AJvYcCXsKXUNlKMpm/O0NANjUooHDP4fKn7L0rwI3G9Y4H+ZcH2Q9X8Gcl5eONSHfT28Lvi8b3AcdyUTnomdVOw=@vger.kernel.org X-Gm-Message-State: AOJu0YzADy/ETwETDCDEXUB3l51RJJBdQBSnd7BGJWkl+uK7B+d8/o+w 86V7NI0gGLAZ31D7RQA+q999xCmVCvnb4Pl+vY+sJNb1shgUu5qhoZhS X-Gm-Gg: AZuq6aIjoDFFZQucKQPueSyOSmfJvXNXxmjpWL2VoI5crlhgSwDWJdLAOFu66baR6xT z2cRDq2Kf2yeIwcpVcyx+aGRuA3FErppZyCJwk6xHQcLnnwTHVdv7OwouvKF2eeUkZftYOgT++A GX/8aG8LeH+5xHrI6bvE1adDEP2VE0zG7unKVF2l9GDZmRS0scjzJPPqgi2TukUYwmWjAI7LMUo QZIYCWee7dPaVyeNjwwrw2ZovMU2JrOjpHRVwSZM1ykLqZtL2NHfkSxYVGrTz6y0kFEa3VBVrzq 6i4rdSFhkbbdaqnD9m6nGbCOssmLk8p1K3ltIqJcIBHbxL7TnzcJIhHsKGrcSsc+DoQopmlGsAE msGvcN9j17R96WqPRFhIozSDBKHhKWvjeHYUhQRFPVSVwsE8zvInCiAiFujuKdqMgG6OM8+12nP XssZlcKAyvDPjb3BV8QlbaULHPCF6jdrCy969idJJDVx2K5D0WDNd9omkpFtPDan8= X-Received: by 2002:a05:6000:200e:b0:433:2f55:7cab with SMTP id ffacd0b85a97d-435f3aa796emr3023751f8f.37.1769760089908; Fri, 30 Jan 2026 00:01:29 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131cefdsm20131619f8f.23.2026.01.30.00.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 00:01:29 -0800 (PST) Date: Fri, 30 Jan 2026 08:01:28 +0000 From: David Laight To: Cheng Li Cc: Willy Tarreau , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] tools/nolibc: support left alignment (-) and zero padding (0) in printf Message-ID: <20260130080128.17cde0d3@pumpkin> In-Reply-To: References: <20260128094224.11299-1-im.lechain@gmail.com> <20260128094224.11299-2-im.lechain@gmail.com> <20260129103057.324d654d@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 30 Jan 2026 09:05:39 +0800 Cheng Li wrote: > David Laight =E4=BA=8E2026=E5=B9=B41=E6=9C= =8829=E6=97=A5=E5=91=A8=E5=9B=9B 18:30=E5=86=99=E9=81=93=EF=BC=9A ...=20 > These are great suggestions for a larger refactoring of printf to > improve performance and standard compliance. > However, to keep this current change minimal and safe, I prefer to > focus on fixing the alignment feature first. >=20 > @Willy, I will send a v3 that removes the '0' flag handling logic to > avoid the bug pointed out above. >=20 > I will rethink how to implement leading zero pad support. You made me look at the code. A simple refactor saved 98 bytes (about 10%). I will look at adding support for field precision - which is what is needed for leading zeros. Will use up some of the saved space, but probably not all of it. I'll base any patch on top of your change. David