From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7706C1925BC for ; Fri, 30 Jan 2026 03:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769742275; cv=none; b=s7zceL+ZEblBCsI3T1e9xRY8KDsQUDAMGe7ZXTSAT5cZgUfUBGqqIPryA3ayuzRe6a9Kp11aOAXxwJ26SIeHinzU6v51RAnEE1uEGlKYy9IKr5D3lLCuZ7Pp9bR9Ap8qUXJJgiFDSe4bO/01c6U8tcXqv4r6whXDpcUpf4kBFJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769742275; c=relaxed/simple; bh=bc7u74LVYc9UekDNqOXsly9zkvNuhJqgVW3Ic95fVvM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hMh5Uf2BW68g2uojr5irxIoG8c43IBUABRXUqkkk4vJTz7cpWCyCO6PZ9nfLTUg+6JcudLkSyjBiU4Yh5JfRWToZCpSE+5v/1n4kRA1/3blKjvYHiE+c1/k8E1ICZM7vrxWIT10dTeIflls3hai7BoGMwVuoV7Sp0ll8eWwnj0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T2zhW6RC; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T2zhW6RC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769742273; x=1801278273; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bc7u74LVYc9UekDNqOXsly9zkvNuhJqgVW3Ic95fVvM=; b=T2zhW6RCBiBF0DkQ6A/hufBZvJpxfYepyBOqsmOSliNgeIHuH0cEFVcl WtZIALnxw0A6mP5u1yg6vzWUdeWmVSV42Dq1gmRFqhpCzn1uwDvdpLJIk 8HGXwJ9GdHyw1TErdDHJgMf7PHgsW8wJnmVhx52iH1IQH6X0lBN+yuDhT nHa/2ly3wlJRkyMr8YqABFGtGLXIJ4bLTDotBAem6knHK1gxWOwsTdMON H15SH6mdnARqaiVcLZT1Tl+AiQvFxC6hICh7guSSZX87WOgQtjAe6Bs91 vcKoAvTJLq0zePYPuuQh7RFZXzryx7xgxCfaeD6bEPQDYWukFk8uqO8Ip Q==; X-CSE-ConnectionGUID: ++moxzbfTTCSabGjuYoL3A== X-CSE-MsgGUID: a2mch5P9RzOP6Hm4h5+wkA== X-IronPort-AV: E=McAfee;i="6800,10657,11686"; a="88405910" X-IronPort-AV: E=Sophos;i="6.21,262,1763452800"; d="scan'208";a="88405910" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2026 19:04:32 -0800 X-CSE-ConnectionGUID: tGDPVXjSRcun43cHIKk5Wg== X-CSE-MsgGUID: 2pEfEYMdSAmCuRgbkxja8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,262,1763452800"; d="scan'208";a="207872451" Received: from lkp-server01.sh.intel.com (HELO 765f4a05e27f) ([10.239.97.150]) by orviesa006.jf.intel.com with ESMTP; 29 Jan 2026 19:04:27 -0800 Received: from kbuild by 765f4a05e27f with local (Exim 4.98.2) (envelope-from ) id 1vleo4-00000000c7M-1707; Fri, 30 Jan 2026 03:04:24 +0000 Date: Fri, 30 Jan 2026 11:03:38 +0800 From: kernel test robot To: Abhash Kumar Jha , andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, devarsht@ti.com, u-kumar1@ti.com, sjakhade@cadence.com Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, s-jain1@ti.com, p-mantena@ti.com, tomi.valkeinen@ideasonboard.com Subject: Re: [PATCH] drm/bridge: cdns-mhdp8546: Add suspend resume support to the bridge driver Message-ID: <202601301031.VutflAtp-lkp@intel.com> References: <20260129112016.2448037-1-a-kumar2@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260129112016.2448037-1-a-kumar2@ti.com> Hi Abhash, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.19-rc7 next-20260129] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Abhash-Kumar-Jha/drm-bridge-cdns-mhdp8546-Add-suspend-resume-support-to-the-bridge-driver/20260129-193145 base: https://gitlab.freedesktop.org/drm/misc/kernel.git drm-misc-next patch link: https://lore.kernel.org/r/20260129112016.2448037-1-a-kumar2%40ti.com patch subject: [PATCH] drm/bridge: cdns-mhdp8546: Add suspend resume support to the bridge driver config: parisc-randconfig-002-20260130 (https://download.01.org/0day-ci/archive/20260130/202601301031.VutflAtp-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260130/202601301031.VutflAtp-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202601301031.VutflAtp-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:2447:12: warning: 'cdns_mhdp_suspend' defined but not used [-Wunused-function] static int cdns_mhdp_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c:2387:12: warning: 'cdns_mhdp_resume' defined but not used [-Wunused-function] static int cdns_mhdp_resume(struct device *dev) ^~~~~~~~~~~~~~~~ vim +/cdns_mhdp_suspend +2447 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c 2386 > 2387 static int cdns_mhdp_resume(struct device *dev) 2388 { 2389 struct cdns_mhdp_device *mhdp = dev_get_drvdata(dev); 2390 unsigned long rate; 2391 int ret; 2392 2393 ret = clk_prepare_enable(mhdp->clk); 2394 if (ret) 2395 return ret; 2396 2397 rate = clk_get_rate(mhdp->clk); 2398 writel(rate % 1000000, mhdp->regs + CDNS_SW_CLK_L); 2399 writel(rate / 1000000, mhdp->regs + CDNS_SW_CLK_H); 2400 writel(~0, mhdp->regs + CDNS_APB_INT_MASK); 2401 2402 ret = phy_init(mhdp->phy); 2403 if (ret) { 2404 dev_err(mhdp->dev, "Failed to initialize PHY: %d\n", ret); 2405 goto disable_clk; 2406 } 2407 ret = phy_power_on(mhdp->phy); 2408 if (ret < 0) { 2409 dev_err(mhdp->dev, "Failed to power on PHY: %d\n", ret); 2410 goto error; 2411 } 2412 2413 if (mhdp->powered_off) { 2414 ret = cdns_mhdp_load_firmware(mhdp); 2415 if (ret) 2416 goto phy_off; 2417 2418 ret = wait_event_timeout(mhdp->fw_load_wq, 2419 mhdp->hw_state == MHDP_HW_READY, 2420 msecs_to_jiffies(1000)); 2421 if (ret == 0) { 2422 dev_err(mhdp->dev, "%s: Timeout waiting for fw loading\n", 2423 __func__); 2424 ret = -ETIMEDOUT; 2425 goto phy_off; 2426 } 2427 } else { 2428 ret = cdns_mhdp_set_firmware_active(mhdp, true); 2429 if (ret) { 2430 dev_err(mhdp->dev, "Failed to activate firmware (%pe)\n", ERR_PTR(ret)); 2431 goto phy_off; 2432 } 2433 } 2434 2435 return 0; 2436 2437 phy_off: 2438 phy_power_off(mhdp->phy); 2439 error: 2440 phy_exit(mhdp->phy); 2441 disable_clk: 2442 clk_disable_unprepare(mhdp->clk); 2443 2444 return ret; 2445 } 2446 > 2447 static int cdns_mhdp_suspend(struct device *dev) 2448 { 2449 struct cdns_mhdp_device *mhdp = dev_get_drvdata(dev); 2450 unsigned long timeout = msecs_to_jiffies(100); 2451 int ret = 0; 2452 2453 cancel_work_sync(&mhdp->hpd_work); 2454 ret = wait_event_timeout(mhdp->fw_load_wq, 2455 mhdp->hw_state == MHDP_HW_READY, 2456 timeout); 2457 2458 spin_lock(&mhdp->start_lock); 2459 if (mhdp->hw_state != MHDP_HW_READY) { 2460 spin_unlock(&mhdp->start_lock); 2461 return -EINVAL; 2462 } 2463 mhdp->hw_state = MHDP_HW_STOPPED; 2464 spin_unlock(&mhdp->start_lock); 2465 2466 if (ret == 0) { 2467 dev_err(mhdp->dev, "%s: Timeout waiting for fw loading\n", __func__); 2468 ret = -ETIMEDOUT; 2469 goto error; 2470 } else { 2471 ret = cdns_mhdp_set_firmware_active(mhdp, false); 2472 if (ret) { 2473 dev_err(mhdp->dev, "Failed to stop firmware (%pe)\n", ERR_PTR(ret)); 2474 goto error; 2475 } 2476 } 2477 2478 phy_power_off(mhdp->phy); 2479 phy_exit(mhdp->phy); 2480 clk_disable_unprepare(mhdp->clk); 2481 2482 error: 2483 return ret; 2484 } 2485 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki