From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC514242D6C for ; Fri, 30 Jan 2026 11:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769773183; cv=none; b=PAAIZ4EnLVi/o3bYt3kcIVa2xGT3VITKsMgRrfbmsTLSZUiJLaYKWyQXpyaD9BeSIFO6AcL1q/ZpIQmkLJQYo81ouBeXracmVZI0OuEU60gz0V8n5W6EZSQ3eJh7NRptgWo7AxyXhl0hZ4cIaWQYv6X/ra3ROeT0RGA8VgspfTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769773183; c=relaxed/simple; bh=fpt501jNDSTqjbeK60PmdpgnD9mB/fjd+1I5xcY4OzY=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e8fSxtH4m80tFge0qXF8EFiG/XQqQ2rmls4w/6zkHa1DyQ7SdZPa5PUsW1QeDZ3SOLZzpmaf1J/gOcCYdlt+joYQlEDArC1czKAhK6BS4hYJB2iWk8MOtgEqQowkzE6lPLXy8q2T/Kihc4B+hbCISBt4TVuEJ0cZY/bN9kiiPtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.224.107]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4f2Ytc4LQ6zHnGjf; Fri, 30 Jan 2026 19:38:48 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id F2DC540570; Fri, 30 Jan 2026 19:39:39 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 30 Jan 2026 11:39:39 +0000 Date: Fri, 30 Jan 2026 11:39:37 +0000 From: Jonathan Cameron To: Pavan Chebbi CC: , , , , , , , , Subject: Re: [PATCH v3 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl Message-ID: <20260130113937.00001423@huawei.com> In-Reply-To: <20260129155453.3626544-4-pavan.chebbi@broadcom.com> References: <20260129155453.3626544-1-pavan.chebbi@broadcom.com> <20260129155453.3626544-4-pavan.chebbi@broadcom.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100011.china.huawei.com (7.191.174.247) To dubpeml500005.china.huawei.com (7.214.145.207) On Thu, 29 Jan 2026 07:54:51 -0800 Pavan Chebbi wrote: > Create an additional auxiliary device to support fwctl. > The next patch will create bnxt_fwctl and bind to this > device. > > Reviewed-by: Andy Gospodarek > Signed-off-by: Pavan Chebbi > --- > drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++-- > include/linux/bnxt/ulp.h | 1 + > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c > index 3097fc5755e6..9fd3c1e43224 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c > @@ -50,6 +50,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int idx) > > static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] = {{ > .name = "rdma", > +}, { > + .name = "fwctl", > }}; > > static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *ent) > @@ -278,6 +280,11 @@ void bnxt_ulp_stop(struct bnxt *bp) > aux_priv = bp->aux_priv[i]; > edev = bp->edev[i]; > mutex_lock(&edev->en_dev_lock); > + if (i == BNXT_AUXDEV_FWCTL) { Similar to earlier. I'd like this stuff to be callbacks or data in bnxt_aux_devices to keep the code flow simpler. > + edev->flags |= BNXT_EN_FLAG_ULP_STOPPED; > + mutex_unlock(&edev->en_dev_lock); > + continue;