Re: [PATCH] firmware/dmi: Include product_family info to modalias

[Jean Delvare <jdelvare@suse.de>]

Hi Antoine,

On Fri, 16 Jan 2026 14:03:15 +0100, Antoine Lassagne wrote:
> Some platforms rely on modalias to customize configuration,
> the product family helps to identify the hardware.
> 
> Add product_family to modalias for better utilization.
> This patch mimics commit e26f023e01ef ("firmware/dmi:
> Include product_sku info to modalias") that did the same
> for product_sku, and commit f97a2103f1a7 ("firmware: dmi:
> Move product_sku info to the end of the modalias") that
> fixed regressions caused by the added field notbeing in 

Missing space (no worry, I'll fix it as I commit the patch).

> the end of the list.
> 
> Signed-off-by: Antoine Lassagne <antoine.lassagne@canonical.com>
> ---
>  drivers/firmware/dmi-id.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c
> index d19c78a78ae3..6b5c7bf35387 100644
> --- a/drivers/firmware/dmi-id.c
> +++ b/drivers/firmware/dmi-id.c
> @@ -96,6 +96,7 @@ static ssize_t get_modalias(char *buffer, size_t buffer_size)
>  		{ "ct",  DMI_CHASSIS_TYPE },
>  		{ "cvr", DMI_CHASSIS_VERSION },
>  		{ "sku", DMI_PRODUCT_SKU },
> +		{ "pfa", DMI_PRODUCT_FAMILY },
>  		{ NULL,  DMI_NONE }
>  	};
>  

Looks reasonable. Out of curiosity, what is your practical use case?

-- 
Jean Delvare
SUSE L3 Support