Re: [PATCH 2/2] ASoC: xilinx: xlnx_i2s: Discover parameters from registers

[kernel test robot <lkp@intel.com>]

Hi Sean,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on broonie-spi/for-next linus/master v6.19-rc7 next-20260129]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/dt-bindings-sound-xlnx-i2s-Make-discoverable-parameters-optional/20260130-012955
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20260129172315.3871602-3-sean.anderson%40linux.dev
patch subject: [PATCH 2/2] ASoC: xilinx: xlnx_i2s: Discover parameters from registers
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20260130/202601301436.qPUffKmd-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260130/202601301436.qPUffKmd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601301436.qPUffKmd-lkp@intel.com/

All errors (new ones prefixed by >>):

   sound/soc/xilinx/xlnx_i2s.c: In function 'xlnx_i2s_probe':
>> sound/soc/xilinx/xlnx_i2s.c:191:30: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
     191 |         drv_data->channels = FIELD_GET(I2S_CORE_CFG_CHANNELS, cfg);
         |                              ^~~~~~~~~


vim +/FIELD_GET +191 sound/soc/xilinx/xlnx_i2s.c

   173	
   174	static int xlnx_i2s_probe(struct platform_device *pdev)
   175	{
   176		struct xlnx_i2s_drv_data *drv_data;
   177		int ret;
   178		u32 format, cfg;
   179		struct device *dev = &pdev->dev;
   180		struct device_node *node = dev->of_node;
   181	
   182		drv_data = devm_kzalloc(&pdev->dev, sizeof(*drv_data), GFP_KERNEL);
   183		if (!drv_data)
   184			return -ENOMEM;
   185	
   186		drv_data->base = devm_platform_ioremap_resource(pdev, 0);
   187		if (IS_ERR(drv_data->base))
   188			return PTR_ERR(drv_data->base);
   189	
   190		cfg = readl(drv_data->base + I2S_CORE_CFG);
 > 191		drv_data->channels = FIELD_GET(I2S_CORE_CFG_CHANNELS, cfg);
   192		if (cfg & I2S_CORE_CFG_DATA_24BIT) {
   193			drv_data->data_width = 24;
   194			format = SNDRV_PCM_FMTBIT_S24_LE;
   195		} else {
   196			drv_data->data_width = 16;
   197			format = SNDRV_PCM_FMTBIT_S16_LE;
   198		}
   199	
   200		if (of_device_is_compatible(node, "xlnx,i2s-transmitter-1.0")) {
   201			drv_data->dai_drv.name = "xlnx_i2s_playback";
   202			drv_data->dai_drv.playback.stream_name = "Playback";
   203			drv_data->dai_drv.playback.formats = format;
   204			drv_data->dai_drv.playback.channels_min = drv_data->channels;
   205			drv_data->dai_drv.playback.channels_max = drv_data->channels;
   206			drv_data->dai_drv.playback.rates	= SNDRV_PCM_RATE_8000_192000;
   207			drv_data->dai_drv.ops = &xlnx_i2s_dai_ops;
   208		} else if (of_device_is_compatible(node, "xlnx,i2s-receiver-1.0")) {
   209			drv_data->dai_drv.name = "xlnx_i2s_capture";
   210			drv_data->dai_drv.capture.stream_name = "Capture";
   211			drv_data->dai_drv.capture.formats = format;
   212			drv_data->dai_drv.capture.channels_min = drv_data->channels;
   213			drv_data->dai_drv.capture.channels_max = drv_data->channels;
   214			drv_data->dai_drv.capture.rates = SNDRV_PCM_RATE_8000_192000;
   215			drv_data->dai_drv.ops = &xlnx_i2s_dai_ops;
   216		} else {
   217			return -ENODEV;
   218		}
   219		drv_data->is_32bit_lrclk = readl(drv_data->base + I2S_CORE_CTRL_OFFSET) &
   220					   I2S_CORE_CTRL_32BIT_LRCLK;
   221	
   222		dev_set_drvdata(&pdev->dev, drv_data);
   223	
   224		ret = devm_snd_soc_register_component(&pdev->dev, &xlnx_i2s_component,
   225						      &drv_data->dai_drv, 1);
   226		if (ret) {
   227			dev_err(&pdev->dev, "i2s component registration failed\n");
   228			return ret;
   229		}
   230	
   231		dev_info(&pdev->dev, "%s DAI registered\n", drv_data->dai_drv.name);
   232	
   233		return ret;
   234	}
   235	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki