From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3092C305E3B for ; Fri, 30 Jan 2026 15:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769786366; cv=none; b=FxBxLdv0pFqPPWR+iUoR5gM1pdFnpjbrUywJO0KZJ4nRfgRPoJ6g69kjNSRM6k51klC6MNpjj2scuOObrKsOalDlJ3SnkPZZ4+J2tPkfBjvug+luJls8uG6gEryaeBSosp9oJlRWF74CgBZ4Q5g08il0JzKldZ1Bj6rLc1ASqwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769786366; c=relaxed/simple; bh=gR38EHJR1PZK6/Q47y5rX6y6CS1FSLFF2Rb6jxzWw0c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IlrP068eKvN4PQSDPWSXY7qTqk+G7DfJnrzG4ODswEAkEHYqf7a98m7zcnYAggiwmgbIc+OlEnwm/xLabbaUuCGxVonETXSyQHsvov/X3O8waxpQfucRHIXtod+w99nA+d+Sv9od636wP0fJ7D1FR3LBYwaIkLd8WiwgelU/R7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=IUtMA4mA; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="IUtMA4mA" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-88fca7bce90so27897776d6.3 for ; Fri, 30 Jan 2026 07:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1769786364; x=1770391164; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fOIhh/SNHZdIp2EwiHTVvWAKC+lgVLUiV/QILu+AOPs=; b=IUtMA4mAxZlnIG2EhnsQCPeQuASiYS4XaLgs3Ah3FlH2Fm/qdyGqu58uGSMo8ziS+P 5xdAXh6l6a90KLOAh9Pznfcq8XlXhYmGPIsK56z3c1AQCk8W207NZ/HTwRgT9J54lcMu GA1Tma0P5dZ2ePYk4FCFjygjPcSCLUqGvi5vVQm2yILI7q3cdeAjKZeata98p9dsc9YP mf+dUaNGaJF+ZqipW9zRnIDulYZ/yBLF9+kr/RNCIJxENqwIn03l/o1WHpU1Ygj47qWp aEd8BuRVA70pUAg2AsikroeIEQf/sK4vkRWHLwB+FzCN1tPCphwPhfzxcJamxHohpZT4 lPvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769786364; x=1770391164; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fOIhh/SNHZdIp2EwiHTVvWAKC+lgVLUiV/QILu+AOPs=; b=mrprkkYSbWJC+tn3arvo+Bd68udKqjw9mYZM0BxdhSKI1TZrQh/lXwcU68USKnsv4k moytXoMYZxu64ZMWDEWumambux4lZEhpkngqb0r1lOWbFiUjq8Rfvg+kPhEMAyftxalY M3h+HmJU8X1fE8/gAZERUIDjKWpLj98D9rIJNDHQYqrGYU0Gf2IoT3afOhM3gP2fYXyz fiGtfaeamHBaUiuf73ONhj3IQeLODK6MQ//DqPzE7T0uYy4E7dR9xZ6nNRM7OLGsEd1q gokQHQMBUPHnhN0o/S8rx25/ZXHdoNmn9KttXc/9gyKVYBw8mr0FWWFS/bydnKBgALJt 5FWw== X-Forwarded-Encrypted: i=1; AJvYcCUdkGZQlY0JER8vLOB/ZBXjux7wL3/6OaPdHGi3oCZTrSdWDm7l+QmAOdxCFOg8gtbvOG3SYdUY8KNn9JE=@vger.kernel.org X-Gm-Message-State: AOJu0YzjtYAuxHJ9pieF2wToqoLGMsFMtB6Sc+fvIVTXZR6y21nXKoAw j2XrCs9CjHz/xixvE7xwdNo7ax/cjnuHrEBQzrZ3CY5hjXJUSNrH7sT9h17lN62kskY= X-Gm-Gg: AZuq6aLcN/X/siH4VMwqtfksIC9DlHt4RnoYDu1uDQ4hdB44ttzqoEnUoMdJ9ITHh5n WL4vHpGz4iBP+X9uGdX6FdShZ/n1kI9epfzYaOp61wuE7Oy+J/XHnyzz34xwEvTUIBaaVsTja0J LIoM2rv7Kz/uU4u12BK/DMdEhrUKKiALlxzyXe2LNibl7t7IEgNCnWa79+mRZLl+eu+uwVi40CM toX5Ik9B+Qrp9YAAQkT+eCzQRgQ6Gg+mXfw/9vZXDV/E3fMFwv52RNpUxVbru9AJK8faLPJyM6c k9zWsSBjscZ/JzA2dTP7ISq3C2dSkDuTuViciy4K6uXchJ9lu8GgTFM1SDFU9DG4MmXmVOUQMUu AXWTJJOD0My3OK0mkHRQK50TiqCjEYEEZ6FraYJ91HytPCzrviMWmlp0J7jlkAgHMBDonKwF55j BxOTJG6u1TgkIxlNEG0j/qNwi2fejvhwmfxj8nNhZhJQXublq9a/AwsyAUDsEr/VOh73Q= X-Received: by 2002:ad4:5be8:0:b0:892:e3c3:94df with SMTP id 6a1803df08f44-894e9faf059mr43480166d6.28.1769786363946; Fri, 30 Jan 2026 07:19:23 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-894d375debasm61164476d6.42.2026.01.30.07.19.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 07:19:23 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vlqHK-0000000BBYj-3uJd; Fri, 30 Jan 2026 11:19:22 -0400 Date: Fri, 30 Jan 2026 11:19:22 -0400 From: Jason Gunthorpe To: Jonathan Cameron Cc: Pavan Chebbi , michael.chan@broadcom.com, linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com Subject: Re: [PATCH v3 fwctl 4/5] fwctl/bnxt_fwctl: Add bnxt fwctl device Message-ID: <20260130151922.GG2328995@ziepe.ca> References: <20260129155453.3626544-1-pavan.chebbi@broadcom.com> <20260129155453.3626544-5-pavan.chebbi@broadcom.com> <20260130120357.0000639b@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260130120357.0000639b@huawei.com> On Fri, Jan 30, 2026 at 12:03:57PM +0000, Jonathan Cameron wrote: > > --- a/drivers/fwctl/Makefile > > +++ b/drivers/fwctl/Makefile > > @@ -2,5 +2,6 @@ > > obj-$(CONFIG_FWCTL) += fwctl.o > > obj-$(CONFIG_FWCTL_MLX5) += mlx5/ > > obj-$(CONFIG_FWCTL_PDS) += pds/ > > +obj-$(CONFIG_FWCTL_BNXT) += bnxt/ > How are we ordering these? Alphabetical maybe? Yes, please sort all the things, including the kconfig Jason