public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Matti Vaittinen" <mazziesaccount@gmail.com>,
	"Fabio Estevam" <festevam@denx.de>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Chen-Yu Tsai" <wens@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad4080: remove unused dec_rate field
Date: Fri, 30 Jan 2026 17:38:49 +0000	[thread overview]
Message-ID: <20260130173849.00004447@huawei.com> (raw)
In-Reply-To: <aXxAVIM3iTXdQJE8@smile.fi.intel.com>

On Fri, 30 Jan 2026 07:23:32 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Jan 29, 2026 at 07:21:58PM +0200, Antoniu Miclaus wrote:
> > Remove unused dec_rate field from ad4080_state struct.
> > The driver reads/writes decimation rate directly from
> > hardware registers via ad4080_get_dec_rate() and
> > ad4080_set_dec_rate() functions.  
> 
> Jonathan, the changes look good to me, but the process wise it made badly.
> Up to you, if you want to apply this, but it might be confusing as this is
> definitely *not* a series.

I'm not planning to queue anything else non urgent for the coming 
merge window, so we have plenty of time to do a v2 nicely.

I'd not be against having this lot of cleanup as a series if it
had a clear cover letter stating tooling used to find them etc.
Whilst not one driver, and can merge independently that sort of grouping
is fine if it provides some value (such as background info).


Jonathan


> 
> Also some patches should probably have a v2, I haven't checked that.
> 


  reply	other threads:[~2026-01-30 17:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 17:21 [PATCH] iio: adc: ad4080: remove unused dec_rate field Antoniu Miclaus
2026-01-29 17:21 ` [PATCH] iio: adc: ad7768-1: remove unused mclk_div field Antoniu Miclaus
2026-01-29 17:22 ` [PATCH] iio: adc: ad7793: remove unused int_vref_mv field Antoniu Miclaus
2026-01-29 17:22 ` [PATCH] iio: adc: ad9467: remove unused output_mode field Antoniu Miclaus
2026-01-29 17:22 ` [PATCH] iio: adc: max1363: remove unused requestedmask field Antoniu Miclaus
2026-01-29 17:22 ` [PATCH] iio: adc: nau7802: remove unused min_conversions field Antoniu Miclaus
2026-01-29 17:22 ` [PATCH] iio: adc: ti-ads1015: remove unused enabled field Antoniu Miclaus
2026-01-29 17:22 ` [PATCH] iio: dac: adi-axi-dac: remove unused int_tone field Antoniu Miclaus
2026-01-29 17:22 ` [PATCH] iio: dac: ti-dac5571: remove unused id field Antoniu Miclaus
2026-01-30  5:21 ` [PATCH] iio: adc: ad4080: remove unused dec_rate field Andy Shevchenko
2026-01-30  7:32   ` Miclaus, Antoniu
2026-01-31 16:50     ` Jonathan Cameron
2026-01-30  5:23 ` Andy Shevchenko
2026-01-30 17:38   ` Jonathan Cameron [this message]
2026-01-31 16:57     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260130173849.00004447@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=festevam@denx.de \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox