Re: [PATCH v5 2/4] rust/drm: Don't setup private driver data until registration

lyude
2026-02-04T20:57:00Z

On Wed, 2026-02-04 at 15:28 -0300, Daniel Almeida wrote:
> > +    pub(crate) data_is_init: AtomicBool,
>
> What about this?
>
> /**
> * @registered:
> *
> * Internally used by drm_dev_register() and
> drm_connector_register().
> */
> bool registered;
>
> Can’t we use this in lieu of this flag you’ve added?

No we couldn't unfortunately. As I said before: a lot of KMS setup has
to happen prior to registration, and most of those callbacks
(atomic_check, atomic_commit, etc.) can both happen before registration
and after. And that's a lot more difficult to deal with if we don't
have access to the private driver data for any of those callbacks.

So - it really does truly need to be tracked separately.
>
> > +