From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Abdurrahman Hussain via B4 Relay
<devnull+abdurrahman.nexthop.ai@kernel.org>,
Michal Simek <monstr@monstr.eu>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Abdurrahman Hussain <abdurrahman@nexthop.ai>
Subject: Re: [PATCH v7 5/6] i2c: xiic: cosmetic cleanup
Date: Sat, 31 Jan 2026 17:35:57 +0300 [thread overview]
Message-ID: <202601311615.10yziOui-lkp@intel.com> (raw)
In-Reply-To: <20260129-i2c-xiic-v7-5-727e434897ef@nexthop.ai>
Hi Abdurrahman,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Abdurrahman-Hussain-via-B4-Relay/i2c-xiic-skip-input-clock-setup-on-non-OF-systems/20260130-054653
base: 63804fed149a6750ffd28610c5c1c98cce6bd377
patch link: https://lore.kernel.org/r/20260129-i2c-xiic-v7-5-727e434897ef%40nexthop.ai
patch subject: [PATCH v7 5/6] i2c: xiic: cosmetic cleanup
config: i386-randconfig-141-20260130 (https://download.01.org/0day-ci/archive/20260131/202601311615.10yziOui-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
smatch version: v0.5.0-8994-gd50c5a4c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202601311615.10yziOui-lkp@intel.com/
smatch warnings:
drivers/i2c/busses/i2c-xiic.c:1539 xiic_i2c_remove() warn: pm_runtime_get_sync() also returns 1 on success
vim +1539 drivers/i2c/busses/i2c-xiic.c
e190a0c389e601 Uwe Kleine-König 2023-05-08 1529 static void xiic_i2c_remove(struct platform_device *pdev)
e1d5b6598cdc33 Richard Röjfors 2010-02-11 1530 {
2557b4ba04df79 Abdurrahman Hussain 2026-01-29 1531 struct device *dev = &pdev->dev;
e1d5b6598cdc33 Richard Röjfors 2010-02-11 1532 struct xiic_i2c *i2c = platform_get_drvdata(pdev);
36ecbcab84d023 Shubhrajyoti Datta 2016-03-02 1533 int ret;
e1d5b6598cdc33 Richard Röjfors 2010-02-11 1534
e1d5b6598cdc33 Richard Röjfors 2010-02-11 1535 /* remove adapter & data */
e1d5b6598cdc33 Richard Röjfors 2010-02-11 1536 i2c_del_adapter(&i2c->adap);
e1d5b6598cdc33 Richard Röjfors 2010-02-11 1537
2557b4ba04df79 Abdurrahman Hussain 2026-01-29 1538 ret = pm_runtime_get_sync(dev);
2557b4ba04df79 Abdurrahman Hussain 2026-01-29 @1539 if (ret)
2557b4ba04df79 Abdurrahman Hussain 2026-01-29 1540 dev_warn(dev, "Failed to activate device for removal (%pe)\n",
810199f7315604 Uwe Kleine-König 2022-10-19 1541 ERR_PTR(ret));
pm_runtime_get_sync() can return 1 on success. Perhaps use
pm_runtime_resume_and_get()?
810199f7315604 Uwe Kleine-König 2022-10-19 1542 else
e1d5b6598cdc33 Richard Röjfors 2010-02-11 1543 xiic_deinit(i2c);
810199f7315604 Uwe Kleine-König 2022-10-19 1544
2557b4ba04df79 Abdurrahman Hussain 2026-01-29 1545 pm_runtime_put_sync(dev);
2557b4ba04df79 Abdurrahman Hussain 2026-01-29 1546 pm_runtime_dont_use_autosuspend(dev);
e1d5b6598cdc33 Richard Röjfors 2010-02-11 1547 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-01-31 14:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 21:43 [PATCH v7 0/6] i2c: xiic: use generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-29 21:43 ` [PATCH v7 1/6] i2c: xiic: skip input clock setup on non-OF systems Abdurrahman Hussain via B4 Relay
2026-01-29 22:43 ` Andrew Lunn
2026-01-29 23:29 ` Abdurrahman Hussain
2026-01-31 10:12 ` Andy Shevchenko
2026-02-01 1:30 ` Abdurrahman Hussain
2026-02-02 13:21 ` Andrew Lunn
2026-02-02 18:26 ` Abdurrahman Hussain
2026-01-31 10:10 ` Andy Shevchenko
2026-01-29 21:43 ` [PATCH v7 2/6] i2c: xiic: switch to devres managed APIs Abdurrahman Hussain via B4 Relay
2026-01-30 10:48 ` Jonathan Cameron
2026-01-31 10:31 ` Andy Shevchenko
2026-01-29 21:43 ` [PATCH v7 3/6] i2c: xiic: remove duplicate error message Abdurrahman Hussain via B4 Relay
2026-01-30 10:49 ` Jonathan Cameron
2026-01-29 21:43 ` [PATCH v7 4/6] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-29 21:43 ` [PATCH v7 5/6] i2c: xiic: cosmetic cleanup Abdurrahman Hussain via B4 Relay
2026-01-31 14:35 ` Dan Carpenter [this message]
2026-02-01 2:14 ` Abdurrahman Hussain
2026-02-01 22:23 ` Uwe Kleine-König
2026-02-02 2:06 ` Abdurrahman Hussain
2026-01-29 21:43 ` [PATCH v7 6/6] i2c xiic: cosmetic: use resource format specifier in debug log Abdurrahman Hussain via B4 Relay
2026-01-31 10:55 ` Andy Shevchenko
2026-01-29 22:36 ` [PATCH v7 0/6] i2c: xiic: use generic device property accessors Andrew Lunn
2026-01-31 10:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202601311615.10yziOui-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+abdurrahman.nexthop.ai@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=monstr@monstr.eu \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox