From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337E0272816 for ; Sun, 1 Feb 2026 17:05:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769965510; cv=none; b=L0OHvISOd5cLNtgQSoWy2nsaR1VHVs5ryqgvCr6Fk1K8ug9BxeymecsIbMLjEF47Bv776FOyfksFlS11NqM+k6A3AbgUJGqkJWA17f4XzEHmmasRvlgA5tVU+II8fhCMtTZagzCFneH6hcvydB73iNH1KCqQwkA5kIgxCGEJSEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769965510; c=relaxed/simple; bh=wY+VyyPf+zeTCcAP7D/EEh4FjtCplLqeAmFbZzcG2tA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qq+Dr3IcCaVurjHIR6u3GxCEHMR8g8G1kkp9zoWe9vVlEQ10lfWlKbDZ/LiwJmmYQ7x8D4eo6G2vLyplgI8cTspkR3tetkqHph4MW1QMVA0zBu0lNfWjsE7yUdh4qEfuSfSrA2Usy4NiyhkH1ztn+cqUytnBJpafLoLpQR7s0aM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Fzj2chwY; arc=none smtp.client-ip=91.218.175.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Fzj2chwY" Date: Mon, 2 Feb 2026 01:04:59 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1769965505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m0d8C18zxhPbKJRj/EyIvfZeIHT8AN8v0aXncDr3P8s=; b=Fzj2chwYYipbTCPPQ7JSl3OKSs+EwJyQyL4t7lRnDgnGr5IHiglASYTPTIQYTMk5zQlpEX /paxFKFA/Hw5OasG0G0Ybfy42dQx19odess3NrwFFnMXXubGjBUkCzsSV4xDEW7e8HJJwe /UAlcr9kthhIkdr+wEdyj8qhEWaoRvs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leo Yan To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Adrian Hunter , James Clark , John Garry , Will Deacon , Mike Leach , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Shimin Guo , Yunseong Kim , Athira Rajeev , Quan Zhou , Andrew Jones , Anup Patel , Dapeng Mi , Thomas Falcon , Blake Jones , Swapnil Sapkal , Kan Liang , Howard Chu , Anubhav Shelat , Aditya Bodkhe , Chun-Tse Shao , Andi Kleen , Dmitry Vyukov , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 2/6] perf kvm stat: Remove use of the arch directory Message-ID: <20260201170459.GA584@debian-dev> References: <20260131200224.1296136-1-irogers@google.com> <20260131200224.1296136-3-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260131200224.1296136-3-irogers@google.com> X-Migadu-Flow: FLOW_OUT On Sat, Jan 31, 2026 at 12:02:20PM -0800, Ian Rogers wrote: [...] > @@ -1666,7 +1661,7 @@ kvm_events_record(struct perf_kvm_stat *kvm, int argc, const char **argv) > return ret; > } > > - for (events_tp = kvm_events_tp; *events_tp; events_tp++) > + for (events_tp = kvm_events_tp(); *events_tp; events_tp++) > events_tp_size++; > > rec_argc = ARRAY_SIZE(record_args) + argc + 2 + > @@ -1681,7 +1676,7 @@ kvm_events_record(struct perf_kvm_stat *kvm, int argc, const char **argv) > > for (j = 0; j < events_tp_size; j++) { > rec_argv[i++] = STRDUP_FAIL_EXIT("-e"); > - rec_argv[i++] = STRDUP_FAIL_EXIT(kvm_events_tp[j]); > + rec_argv[i++] = STRDUP_FAIL_EXIT(kvm_events_tp()[j]); > } Nitpick: we can assign reuse events_tp throughout the kvm_events_record(). Something like: events_tp = kvm_events_tp(); for (j = 0; events_tp[j]; j++) events_tp_size++; ... for (j = 0; j < events_tp_size; j++) { rec_argv[i++] = STRDUP_FAIL_EXIT("-e"); rec_argv[i++] = STRDUP_FAIL_EXIT(events_tp[j]); } [...] > +int setup_kvm_events_tp(struct perf_kvm_stat *kvm) > +{ > + switch (EM_HOST) { > + case EM_PPC: > + case EM_PPC64: > + return __setup_kvm_events_tp_powerpc(kvm); > + default: > + return 0; > + } > +} > + > +int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid) > +{ > + switch (EM_HOST) { > + case EM_AARCH64: > + return __cpu_isa_init_arm64(kvm); > + case EM_LOONGARCH: > + return __cpu_isa_init_loongarch(kvm); > + case EM_PPC: > + case EM_PPC64: > + return __cpu_isa_init_powerpc(kvm); > + case EM_RISCV: > + return __cpu_isa_init_riscv(kvm); > + case EM_S390: > + return __cpu_isa_init_s390(kvm, cpuid); > + case EM_X86_64: > + case EM_386: > + return __cpu_isa_init_x86(kvm, cpuid); > + default: > + pr_err("Unsupported kvm-stat host %d\n", EM_HOST); > + return -1; > + } > +} For a general solution, I'd prefer to use "install" + callback methods rather than the opened code. E.g., each arch installs a structure with callbacks: struct kvm_stat_arch kvm_stat_aarch64 { .setup_events_tp = NULL; .cpu_isa_init = __cpu_isa_init_arm64; ... }; Then at the init phase, we can install arch's structure: switch (EM_HOST) { case EM_AARCH64: kvm_stat_arch_init(&kvm_stat_aarch64); break; ... } Afterwards, it is no need to check EM_HOST anymore, it can simply invoke the arch's callback: int cpu_isa_init(struct perf_kvm_stat *kvm, const char *cpuid) { if (!arch_kvm_stat || !arch_kvm_stat->cpu_isa_init) return -1; return arch_kvm_stat->cpu_isa_init(kvm, cpuid); } As a result, we can avoid spreading "switch (EM_HOST)" everywhere. Thanks, Leo