From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0B630EF91 for ; Mon, 2 Feb 2026 06:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770015516; cv=none; b=aGP8K31vZCsRZtJpSnMCBT3qMNArTMiTtLEjoi169oNyo8CIjg5VAsDI06KC31S3z/He4yH7kOsXOExI4dqCyuTMxrmImpgs8801jdRaLVbqB4dqyBq5mM6t4aN4WQcdoCqIH15A19sLV0Sjm8dnOjEJnEQtJbaHRRil6hvPAE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770015516; c=relaxed/simple; bh=p5IQ0o53BRbKUw40x0pFJD5AdEYLhVn2WspLt+Ay8tc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e9w6fXDwG4JI/gDIn8uBcoA+q0WWOmFUvk0CCltbohGKWrEMyH3V5qA4IG+SwlDfrQ9OJ3DnVdmydGr/HudTQonv9/fxOzPI++6AJUeFcwxbDhCV78FUANraTl3pCKWcOybVuqw0CRnYhZZsDitioj7/Fb46z2/nBDHTcrmwwhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 2550B68B05; Mon, 2 Feb 2026 07:58:26 +0100 (CET) Date: Mon, 2 Feb 2026 07:58:25 +0100 From: Christoph Hellwig To: Daniel Hodges Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-fabrics: use kfree_sensitive() for DHCHAP secrets Message-ID: <20260202065825.GB930@lst.de> References: <20260201030840.3173507-1-hodgesd@meta.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260201030840.3173507-1-hodgesd@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Sat, Jan 31, 2026 at 07:08:40PM -0800, Daniel Hodges wrote: > The DHCHAP secrets (dhchap_secret and dhchap_ctrl_secret) contain > authentication key material for NVMe-oF. Use kfree_sensitive() instead > of kfree() in nvmf_free_options() to ensure secrets are zeroed before > the memory is freed, preventing recovery from freed pages. Looks good: Reviewed-by: Christoph Hellwig