From: Luka Gejak <lukagejak5@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Luka Gejak <lukagejak5@gmail.com>
Subject: [PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips
Date: Mon, 2 Feb 2026 08:07:48 +0100 [thread overview]
Message-ID: <20260202070752.3391-2-lukagejak5@gmail.com> (raw)
In-Reply-To: <20260202070752.3391-1-lukagejak5@gmail.com>
Remove unused definitions and function declarations that were left over
from other Realtek chips:
- Remove rtl8192c_translate_rx_signal_stuff() and
rtl8192c_query_rx_desc_status() function declarations from
rtl8192c_recv.h. These functions are declared but never implemented
or used in the 8723bs driver.
- Remove unused RECV_BLK_SZ, RECV_BLK_CNT, and RECV_BLK_TH defines from
rtl8192c_recv.h. These are not referenced anywhere in the driver.
- Remove unused MAX_PATH_NUM_* definitions for other chips (92CS, 8188E,
8192E, 8812A, 8821A, 8814A, 8822B) from odm.h. Only MAX_PATH_NUM_8723B
is actually used by the driver.
This addresses the first TODO item: find and remove any code for other
chips that is left over.
Signed-off-by: Luka Gejak <lukagejak5@gmail.com>
---
drivers/staging/rtl8723bs/hal/odm.h | 7 -------
drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 8 --------
2 files changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 1c929d88e596..38830552d5bc 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -202,14 +202,7 @@ struct odm_rate_adaptive {
/* */
/* Declare for common info */
/* */
-#define MAX_PATH_NUM_92CS 2
-#define MAX_PATH_NUM_8188E 1
-#define MAX_PATH_NUM_8192E 2
#define MAX_PATH_NUM_8723B 1
-#define MAX_PATH_NUM_8812A 2
-#define MAX_PATH_NUM_8821A 1
-#define MAX_PATH_NUM_8814A 4
-#define MAX_PATH_NUM_8822B 2
#define IQK_THRESHOLD 8
#define DPK_THRESHOLD 4
diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index 9664758e21be..b63625ab4e45 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -7,10 +7,6 @@
#ifndef _RTL8192C_RECV_H_
#define _RTL8192C_RECV_H_
-#define RECV_BLK_SZ 512
-#define RECV_BLK_CNT 16
-#define RECV_BLK_TH RECV_BLK_CNT
-
#define MAX_RECVBUF_SZ (10240)
struct phy_stat {
@@ -34,8 +30,4 @@ struct phy_stat {
/* Rx smooth factor */
#define Rx_Smooth_Factor (20)
-
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
-
#endif
--
2.52.0
next prev parent reply other threads:[~2026-02-02 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 7:07 [PATCH v1 0/5] staging: rtl8723bs: code cleanup and style fixes Luka Gejak
2026-02-02 7:07 ` Luka Gejak [this message]
2026-02-02 8:36 ` [PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips Greg Kroah-Hartman
2026-02-02 7:07 ` [PATCH v1 2/5] staging: rtl8723bs: convert PSTA_INFO_T to struct sta_info * Luka Gejak
2026-02-02 7:07 ` [PATCH v1 3/5] staging: rtl8723bs: remove NDIS type aliases Luka Gejak
2026-02-02 7:07 ` [PATCH v1 4/5] staging: rtl8723bs: remove redundant MAC_ARG macro Luka Gejak
2026-02-02 7:07 ` [PATCH v1 5/5] staging: rtl8723bs: fix LONG_LINE warnings across C files Luka Gejak
2026-02-02 8:35 ` Greg Kroah-Hartman
2026-02-02 8:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202070752.3391-2-lukagejak5@gmail.com \
--to=lukagejak5@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox