[PATCH] ASoC: rt5575: fix SPI dependency

[PATCH] ASoC: rt5575: fix SPI dependency

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The rt5575 driver fails to link when SPI support is in a loadable
module but the codec is built-in:

x86_64-linux-ld: vmlinux.o: in function `rt5575_i2c_probe':
rt5575.c:(.text+0x9792ce): undefined reference to `rt5575_spi_get_device'
rt5575.c:(.text+0x979332): undefined reference to `rt5575_spi_fw_load'

Change the symbol in to a 'bool' and add a dependency that rules
out the broken configuration.

Fixes: 420739112e95 ("ASoC: rt5575: Add the codec driver for the ALC5575")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Alternatively, the main driver could 'depends on SPI_MASTER || !SPI_MASTER',
with the RT5575_SPI support becoming a hidden symbol.
---
 sound/soc/codecs/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index f34d7b510c91..e78ac302da15 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1801,9 +1801,10 @@ config SND_SOC_RT5575
 	depends on I2C
 
 config SND_SOC_RT5575_SPI
-	tristate "Realtek ALC5575 Codec - SPI"
+	bool "Realtek ALC5575 Codec - SPI"
 	depends on SPI_MASTER && I2C
 	depends on SND_SOC_RT5575
+	depends on SPI_MASTER=y || SND_SOC_RT5575=m
 
 config SND_SOC_RT5616
 	tristate "Realtek RT5616 CODEC"
-- 
2.39.5

Re: [PATCH] ASoC: rt5575: fix SPI dependency

[Mark Brown]

On Mon, 02 Feb 2026 10:54:12 +0100, Arnd Bergmann wrote:
> The rt5575 driver fails to link when SPI support is in a loadable
> module but the codec is built-in:
> 
> x86_64-linux-ld: vmlinux.o: in function `rt5575_i2c_probe':
> rt5575.c:(.text+0x9792ce): undefined reference to `rt5575_spi_get_device'
> rt5575.c:(.text+0x979332): undefined reference to `rt5575_spi_fw_load'
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5575: fix SPI dependency
      commit: 1db63f6af17945aed7497ce34a5648add0c1b6d9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark