public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: GOOGLE_USB: add TYPEC dependency
@ 2026-02-02  9:56 Arnd Bergmann
  2026-02-04 12:41 ` Neil Armstrong
  2026-02-04 15:44 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-02-02  9:56 UTC (permalink / raw)
  To: Vinod Koul, Joy Chakraborty, Naveen Kumar, Roy Luo
  Cc: Arnd Bergmann, Neil Armstrong, Alex Elder, Ivaylo Ivanov,
	Dmitry Baryshkov, Inochi Amaoto, Sven Peter, Vladimir Oltean,
	linux-phy, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

With CONFIG_TYPEC=m, this driver cannot be built-in:

arm-linux-gnueabi/bin/arm-linux-gnueabi-ld: drivers/phy/phy-google-usb.o: in function `google_usb_phy_remove':
phy-google-usb.c:(.text+0x24): undefined reference to `typec_switch_unregister'

Add CONFIG_TYPEC as a hard dependency here to force a clean build.
In theory, compile-testing with CONFIG_TYPEC=n would also work, but
that seems pointless.

Fixes: cbce66669c82 ("phy: Add Google Tensor SoC USB PHY driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 142e7b0ef2ef..02467dfd4fb0 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -50,6 +50,7 @@ config GENERIC_PHY_MIPI_DPHY
 config PHY_GOOGLE_USB
 	tristate "Google Tensor SoC USB PHY driver"
 	select GENERIC_PHY
+	depends on TYPEC
 	help
 	  Enable support for the USB PHY on Google Tensor SoCs, starting with
 	  the G5 generation (Laguna). This driver provides the PHY interfaces
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: GOOGLE_USB: add TYPEC dependency
  2026-02-02  9:56 [PATCH] phy: GOOGLE_USB: add TYPEC dependency Arnd Bergmann
@ 2026-02-04 12:41 ` Neil Armstrong
  2026-02-04 15:44 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2026-02-04 12:41 UTC (permalink / raw)
  To: Arnd Bergmann, Vinod Koul, Joy Chakraborty, Naveen Kumar, Roy Luo
  Cc: Arnd Bergmann, Alex Elder, Ivaylo Ivanov, Dmitry Baryshkov,
	Inochi Amaoto, Sven Peter, Vladimir Oltean, linux-phy,
	linux-kernel

On 2/2/26 10:56, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> With CONFIG_TYPEC=m, this driver cannot be built-in:
> 
> arm-linux-gnueabi/bin/arm-linux-gnueabi-ld: drivers/phy/phy-google-usb.o: in function `google_usb_phy_remove':
> phy-google-usb.c:(.text+0x24): undefined reference to `typec_switch_unregister'
> 
> Add CONFIG_TYPEC as a hard dependency here to force a clean build.
> In theory, compile-testing with CONFIG_TYPEC=n would also work, but
> that seems pointless.
> 
> Fixes: cbce66669c82 ("phy: Add Google Tensor SoC USB PHY driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/phy/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 142e7b0ef2ef..02467dfd4fb0 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -50,6 +50,7 @@ config GENERIC_PHY_MIPI_DPHY
>   config PHY_GOOGLE_USB
>   	tristate "Google Tensor SoC USB PHY driver"
>   	select GENERIC_PHY
> +	depends on TYPEC
>   	help
>   	  Enable support for the USB PHY on Google Tensor SoCs, starting with
>   	  the G5 generation (Laguna). This driver provides the PHY interfaces

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] phy: GOOGLE_USB: add TYPEC dependency
  2026-02-02  9:56 [PATCH] phy: GOOGLE_USB: add TYPEC dependency Arnd Bergmann
  2026-02-04 12:41 ` Neil Armstrong
@ 2026-02-04 15:44 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2026-02-04 15:44 UTC (permalink / raw)
  To: Joy Chakraborty, Naveen Kumar, Roy Luo, Arnd Bergmann
  Cc: Arnd Bergmann, Neil Armstrong, Alex Elder, Ivaylo Ivanov,
	Dmitry Baryshkov, Inochi Amaoto, Sven Peter, Vladimir Oltean,
	linux-phy, linux-kernel


On Mon, 02 Feb 2026 10:56:52 +0100, Arnd Bergmann wrote:
> With CONFIG_TYPEC=m, this driver cannot be built-in:
> 
> arm-linux-gnueabi/bin/arm-linux-gnueabi-ld: drivers/phy/phy-google-usb.o: in function `google_usb_phy_remove':
> phy-google-usb.c:(.text+0x24): undefined reference to `typec_switch_unregister'
> 
> Add CONFIG_TYPEC as a hard dependency here to force a clean build.
> In theory, compile-testing with CONFIG_TYPEC=n would also work, but
> that seems pointless.
> 
> [...]

Applied, thanks!

[1/1] phy: GOOGLE_USB: add TYPEC dependency
      commit: 8a13968460004d21dd0ca457b06fccfdfdfafd6c

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-04 15:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-02  9:56 [PATCH] phy: GOOGLE_USB: add TYPEC dependency Arnd Bergmann
2026-02-04 12:41 ` Neil Armstrong
2026-02-04 15:44 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox