public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Linus Walleij <linusw@kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] pinctrl: polarfire: restore GENERIC_PINCONF dependency
Date: Mon,  2 Feb 2026 10:58:03 +0100	[thread overview]
Message-ID: <20260202095809.1318785-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

Changing over to the new CONFIG_GENERIC_PINCTRL dropped the GENERIC_PINCONF
option, causing a build failure:

WARNING: unmet direct dependencies detected for GENERIC_PINCTRL
  Depends on [n]: PINCTRL [=y] && GENERIC_PINCONF [=y] && GENERIC_PINCTRL_GROUPS [=n] && GENERIC_PINMUX_FUNCTIONS [=n]
  Selected by [y]:
  - PINCTRL_POLARFIRE_SOC [=y] && PINCTRL [=y] && (ARCH_MICROCHIP [=y] || COMPILE_TEST [=y]) && OF [=y]
drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c:296:29: error: 'pinctrl_generic_get_group_count' undeclared here (not in a function)
  296 |         .get_groups_count = pinctrl_generic_get_group_count,
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Select both GENERIC_PINCTRL and GENERIC_PINCONF to address this.

Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/microchip/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/pinctrl/microchip/Kconfig b/drivers/pinctrl/microchip/Kconfig
index e8bc01946324..a4ae57725fdb 100644
--- a/drivers/pinctrl/microchip/Kconfig
+++ b/drivers/pinctrl/microchip/Kconfig
@@ -12,6 +12,9 @@ config PINCTRL_POLARFIRE_SOC
 	bool "Polarfire SoC pinctrl drivers"
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
+	select GENERIC_PINCONF
 	select GENERIC_PINCTRL
+	select GENERIC_PINCTRL_GROUPS
+	select GENERIC_PINMUX_FUNCTIONS
 	help
 	  This selects the pinctrl drivers for Microchip Polarfire SoC.
-- 
2.39.5


             reply	other threads:[~2026-02-02  9:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  9:58 Arnd Bergmann [this message]
2026-02-02 19:53 ` [PATCH] pinctrl: polarfire: restore GENERIC_PINCONF dependency Conor Dooley
2026-02-02 19:56   ` Arnd Bergmann
2026-02-02 23:57   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260202095809.1318785-1-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=conor.dooley@microchip.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox