From: Taha Ed-Dafili <0rayn.dev@gmail.com>
To: dlechner@baylibre.com
Cc: 0rayn.dev@gmail.com, Michael.Hennerich@analog.com,
andy@kernel.org, corbet@lwn.net, jic23@kernel.org,
lars@metafoo.de, linux-doc@vger.kernel.org,
linux-iio@vger.kernel.org,
linux-kernel-mentees-archive@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, me@brighamcampbell.com,
nuno.sa@analog.com, rdunlap@infradead.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v2 2/4] iio: core: Add IIO_EV_INFO_SCALE to event info
Date: Mon, 2 Feb 2026 10:19:34 -0500 [thread overview]
Message-ID: <20260202151939.15893-1-0rayn.dev@gmail.com> (raw)
In-Reply-To: <afa85a59-07c7-46c9-990a-b0b34599cdc3@baylibre.com>
Hi David,
Thanks for the feedback. You're right—"missing" was poor wording; I’ll
rephrase to "implement support in the core" for v3 to reflect that this
is an infrastructure addition.
Regarding existing users, the current lack of IIO_EV_INFO_SCALE in the core
forces developers into manual workarounds to stay ABI-compliant. For
instance, in drivers/iio/accel/mma8452.c, the developer used
IIO_CONST_ATTR_NAMED to create a manual in_accel_scale and linked it via
.event_attrs. This approach is static and bypasses the standard event_spec
infrastructure.
My goal with adding IIO_EV_INFO_SCALE is to provide a standard path to
report these scales dynamically through read_event_value(), ensuring ABI
compliance without manual sysfs boilerplate.
Does this core infrastructure approach seem like the right architectural
path, or would you prefer I stick to a driver-level attribute for the
ADXL345? Regardless of the path chosen, I will address your other comments
in the next version: I'll fix the "in scale" typo and add the new scale
entries to the adxl345 documentation table.
Thanks,
Taha
next prev parent reply other threads:[~2026-02-02 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 18:33 [PATCH v2 0/4] iio: accel: adxl345: Add event scaling and doc fixes Taha Ed-Dafili
2026-02-01 18:33 ` [PATCH v2 1/4] docs: iio: adxl345: fix typos and grammar Taha Ed-Dafili
2026-02-01 19:03 ` Randy Dunlap
2026-02-02 15:30 ` Taha Ed-Dafili
2026-02-01 18:33 ` [PATCH v2 2/4] iio: core: Add IIO_EV_INFO_SCALE to event info Taha Ed-Dafili
2026-02-01 19:06 ` David Lechner
2026-02-02 15:19 ` Taha Ed-Dafili [this message]
2026-02-02 15:31 ` David Lechner
2026-02-07 16:18 ` Jonathan Cameron
2026-02-01 18:33 ` [PATCH v2 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance Taha Ed-Dafili
2026-02-01 18:33 ` [PATCH v2 4/4] docs: iio: adxl345: update math and examples for scaling Taha Ed-Dafili
2026-02-01 19:13 ` David Lechner
2026-02-07 16:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202151939.15893-1-0rayn.dev@gmail.com \
--to=0rayn.dev@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees-archive@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=nuno.sa@analog.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox