From: Jakub Kicinski <kuba@kernel.org>
To: Vimlesh Kumar <vimleshk@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sedara@marvell.com>, <srasheed@marvell.com>, <hgani@marvell.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
Satananda Burla <sburla@marvell.com>,
"Abhijit Ayarekar" <aayarekar@marvell.com>
Subject: Re: [PATCH RESEND net v3 1/3] octeon_ep: disable per ring interrupts
Date: Mon, 2 Feb 2026 18:04:50 -0800 [thread overview]
Message-ID: <20260202180450.372b216e@kernel.org> (raw)
In-Reply-To: <20260130141549.827020-2-vimleshk@marvell.com>
On Fri, 30 Jan 2026 14:15:45 +0000 Vimlesh Kumar wrote:
> + for (i = 0; i < num_rings; i++) {
> + intr_mask |= (BIT_ULL(srn + i));
Please remove all the pointless brackets..
> + reg_val = octep_read_csr64(oct,
> + CN93_SDP_R_IN_INT_LEVELS(srn + i));
> + reg_val &= (~CN93_INT_ENA_BIT);
.. like this ..
> + octep_write_csr64(oct,
> + CN93_SDP_R_IN_INT_LEVELS(srn + i), reg_val);
> +
> + reg_val = octep_read_csr64(oct,
> + CN93_SDP_R_OUT_INT_LEVELS(srn + i));
> + reg_val &= (~CN93_INT_ENA_BIT);
> + octep_write_csr64(oct,
> + CN93_SDP_R_OUT_INT_LEVELS(srn + i), reg_val);
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_regs_cn9k_pf.h b/drivers/net/ethernet/marvell/octeon_ep/octep_regs_cn9k_pf.h
> index ca473502d7a0..42cb199bd085 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_regs_cn9k_pf.h
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_regs_cn9k_pf.h
> @@ -386,5 +386,6 @@
> #define CN93_PEM_BAR4_INDEX 7
> #define CN93_PEM_BAR4_INDEX_SIZE 0x400000ULL
> #define CN93_PEM_BAR4_INDEX_OFFSET (CN93_PEM_BAR4_INDEX * CN93_PEM_BAR4_INDEX_SIZE)
> +#define CN93_INT_ENA_BIT (BIT_ULL(62))
.. and this.
next prev parent reply other threads:[~2026-02-03 2:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 14:15 [PATCH RESEND net v3 0/3] disable interrupts and ensure dbell updation Vimlesh Kumar
2026-01-30 14:15 ` [PATCH RESEND net v3 1/3] octeon_ep: disable per ring interrupts Vimlesh Kumar
2026-02-03 2:04 ` Jakub Kicinski [this message]
2026-01-30 14:15 ` [PATCH RESEND net v3 2/3] octeon_ep: ensure dbell BADDR updation Vimlesh Kumar
2026-01-30 14:15 ` [PATCH RESEND net v3 3/3] octeon_ep_vf: " Vimlesh Kumar
2026-02-03 2:03 ` [PATCH RESEND net v3 0/3] disable interrupts and ensure dbell updation Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202180450.372b216e@kernel.org \
--to=kuba@kernel.org \
--cc=aayarekar@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hgani@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox