From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44ACB38E5DC for ; Mon, 2 Feb 2026 23:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770075818; cv=none; b=MhPHko5FptPIzspQcVKJyRnv7xi53c1Ffetg7RuVMdw8EVTVjmZo9gcTpDiP4GCkz4BsFpe/3rnogaNppcz3M/xW05+6x4Y/jlhKCnJqcWz0WPP0gXkly2PwKHsohwpKQYIg5txyBD08iV66i6Mz1uK0dFbZpwgx5wt2y6Ppv2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770075818; c=relaxed/simple; bh=KxCZb7m68SELksBw6wq/ZEyhCC8tdMFOFPozDlx1NLA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ys6Fh914JsblQUwR9Be4QrR4RNZLuwnhWrfQHt20fg+XTt9anf1OO3gUSJCYV/9nzuCSod2a11LY7laZ/y8+l42gY48P1P7P4I+MDYhi0XtWwcYNOXcplDlxRv83O3d1YE72/l0QLygh7HmaIwnC+vie9g46iA08JLOiv8lsKSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Dfy31yYM; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Dfy31yYM" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-5029901389dso39433411cf.2 for ; Mon, 02 Feb 2026 15:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1770075816; x=1770680616; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lbr9I1sJrI4qHhUfKsSd+7bRl/Tu2BGmuFfiKL8Kjfk=; b=Dfy31yYMhftFrdX/IwpRlKvVYx5H0JZziADntAuB39boPb8nVEV6tcZu3VgaaOcDCa AZ7c38wacf0PN6/4V2YozSel+HBKTs5D+mNu+lG5HzgpbvekFE/U1poUlglpGtwc7GSS yDUDcdi6YMha6Ua3q++H612Ev3jOnnt9CdOK2ZyuYcou7mmlXR/JSFTPwqY8EyAUa8+r lqC/123+x4l56/XUvO8fMW1RJd+4643A2XuxfxE0buI2eU0RCscknjsVUvMQdGrfIOeP NMk49wPjnLKmvzw7ZD+hUmWtzjzB78bLy8iMOcsxqCF+P2+zrKy+wRKBgHKZRvBpBz4A sTKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770075816; x=1770680616; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lbr9I1sJrI4qHhUfKsSd+7bRl/Tu2BGmuFfiKL8Kjfk=; b=l+80Z+PdksEsIggUppJPP7docl2jJWR/si9njkWvmfHCTdgrlfHSpgIz1PMlaRfGwY OTBJ9np+jTopbszYurkVNeHvTVgIsu27g6V4KJHEukYiPL8pmw9aLIYdDh1P35xYRryR yMDVU03H4p8Ac2AyQFD/N8Wx+KBnwSpNs7PDvr6SZF2/Avrue211fMdkaHWzxdWSqyta 3AEUY54crfZy7nIGFGot7K07z9gGBUXTfhEbpqFKb08ni/f7Thgt3JIYaPRcYUEOOcI4 2cqS3TeYP3zv78yQXdYjMmt3ybpjfHPyFftel4izEGOjDl0x+ym3CSKYsatAe2iHfgsw Ro1g== X-Forwarded-Encrypted: i=1; AJvYcCWE2OmIo2EN22kH//RvYRHiVdFRaFkvoh37yz93bghRdvUgko+54l7eqpbvEP042PUZ/qKGvnWxw/ccUGo=@vger.kernel.org X-Gm-Message-State: AOJu0YyQjSFbegIDKx2isH2djmmAuV3l99yXAEScYqVJEze690yZCbb+ p00qiJrMK3yfmnEg+YaMbdjlJ9yZ5owF4z8OkSn2p2Qp3FX0GH1cYgDcMB/Wr5j/0AM= X-Gm-Gg: AZuq6aI4+zUzq6fstVk9Trdx+cq+RjyPb95DmNu2shvK2t7wXne3FOqNDj3Un3SoAMa eXUmED4ZkYVnOpP9CHcoPTyNRvtRPRtTc1eBzJsr4qpgJ3LGvtGRO0kgftI9W6bzVczyLqbffpK S/XTdusfP54MzliA4apAUQxgnVYuopqkoo0ormF5qSgkZvfDXXBjnf/ElRMT4JnhB+isE4qZt0K znxi55e1E2zqJCfMW/JaqW8U84UXSUJh4cuWJ8naoqOj3qgin5L2zLhLX2JeAEDLOKxq/yKtQhr VBMXltB9nM8JXttdGx67sEpqGRvF7QNtWhPg8mSyQaHCJ/n1lge9hJwNnG7PkCqhADoO2yLt9aM 0ouUrboBX4SZ67IdxtqpgpI7kx7zig3pQesndrCZ9UpUHx0us8PXLVf/SdXamJMW/yHdlrxDH3z YQJAHRri6EFkoEeMqsMkhoDH5UYuiqjbdqlZGr2KDJtgH9gldeNkh+vOHhJJ0+qUFfNOw= X-Received: by 2002:ac8:7f0e:0:b0:505:d171:7e44 with SMTP id d75a77b69052e-505d22dd9efmr158787551cf.81.1770075816093; Mon, 02 Feb 2026 15:43:36 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50337ba4126sm120033811cf.21.2026.02.02.15.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 15:43:35 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vn3Zu-0000000GNqC-2QL9; Mon, 02 Feb 2026 19:43:34 -0400 Date: Mon, 2 Feb 2026 19:43:34 -0400 From: Jason Gunthorpe To: Viktor Kleen Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/vt-d: Treat PAGE_SNOOP and PWSNP separately Message-ID: <20260202234334.GM2328995@ziepe.ca> References: <20260202192109.1665799-1-viktor@kleen.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202192109.1665799-1-viktor@kleen.org> On Mon, Feb 02, 2026 at 07:21:05PM +0000, Viktor Kleen wrote: > The PASID_FLAG_PAGE_SNOOP and PASID_FLAG_PWSNP constants are identical. > This will cause the pasid code to always set both or neither of the > PGSNP and PWSNP bits in PASID table entries. However, PWSNP is a > reserved bit if SMPWC is not set in the IOMMU's extended capability > register, even if SC is supported. > > This has resulted in DMAR errors when testing the iommufd code on an > Arrow Lake platform. With this patch, those errors disappear and the > PASID table entries look correct. > > Fixes: 101a2854110fa ("iommu/vt-d: Follow PT_FEAT_DMA_INCOHERENT into the PASID entry") > Signed-off-by: Viktor Kleen > --- > drivers/iommu/intel/pasid.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) It looks like a typo to me too Reviewed-by: Jason Gunthorpe It should also be: Cc: stable@vger.kernel.org Jason