From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Luka Gejak <lukagejak5@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/5] staging: rtl8723bs: fix LONG_LINE warnings across C files
Date: Mon, 2 Feb 2026 09:35:45 +0100 [thread overview]
Message-ID: <2026020224-casket-trailing-8a3c@gregkh> (raw)
In-Reply-To: <20260202070752.3391-6-lukagejak5@gmail.com>
On Mon, Feb 02, 2026 at 08:07:52AM +0100, Luka Gejak wrote:
> Refactor lines exceeding 100 characters to comply with kernel coding
> style. All changes preserve original logic and behavior.
>
> Techniques used:
> - Move trailing comments to separate lines above code
> - Break long function signatures across multiple lines
> - Extract complex expressions into named temp variables
> - Use scoped blocks for local variable declarations
> - Create pointer aliases for deeply nested struct accesses
> - Simplify compound conditionals with intermediate booleans
>
> Files modified:
> - core/: rtw_cmd.c, rtw_ieee80211.c, rtw_io.c, rtw_ioctl_set.c,
> rtw_mlme.c, rtw_mlme_ext.c, rtw_pwrctrl.c, rtw_recv.c,
> rtw_security.c, rtw_wlan_util.c, rtw_xmit.c
> - hal/: HalBtc8723b1Ant.c, HalBtc8723b2Ant.c, HalPhyRf.c,
> HalPhyRf_8723B.c, hal_com.c, hal_com_phycfg.c, hal_intf.c,
> hal_sdio.c, odm.c, odm_DIG.c, odm_HWConfig.c, rtl8723b_cmd.c,
> rtl8723b_hal_init.c, rtl8723b_phycfg.c, rtl8723b_rf6052.c,
> rtl8723bs_recv.c, rtl8723bs_xmit.c, sdio_halinit.c
> - os_dep/: ioctl_cfg80211.c, os_intfs.c, sdio_intf.c, xmit_linux.c
>
Was this generated by ai?
Anyway, it does way too much, my bot will say more...
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-02 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 7:07 [PATCH v1 0/5] staging: rtl8723bs: code cleanup and style fixes Luka Gejak
2026-02-02 7:07 ` [PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips Luka Gejak
2026-02-02 8:36 ` Greg Kroah-Hartman
2026-02-02 7:07 ` [PATCH v1 2/5] staging: rtl8723bs: convert PSTA_INFO_T to struct sta_info * Luka Gejak
2026-02-02 7:07 ` [PATCH v1 3/5] staging: rtl8723bs: remove NDIS type aliases Luka Gejak
2026-02-02 7:07 ` [PATCH v1 4/5] staging: rtl8723bs: remove redundant MAC_ARG macro Luka Gejak
2026-02-02 7:07 ` [PATCH v1 5/5] staging: rtl8723bs: fix LONG_LINE warnings across C files Luka Gejak
2026-02-02 8:35 ` Greg Kroah-Hartman [this message]
2026-02-02 8:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020224-casket-trailing-8a3c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lukagejak5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox