From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>,
Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>,
axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
nitin.rawat@oss.qualcomm.com, Leon Romanovsky <leon@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
iommu@lists.linux.dev
Subject: Re: [PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Date: Tue, 3 Feb 2026 07:23:34 +0100 [thread overview]
Message-ID: <20260203062334.GI16426@lst.de> (raw)
In-Reply-To: <aYGSP4luf1nOFhS2@kbusch-mbp>
On Mon, Feb 02, 2026 at 11:14:23PM -0700, Keith Busch wrote:
> On Tue, Feb 03, 2026 at 06:27:56AM +0100, Christoph Hellwig wrote:
> > > iod->nr_descriptors = 0;
> > > iod->total_len = 0;
> > > iod->meta_total_len = 0;
> > > + iod->nr_dma_vecs = 0;
> > > + iod->dma_vecs = NULL;
> >
> > I don't think we need the dma_vecs initialization here, as everything
> > is keyed off nr_dma_vecs.
>
> Yes, we should definitely use nr_dma_vecs and skip the NULL setting. I'm
> a big fan removing unnecessary initialisations. Just a caution, my
> suggested patch has this check:
>
> if (!iod->dma_vecs)
>
> So we just need to update it to use 'iod->nr_dma_vecs' instead, which
> would have been correct, too.
Ah, right.
next prev parent reply other threads:[~2026-02-03 6:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 12:57 [PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next Pradeep P V K
2026-02-02 14:35 ` Christoph Hellwig
2026-02-02 15:16 ` Robin Murphy
2026-02-02 15:58 ` Leon Romanovsky
2026-02-02 17:13 ` Keith Busch
2026-02-02 17:36 ` Christoph Hellwig
2026-02-02 18:59 ` Keith Busch
2026-02-03 5:27 ` Christoph Hellwig
2026-02-03 6:14 ` Keith Busch
2026-02-03 6:23 ` Christoph Hellwig [this message]
2026-02-03 14:05 ` Pradeep Pragallapati
2026-02-04 14:04 ` Pradeep Pragallapati
2026-02-04 14:27 ` Keith Busch
2026-02-03 9:42 ` Leon Romanovsky
2026-02-03 13:50 ` Robin Murphy
2026-02-03 17:41 ` Keith Busch
2026-02-02 17:39 ` Robin Murphy
2026-02-02 15:22 ` Leon Romanovsky
2026-02-02 15:26 ` Robin Murphy
2026-02-02 17:18 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203062334.GI16426@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=iommu@lists.linux.dev \
--cc=kbusch@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=nitin.rawat@oss.qualcomm.com \
--cc=pradeep.pragallapati@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox