From: Adarsh Das <adarshdas950@gmail.com>
To: Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Adarsh Das <adarshdas950@gmail.com>
Subject: [PATCH 2/2] btrfs: replace BUG() with error handling in __btrfs_balance()
Date: Tue, 3 Feb 2026 22:53:57 +0530 [thread overview]
Message-ID: <20260203172357.65383-3-adarshdas950@gmail.com> (raw)
In-Reply-To: <20260203172357.65383-1-adarshdas950@gmail.com>
We search with offset (u64)-1 which should never match exactly.
Previously this was handled with BUG(). Now logs an error
and return -EUCLEAN.
Signed-off-by: Adarsh Das <adarshdas950@gmail.com>
---
fs/btrfs/volumes.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 8a08412f3529..0e1cc0c4ce68 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -4112,8 +4112,14 @@ static int __btrfs_balance(struct btrfs_fs_info *fs_info)
* this shouldn't happen, it means the last relocate
* failed
*/
- if (ret == 0)
- BUG(); /* FIXME break ? */
+ if (unlikely(ret == 0)) {
+ btrfs_err(fs_info,
+ "unexpected exact match in chunk tree search, offset 0x%llx",
+ key.offset);
+ mutex_unlock(&fs_info->reclaim_bgs_lock);
+ ret = -EUCLEAN;
+ goto error;
+ }
ret = btrfs_previous_item(chunk_root, path, 0,
BTRFS_CHUNK_ITEM_KEY);
--
2.53.0
next prev parent reply other threads:[~2026-02-03 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 17:23 [PATCH 0/2] btrfs: clean up two FIXMEs related to btrfs_search_slot output handling Adarsh Das
2026-02-03 17:23 ` [PATCH 1/2] btrfs: handle unexpected exact match in btrfs_set_inode_index_count() Adarsh Das
2026-02-03 17:23 ` Adarsh Das [this message]
2026-02-03 21:06 ` [PATCH 0/2] btrfs: clean up two FIXMEs related to btrfs_search_slot output handling Qu Wenruo
2026-02-04 14:03 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203172357.65383-3-adarshdas950@gmail.com \
--to=adarshdas950@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox