From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E59D258EE0 for ; Tue, 3 Feb 2026 18:48:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770144486; cv=none; b=iHmPZe5WHftmTJwdvYow6LcRXInGUY8D4Nmj+cjUQV91CdO1AfW00rLCQKpeUNRH+EC9M1aUu2XpsZyEoFGVdonZdXXAc5vomVSbqlUK4mSAZ4HeSOClip19z7x8U9JW1h97CvdV+pr6kmo/b+pk1cUhKq7BwLB6tKNY4cwx3ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770144486; c=relaxed/simple; bh=fBTZF5V3OHVnYbaSfxxymuwp/kdmALazG83Glp0PHe4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZlCh58/fhR6iKcrI+9blCzyenvSa4vEmnq3R1KGJcIp3KEkPr+Lu5WJky0Xrs2RXhsthXf07AkrZpWIOy/PFdD5XIyhbpJSa22gZpqtU7R+cVFSMulTAI/Dne8CzvgQlkJoB5GfZP3Oe84YKVOtwK98NzPLA0asgZRjZeQ3cKOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=PneUsPja; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="PneUsPja" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2b704f08e73so85137eec.1 for ; Tue, 03 Feb 2026 10:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1770144484; x=1770749284; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=toEdX66AExMzMeOPPD7ACZ/dROdO5SBZOD0RUcnczeQ=; b=PneUsPjapgH4YdlwSTNQn+plAdECLsSxLDYeEAZXjFULIkqqNJ/pk8ew4nPqeQEIaz kJ45UXsb+MUibi4lwLs6hsu4YbLGA03pAT8u75sBBXcsHrXWnPz7c3hVhs/rkx0rUXHR mq7Ub/322UImpxMSATf6THAfQLPZAmRUFnUsAFo7LiXokq8lmMvPxkWpT9YefIyuhUUq 0DhR/uB7E7s3nEHSrhSTUaS8+dIHSTqiDVMmKjBPBaI7IFNS9WVcIP1OSfVgRiOAAJY3 FER+gg+7ckUbM/UDpGdBpTtiFMx9p/9pg38lr0tZgu3DtDW6/GHiSefYccJSoGkG0OwS iNYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770144484; x=1770749284; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=toEdX66AExMzMeOPPD7ACZ/dROdO5SBZOD0RUcnczeQ=; b=FokRxvOWVdtpcyflolF29znPYZAhyBmusQx4j0y9fJEYFNtQh13eKh0lIL8FOJQ8vO uCEcctVzWy8CD1JWViKdfXjeNO0+ZtzaGSJBeeSnbGbL54bTLel+EfkI3DqPKUWPGPBN a8uRZMpr3tF3cVwVEuNhmc0EyHiQgGXgmHw3u0cKsn8yF6doWgk9lgbWc/xgRg3Gr4g/ mRTRvDvfjaIXY47tN7h2+K8hCnO91odfRlcQY0t2HajxBZ73+L8KoQ3vivUvshpBFooQ DPLsfyd4R5oD2vqR1TV6/jP0r2zxwVPGndX42VAoEE8OcCJ2jvCmHFVr7houqStujXq9 rmXA== X-Forwarded-Encrypted: i=1; AJvYcCXFhoX8ySEeSMh+Qa8CXizi/13Yt8vkYsa/+Se1d3FdoeSeACzQQxBZoMJrWtRPl3A2DKk+eMcD9E3b1ls=@vger.kernel.org X-Gm-Message-State: AOJu0YxckHipV+MHVKIlXXHa7DV1heT9WdgAFg22s4R4ChvALN+pPz+F dzzcVrRjuNxWYttNXCBaCUq0/s9kMG5SkCxlSyR/2Gn/zDyCyqVQOPTMe5B2P4sq/a0= X-Gm-Gg: AZuq6aJU7KfFc6o54zyO7X+SEx/hPLWnqV/IB+ragqBgoVn+ZqO60Ka4Px+/5QjX6G+ ByUglTg0wTwJUmyh/x2dLodHCDMCUWSfNcgdqlDpIUFxtMhMHW3wlqZgBqDITORFieNxx9B2GBN WQZ8H2RR1eAAa2LTnIv10kIm2o3s3nSQHPOG5ZpaxJgAXF1990eYhcFcEhdbg5w+EMvYZxRJVkB st7BTtBSZ6MXKBq5dQLBut03gwP/VknWw+0WuFrtGWaes1de2YxbUglk/OgQbfn/ga1eHtVrc8m ws8BVEWQv9xWyKUkKFbLOSt6nronLJby+MjcU/AsTVpofeZiPfFrEO88nYTZKKU0YkOsQZp/FAg J5KCAHc8DN84vDsnEcijJrWRwYzjmfzcN180TpV4iqnjKCkGE0+JzOj2v7qr7b5eVom7u8h82/g rYXZ8cxbXAVttJ3fHGeOVjhn9G0oBPCX+humkL4N9IfQ== X-Received: by 2002:a05:7300:ed0a:b0:2b7:a6fa:3f87 with SMTP id 5a478bee46e88-2b832ec924cmr130840eec.19.1770144483742; Tue, 03 Feb 2026 10:48:03 -0800 (PST) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with UTF8SMTPSA id 5a478bee46e88-2b832feacc6sm266190eec.35.2026.02.03.10.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 10:48:03 -0800 (PST) Date: Tue, 3 Feb 2026 10:48:02 -0800 From: Mohamed Khalfella To: Hannes Reinecke Cc: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/14] nvmet: Send an AEN on CCR completion Message-ID: <20260203184802.GC3729-mkhalfella@purestorage.com> References: <20260130223531.2478849-1-mkhalfella@purestorage.com> <20260130223531.2478849-6-mkhalfella@purestorage.com> <3e5a7153-662d-479f-8205-c17cd3f35455@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3e5a7153-662d-479f-8205-c17cd3f35455@suse.de> On Tue 2026-02-03 04:27:39 +0100, Hannes Reinecke wrote: > On 1/30/26 23:34, Mohamed Khalfella wrote: > > Send an AEN to initiator when impacted controller exists. The > > notification points to CCR log page that initiator can read to check > > which CCR operation completed. > > > > Signed-off-by: Mohamed Khalfella > > --- > > drivers/nvme/target/core.c | 25 ++++++++++++++++++++++--- > > drivers/nvme/target/nvmet.h | 3 ++- > > include/linux/nvme.h | 3 +++ > > 3 files changed, 27 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c > > index 54dd0dcfa12b..ae2fe9f90bcd 100644 > > --- a/drivers/nvme/target/core.c > > +++ b/drivers/nvme/target/core.c > > @@ -202,7 +202,7 @@ static void nvmet_async_event_work(struct work_struct *work) > > nvmet_async_events_process(ctrl); > > } > > > > -void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, > > +static void nvmet_add_async_event_locked(struct nvmet_ctrl *ctrl, u8 event_type, > > u8 event_info, u8 log_page) > > { > > struct nvmet_async_event *aen; > > @@ -215,13 +215,19 @@ void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, > > aen->event_info = event_info; > > aen->log_page = log_page; > > > > - mutex_lock(&ctrl->lock); > > list_add_tail(&aen->entry, &ctrl->async_events); > > - mutex_unlock(&ctrl->lock); > > > > queue_work(nvmet_wq, &ctrl->async_event_work); > > } > > > > +void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, > > + u8 event_info, u8 log_page) > > +{ > > + mutex_lock(&ctrl->lock); > > + nvmet_add_async_event_locked(ctrl, event_type, event_info, log_page); > > + mutex_unlock(&ctrl->lock); > > +} > > + > > static void nvmet_add_to_changed_ns_log(struct nvmet_ctrl *ctrl, __le32 nsid) > > { > > u32 i; > > @@ -1788,6 +1794,18 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_alloc_ctrl_args *args) > > } > > EXPORT_SYMBOL_GPL(nvmet_alloc_ctrl); > > > > +static void nvmet_ctrl_notify_ccr(struct nvmet_ctrl *ctrl) > > +{ > > + lockdep_assert_held(&ctrl->lock); > > + > > + if (nvmet_aen_bit_disabled(ctrl, NVME_AEN_BIT_CCR_COMPLETE)) > > + return; > > + > > + nvmet_add_async_event_locked(ctrl, NVME_AER_NOTICE, > > + NVME_AER_NOTICE_CCR_COMPLETED, > > + NVME_LOG_CCR); > > +} > > + > > static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) > > { > > struct nvmet_subsys *subsys = ctrl->subsys; > > But what does the CCR command actually _do_? > At the very lease I would have expected it to trigger a controller reset > (eg calling into nvmet_ctrl_fatal_error()), yet I don't see it doing > that anywhere ... [PATCH v2 03/14] nvmet: Implement CCR nvme command is where impacted controller is told to fail. It does exactly what you mentioned above. +out_unlock: + mutex_unlock(&sctrl->lock); + if (status == NVME_SC_SUCCESS) + nvmet_ctrl_fatal_error(ictrl); + nvmet_ctrl_put(ictrl); +out: + nvmet_req_complete(req, status); I refactored the error handling codepath into success codepath. That is why I think it is kind of hidden. If this is not obvious I can separate the two codepaths. What do you think?