From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F653310620 for ; Tue, 3 Feb 2026 23:08:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160084; cv=none; b=jAq9MFP0HukwCgoYemx5PM7869rVaTBwuKxqgU7q/jImpPnpZQSC846bvT1rSiaV+Tkhf6wonxB11+emhdAbS+2HDsga3mNg4m5Y7dp4NComeJ0LQJ2SYOcYGeZUkSbvZrpNQ3GvXPSc1P4oqLfpoGVX6uis89QyLt6rOZ+6i/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770160084; c=relaxed/simple; bh=B7JjV3GFU7Uh5QssvSt50BbkBYppkGhl3wSBvqUdL1o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=adSRCXyAtxBNUnvM3YqrLa0FwhPxGevYLGDjPmFyZV6bw0FmvXDsFrYtbT2mxOzfmpEzJ0rx4eCFC9h1/g4MWdyICKuGowA/ogC4wnHwMxwoJUQeI85uApnrNsvhZgWqqnymLKNBXV8jzUQVT45dLeY43Ohupuua3z4M9gdRAak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CPGBuMjD; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CPGBuMjD" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b8e9c8ada38so36774666b.0 for ; Tue, 03 Feb 2026 15:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770160081; x=1770764881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hyuu5DQHN0kM/6Ii1doCyC/+2p0/fE93hPD6MhvTzyo=; b=CPGBuMjDoNMpknzAiX02SO//NgOc5o+4hHzjEK7qmfXndjSJL/d/lbmXFbkgv2GCSm /aGdit/bNPzE/F6W1pzgs6NA+IvRRoy4hbQRNoY++k1T55mzNNhbcRGHGcbA1Od7tw9F /E7zJcZ+06u9eYPeRvXrOQIPSEbPpHVF10lBj5kyhOB0bGZFZREr2HNhWokscrk09AjF K8vGTIUKVivGhIdOgUOAZ64xO5g3CAqoINXs4PEabk7+NJ9OsYYazpnq0nmQhW1E6E4V kFu2xyUS8Ikx4/99xI/17caskYvnS+HI94yYBgr1u3R4gSjuzymVcATMQu8Ma+fqMeXW M7Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770160081; x=1770764881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Hyuu5DQHN0kM/6Ii1doCyC/+2p0/fE93hPD6MhvTzyo=; b=lXhZsgQ2rxFWO5xNLNAi4ao7d+ZvTpiSb+AmgijdgJJY5i91Azc2m8hs5sK1sXCrlC 1g8cbwg9/c+uQcRiObhwqSJ9Fd2r/3dvG/XWnSIpfKTZQ2RSuFkkI3YwOLBf8i2Kmri/ kQC2xrsxUYLaVTYYQaqf27QucTJ0KXabSppz6IFzGYWkaUEdXdQY6ylP71R2c+q9hyCu IW3T9y6F0iHm0SOaFq6HDhJu9vpvls0xqa3MNkigys3gwUlgfbRAu1v2EXm33nVluSnv SzvyN4wqwgMtNFZHc98jRhAyk1ifFFX1T7tc5I+rvVWTKKd1SO6alJBRnGh/1bjry8zH AE/w== X-Forwarded-Encrypted: i=1; AJvYcCUCiat/NMd4P7NAnvvgPnjhBsJMKSQj77UDvySeDJ4M+bUj3qFdsTJTtOVm0j9n4dVPGnK0hg+6scO5SR4=@vger.kernel.org X-Gm-Message-State: AOJu0YxqZP7/Sa9nZsnVvurWS6hHjmA4yPquaTYAHaTDuIFD9e6gzjey BxR/5M9mlClCQUpJyzbCCsndaaLQTowsGxDR3xfdJ3knyqrz8+CYEJQn X-Gm-Gg: AZuq6aIE/s3cVsGY/GQVSvRUiZnajumW90n1xRhDGtAc+BtyasjHgwBGvuRPQbPtKKK h2RRnLn9pqnx1QBUuIWlAyPq/x0c/TZ+FDxLK2P6RKLGg39dYzmQfi2Qr6L+mB2Zg3C62Q0cmoS qTlmI0LwV157fNoj5a8Mc/8JNcbh0VJALEuzs2r7qWtXh9CDd8jsLs7G6hFrWR1yH8BtPBtBQ+H f8zVN0SE4/+ouKhjbaGN8IKzcFrLwDOYfcUO9Y4ikCJEONZVOjm3jxNDmbEGCOtvOREBo/0DBMp tjUUEm5XWdEt7JD7umTxiOjpVSudQy1U6b6NEcquhC730hw9UP1LLjorxofEcj0oY/9ctlbpnrm KNul2O+7n4rKqO9Py07gPW+s+n8gVb6aVSIhmYKkc16QCbQ2ZSq3hOKEHR0yfLsHatfUvaAEGzj aigNf19aa8FFJNbyZmA3DsU4U53PiaIR1Accxnlr8AFu8aLZLSqfeybEfpDJuBPI4n++uwsbsGJ +pjxir/Q6B7wK35OW/tuQTUM2Ysna55BungcNla+5uYurovn5CcNEshNuQ= X-Received: by 2002:a17:906:9fd1:b0:b72:70ad:b8f0 with SMTP id a640c23a62f3a-b8e9f19471bmr74044066b.36.1770160080597; Tue, 03 Feb 2026 15:08:00 -0800 (PST) Received: from cs-874966990260-default.europe-west4-b.c.od237066db22328bb-tp.internal (33.242.13.34.bc.googleusercontent.com. [34.13.242.33]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8ea0021b3bsm38486566b.49.2026.02.03.15.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 15:08:00 -0800 (PST) From: Artem Lytkin To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artem Lytkin Subject: [PATCH 2/4] staging: sm750fb: use strcmp() for exact option matching Date: Tue, 3 Feb 2026 23:07:56 +0000 Message-ID: <20260203230758.3056-2-iprintercanon@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260203230758.3056-1-iprintercanon@gmail.com> References: <20260203230758.3056-1-iprintercanon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace strncmp(opt, "...", strlen("...")) with strcmp() in option parsing functions. Options from strsep() are complete null-terminated tokens, so prefix matching via strncmp() could cause false positives for options like "noaccelXYZ" matching "noaccel". Signed-off-by: Artem Lytkin --- drivers/staging/sm750fb/sm750.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 4c6e84c03..bd2d4a290 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -937,21 +937,21 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt); dev_info(&sm750_dev->pdev->dev, "src=%s\n", src); - if (!strncmp(opt, "swap", strlen("swap"))) { + if (!strcmp(opt, "swap")) { swap = 1; - } else if (!strncmp(opt, "nocrt", strlen("nocrt"))) { + } else if (!strcmp(opt, "nocrt")) { sm750_dev->nocrt = 1; - } else if (!strncmp(opt, "36bit", strlen("36bit"))) { + } else if (!strcmp(opt, "36bit")) { sm750_dev->pnltype = sm750_doubleTFT; - } else if (!strncmp(opt, "18bit", strlen("18bit"))) { + } else if (!strcmp(opt, "18bit")) { sm750_dev->pnltype = sm750_dualTFT; - } else if (!strncmp(opt, "24bit", strlen("24bit"))) { + } else if (!strcmp(opt, "24bit")) { sm750_dev->pnltype = sm750_24TFT; - } else if (!strncmp(opt, "nohwc0", strlen("nohwc0"))) { + } else if (!strcmp(opt, "nohwc0")) { g_hwcursor &= ~0x1; - } else if (!strncmp(opt, "nohwc1", strlen("nohwc1"))) { + } else if (!strcmp(opt, "nohwc1")) { g_hwcursor &= ~0x2; - } else if (!strncmp(opt, "nohwc", strlen("nohwc"))) { + } else if (!strcmp(opt, "nohwc")) { g_hwcursor = 0; } else { if (!g_fbmode[0]) { @@ -1156,11 +1156,11 @@ static int __init lynxfb_setup(char *options) */ while ((opt = strsep(&options, ":")) != NULL) { /* options that mean for any lynx chips are configured here */ - if (!strncmp(opt, "noaccel", strlen("noaccel"))) { + if (!strcmp(opt, "noaccel")) { g_noaccel = 1; - } else if (!strncmp(opt, "nomtrr", strlen("nomtrr"))) { + } else if (!strcmp(opt, "nomtrr")) { g_nomtrr = 1; - } else if (!strncmp(opt, "dual", strlen("dual"))) { + } else if (!strcmp(opt, "dual")) { g_dualview = 1; } else { memcpy(tmp, opt, strlen(opt)); -- 2.43.0