From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 204B533D6CE for ; Tue, 3 Feb 2026 12:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770120657; cv=none; b=LeVVg8iYoq4+W6UeZ0ICEusr083MLntID2iTqmPO9bwSJLvWYyJKrMEFnXfGrcFD1WYCikII9vdBehMapODhnuKGCFiJcWBsSUUWU+6GZVmHXe2ew8v5+fg8lZYYSGzeaRX1B4UG6r2YLxDxUP4Phh2RjTmcPe7IruQGtc7TIr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770120657; c=relaxed/simple; bh=kBySj3Ukyma8rhS/50fWhU+M52FQCMQCYUPjuFxfZfA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZO7T9IIF3xy/24746KzxL7RTKg3C7mx8ZiswXX+1ZlGuqpyxGvlibeAe5jB6PLBt4uSabVCgisoWoVQ8tfGRGoTIDuSpBcTv3EDx86aHIH3qKBFWdHKZh8y9aqkol3mgbAxwmRsUdDyKyBw5HqGKAaFPxemaJyx7WW5iBlCBmAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dvn4w0Eq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dvn4w0Eq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38949C116D0; Tue, 3 Feb 2026 12:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770120656; bh=kBySj3Ukyma8rhS/50fWhU+M52FQCMQCYUPjuFxfZfA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dvn4w0Eqor7Ii4QEoodGd7O1bkAbsihBAm2kURTcATh5pOo8zMikfa/0vJO4BDEE7 gY3+PClYRy5Z+0ldoyyZe/zZoHIYNP7QHU8EJYLrm0yKZU5uYtyk4tpNlmTInUCCEB 5fBUg1Md52/qnU5WzOM2dQs+rdVQ8/Vd60c/lAU0= Date: Tue, 3 Feb 2026 13:10:53 +0100 From: Greg Kroah-Hartman To: Alice Ryhl Cc: Carlos Llamas , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node() Message-ID: <2026020335-dragonish-throwing-3d46@gregkh> References: <20260128-binder-fix-target-node-null-v1-1-78d198ef55a5@google.com> <2026020323-oversold-goon-b522@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 03, 2026 at 11:56:31AM +0000, Alice Ryhl wrote: > On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote: > > > Somehow this got changed to NULL when I ported this to upstream it. No > > > idea how that happened. > > > > > > Reported-by: Carlos Llamas > > > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com > > > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint") > > > Signed-off-by: Alice Ryhl > > > --- > > > Commit not yet upstream, so cc stable not required. > > > --- > > > drivers/android/binder/rust_binder.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h > > > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644 > > > --- a/drivers/android/binder/rust_binder.h > > > +++ b/drivers/android/binder/rust_binder.h > > > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t > > > > > > if (p) > > > p = p + RUST_BINDER_LAYOUT.n.arc_offset; > > > - return NULL; > > > + return p; > > > } > > > > > > static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t) > > > > > > --- > > > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd > > > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200 > > > > Does not apply at all, what tree was this made against? > > This applies on char-misc-next. It's a fix for commit c1ea31205edf, > which currently only exists in that branch. Our emails crossed, my fault, I was looking at the wrong tree. Now applied, thanks! greg k-h