public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Miguel Ojeda <ojeda@kernel.org>,
	Matthew Maurer <mmaurer@google.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: kconfig: Don't require RUST_IS_AVAILABLE for rustc-option
Date: Wed, 4 Feb 2026 00:49:09 -0700	[thread overview]
Message-ID: <20260204074909.GC1632007@ax162> (raw)
In-Reply-To: <CAK7LNASdG9P90Hnc3M4zK67S_kRtcs5kv8MX7n_B6S5x=FKENw@mail.gmail.com>

On Wed, Feb 04, 2026 at 04:17:26PM +0900, Masahiro Yamada wrote:
> On Wed, Feb 4, 2026 at 9:16 AM Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > On Tue, 09 Sep 2025 18:14:20 +0000, Matthew Maurer wrote:
> > > The final version of this macro does not fail in the absence of an
> > > invokable `$(RUSTC)`, so we don't need to be careful not to invoke it.
> > >
> > >
> >
> > Applied to
> >
> >   https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git kbuild-next
> >
> > Thanks!
> >
> > [1/1] rust: kconfig: Don't require RUST_IS_AVAILABLE for rustc-option
> >       https://git.kernel.org/kbuild/c/f2445d6f264c6
> >
> > Please look out for regression or issue reports or other follow up
> > comments, as they may result in the patch/series getting dropped or
> > reverted. Patches applied to an "unstable" branch are accepted pending
> > wider testing in -next and any post-commit review; they will generally
> > be moved to the main branch in a week if no issues are found.
> >
> > Best regards,
> > --
> > Nathan Chancellor <nathan@kernel.org>
> >
> >
> 
> Removing this comment is correct, but please note
> the commit description is not accurate.
> 
> Kconfig evaluates all $(shell ...) macros before deciding the
> value of RUSAT_IS_AVAILABLE.
> You cannot prevent Kconfig from evaluating $(shell ...).
> The author of c42297438aee7 did not read
> Documentation/kbuild/kconfig-macro-language.rst

Ugh, yes, sorry, I should have caught that too because I just recently
looked at this in another thread :(

  https://lore.kernel.org/20260129232535.GD844102@ax162/

I'd rather not rebase at this point but I appreciate you clarifying this
for the record.

Cheers,
Nathan

      reply	other threads:[~2026-02-04  7:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 18:14 [PATCH] rust: kconfig: Don't require RUST_IS_AVAILABLE for rustc-option Matthew Maurer
2026-02-04  0:16 ` Nathan Chancellor
2026-02-04  7:17   ` Masahiro Yamada
2026-02-04  7:49     ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204074909.GC1632007@ax162 \
    --to=nathan@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mmaurer@google.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox